linux-toradex.git/sound/drivers/vx, branch v5.0

ALSA: drivers: Remove empty init and exit

2018-08-03T14:11:30+00:00

For a sake of code simplification, remove the init and the exit
entries that do nothing.

Notes for readers: actually it's OK to remove *both* init and exit,
but not OK to remove the exit entry.  By removing only the exit while
keeping init, the module becomes permanently loaded; i.e. you cannot
unload it any longer!

Signed-off-by: Takashi Iwai

ALSA: pcm: Nuke snd_pcm_lib_mmap_vmalloc()

2018-07-18T06:24:29+00:00

snd_pcm_lib_mmap_vmalloc() was supposed to be implemented with
somewhat special for vmalloc handling, but in the end, this turned to
just the default handler, i.e. NULL.  As the situation has never
changed over decades, let's rip it off.

Reviewed-by: Takashi Sakamoto 
Signed-off-by: Takashi Iwai

ALSA: vx: Put missing KERN_CONT prefix

2017-08-31T09:01:17+00:00

The vx driver has a debug printk code without proper KERN_ prefix.
On recent kernels, KERN_CONT prefix is mandatory for continued output
lines.  Put it properly.

Signed-off-by: Takashi Iwai

ALSA: drivers: make snd_pcm_hardware const

2017-08-17T10:44:09+00:00

Make these const as they are only used in a copy operation.
Done using Coccinelle.

Signed-off-by: Bhumika Goyal 
Signed-off-by: Takashi Iwai

ALSA: vx: vx_pcm: constify vx_pcm_playback_ops and vx_pcm_capture_ops.

2017-06-09T07:20:37+00:00

File size before:
   text	   data	    bss	    dec	    hex	filename
   7126	    240	      0	   7366	   1cc6	sound/drivers/vx/vx_pcm.o

File size After adding 'const':
   text	   data	    bss	    dec	    hex	filename
   7382	      0	      0	   7382	   1cd6	sound/drivers/vx/vx_pcm.o

Signed-off-by: Arvind Yadav 
Signed-off-by: Takashi Iwai

ALSA: declare snd_kcontrol_new structures as const

2017-05-30T08:29:25+00:00

Declare snd_kcontrol_new structures as const as they are only passed an
argument to the function snd_ctl_new1. This argument is of type const,
so snd_kcontrol_new structures having this property can be made const.
Done using Coccinelle:

@r disable optional_qualifier@
identifier x;
position p;
@@
static struct snd_kcontrol_new x@p={...};

@ok@
identifier r.x;
position p;
@@
snd_ctl_new1(&x@p,...)

@bad@
position p != {r.p,ok.p};
identifier r.x;
@@
x@p

@depends on !bad disable optional_qualifier@
identifier r.x;
@@
+const
struct snd_kcontrol_new x;

Cross compiled these files:
sound/aoa/codecs/tas.c - powerpc
sound/mips/{hal2.c/sgio2audio.c} - mips
sound/ppc/{awacs.c/beep.c/tumbler.c} - powerpc
sound/soc/sh/siu_dai.c - sh
Could not find an architecture to compile sound/sh/aica.c.

Signed-off-by: Bhumika Goyal 
Acked-by: Mark Brown 
Signed-off-by: Takashi Iwai

ALSA: vx: remove 'out of memory' message

2017-02-28T06:54:33+00:00

Reported by checkpatch.pl

Signed-off-by: Mihai Burduselu 
Signed-off-by: Takashi Iwai

ALSA: vx: Don't try to update capture stream before running

2017-01-04T17:01:35+00:00

The update of stream costs significantly, and we should avoid it
unless the stream really has started.  Check pipe->running flag
instead of pipe->prepared.

Signed-off-by: Takashi Iwai

ALSA: vx: Fix possible transfer overflow

2017-01-04T17:01:35+00:00

The pseudo DMA transfer codes in VX222 and VX-pocket driver have a
slight bug where they check the buffer boundary wrongly, and may
overflow.  Also, the zero sample count might be handled badly for the
playback (although it shouldn't happen in theory).  This patch
addresses these issues.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=141541
Signed-off-by: Takashi Iwai

ALSA: Include linux/io.h instead of asm/io.h

2015-01-28T15:49:33+00:00

Nowadays it's recommended.  Replace all in a shot.

Signed-off-by: Takashi Iwai