linux-toradex.git/sound/firewire/digi00x, branch master

ALSA: firewire: digi00x: Use guard() for spin locks

2025-08-30T08:02:21+00:00

Clean up the code using guard() for spin locks.

Merely code refactoring, and no behavior change.

Reviewed-by: Takashi Sakamoto 
Signed-off-by: Takashi Iwai 
Link: https://patch.msgid.link/20250828132802.9032-14-tiwai@suse.de

ALSA: firewire: digi00x: Use guard() for mutex locks

2025-08-30T08:02:21+00:00

Replace the manual mutex lock/unlock pairs with guard() for code
simplification.

Only code refactoring, and no behavior change.

Reviewed-by: Takashi Sakamoto 
Signed-off-by: Takashi Iwai 
Link: https://patch.msgid.link/20250828132802.9032-4-tiwai@suse.de

ALSA: firewire: digi00x: Use safer strscpy() instead of strcpy()

2025-07-11T07:52:34+00:00

Use a safer function strscpy() instead of strcpy() for copying to
arrays.

Only idiomatic code replacement, and no functional changes.

Signed-off-by: Takashi Iwai 
Reviewed-by: Takashi Sakamoto 
Link: https://patch.msgid.link/20250710100727.22653-16-tiwai@suse.de

ALSA: firewire: use nonatomic PCM operation

2024-09-04T12:51:54+00:00

In the former commits, the callback of isochronous context runs on usual
work process. In the case, ALSA PCM device has a flag, nonatomic, to
acquire mutex lock instead of spin lock for PCM substream group.

This commit uses the flag. It has an advantage in the case that ALSA PCM
application uses the large size of intermediate buffer, since it takes
too long time even in tasklet softIRQ to process many of isochronous
packets, then result in the delay of system event due to disabled IRQ so
long. It is avertible to switch to nonatomic operation.

Reviewed-by: Takashi Iwai 
Tested-by: Edmund Raile 
Link: https://lore.kernel.org/r/20240904125155.461886-6-o-takashi@sakamocchi.jp
Signed-off-by: Takashi Sakamoto

ALSA: firewire: Use -y instead of -objs in Makefile

2024-05-08T16:18:03+00:00

*-objs suffix is reserved rather for (user-space) host programs while
usually *-y suffix is used for kernel drivers (although *-objs works
for that purpose for now).

Let's correct the old usages of *-objs in Makefiles.

Cc: Takashi Sakamoto 
Signed-off-by: Takashi Iwai 
Reviewed-by: Takashi Sakamoto 
Reviewed-by: Andy Shevchenko 
Reviewed-by: Jaroslav Kysela 
Link: https://lore.kernel.org/r/20240507135513.14919-8-tiwai@suse.de

ALSA: firewire: Fix -Wformat-truncation warning for MIDI stream names

2023-09-15T11:22:06+00:00

The compile warnings at filling MIDI stream name strings are all
false-positive; the number of streams can't go so high.

For suppressing the warning, replace snprintf() with scnprintf().
As stated in the above, truncation doesn't matter.

Link: https://lore.kernel.org/r/20230915082802.28684-12-tiwai@suse.de
Reviewed-by: Takashi Sakamoto 
Tested-by: Takashi Sakamoto 
Signed-off-by: Takashi Iwai

Merge branch 'for-next' into for-linus

2023-06-26T13:23:23+00:00

Pull the 6.5-devel branch for upstreaming.

Signed-off-by: Takashi Iwai

ALSA: firewire: use 'GPL' string for module license contributed by Takashi Sakamoto

2023-06-12T12:38:58+00:00

In MODULE_LICENSE macro, "GPL" string obsoletes "GPL v2" string by a
commit bf7fbeeae6db ("module: Cure the MODULE_LICENSE "GPL" vs. "GPL v2"
bogosity").

This commit uses the preferable expression.

Signed-off-by: Takashi Sakamoto 
Link: https://lore.kernel.org/r/20230611144445.221529-2-o-takashi@sakamocchi.jp
Signed-off-by: Takashi Iwai

ALSA: firewire-digi00x: prevent potential use after free

2023-05-12T08:18:05+00:00

This code was supposed to return an error code if init_stream()
failed, but it instead freed dg00x->rx_stream and returned success.
This potentially leads to a use after free.

Fixes: 9a08067ec318 ("ALSA: firewire-digi00x: support AMDTP domain")
Signed-off-by: Dan Carpenter 
Link: https://lore.kernel.org/r/c224cbd5-d9e2-4cd4-9bcf-2138eb1d35c6@kili.mountain
Signed-off-by: Takashi Iwai

ALSA: firewire-lib: obsolete return value from context payload processing layer

2023-01-12T11:14:50+00:00

This commit obsoletes return value from the context payload processing layer
since the multiplier between the data block count and PCM frame count was
moved to the packet streaming processing layer.

Signed-off-by: Takashi Sakamoto 
Link: https://lore.kernel.org/r/20230110134933.322794-3-o-takashi@sakamocchi.jp
Signed-off-by: Takashi Iwai