linux-toradex.git/sound/firewire/fireworks, branch v3.18.13 Linux kernel for Apalis and Colibri modules ALSA: fireworks: fix an endianness bug for transaction length 2015-01-16T14:59:51+00:00 Takashi Sakamoto o-takashi@sakamocchi.jp 2015-01-07T15:31:16+00:00 9e31ed5fc640096f73626ec13d6793efae2a5ec5 commit 92cb46584e104e2f4b14a44959109ffe13524a26 upstream. Although the 't->length' is a big-endian value, it's used without any conversion. This means that the driver always uses 'length' parameter. Fixes: 555e8a8f7f14("ALSA: fireworks: Add command/response functionality into hwdep interface") Reported-by: Clemens Ladisch <clemens@ladisch.de> Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp> Signed-off-by: Takashi Iwai <tiwai@suse.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
commit 92cb46584e104e2f4b14a44959109ffe13524a26 upstream.

Although the 't->length' is a big-endian value, it's used without any
conversion. This means that the driver always uses 'length' parameter.

Fixes: 555e8a8f7f14("ALSA: fireworks: Add command/response functionality into hwdep interface")
Reported-by: Clemens Ladisch <clemens@ladisch.de>
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
ALSA: fireworks: fix specifiers in format strings for propper output 2014-08-05T07:15:20+00:00 Takashi Sakamoto o-takashi@sakamocchi.jp 2014-08-05T02:17:10+00:00 30225ed5ca9e8f713fe8e92859f698c5e82a429c Use %d for loop counter and %X for device capabilities. This is a supplemental patch for Hans Wennborg's patch. Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp> Signed-off-by: Takashi Iwai <tiwai@suse.de> 
Use %d for loop counter and %X for device capabilities. This is a
supplemental patch for Hans Wennborg's patch.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
ALSA: fireworks: fix %d confusingly prefixed with 0x in format strings 2014-08-04T11:17:23+00:00 Hans Wennborg hans@hanshq.net 2014-08-04T00:21:16+00:00 04b9906d8c03307a15f2333a6a975fec1f67e891 Signed-off-by: Hans Wennborg <hans@hanshq.net> Signed-off-by: Takashi Iwai <tiwai@suse.de> 
Signed-off-by: Hans Wennborg <hans@hanshq.net>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
ALSA: fireworks: Remove meaningless mutex_destroy() 2014-06-04T12:37:59+00:00 Takashi Sakamoto o-takashi@sakamocchi.jp 2014-06-04T06:25:36+00:00 021fb6f27591ff3eab29278d822935fe2d504a8b Currently mutex_destroy() is called in module's cleanup function. But after cleaned up, this mutex is automatically released. So this function call is meaningless. [fixed a typo in changelog by tiwai] Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp> Signed-off-by: Takashi Iwai <tiwai@suse.de> 
Currently mutex_destroy() is called in module's cleanup function. But after
cleaned up, this mutex is automatically released. So this function call
is meaningless.

[fixed a typo in changelog by tiwai]

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
ALSA: fireworks: Remove a constant over width to which it's applied 2014-06-04T12:36:40+00:00 Takashi Sakamoto o-takashi@sakamocchi.jp 2014-06-04T06:25:35+00:00 f3479150923d164470eef7f33b0192f82de51403 The constants of enum snd_efw_grp_type is for struct snd_efw_phys_grp.type. But this member is 1 byte. Although the value is between 0x00-0xff, a constant has 0x10000. This constant is meaningless. Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp> Signed-off-by: Takashi Iwai <tiwai@suse.de> 
The constants of enum snd_efw_grp_type is for struct snd_efw_phys_grp.type.
But this member is 1 byte. Although the value is between 0x00-0xff, a constant
has 0x10000. This constant is meaningless.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
ALSA: fireworks: Improve comments about Fireworks transaction 2014-06-04T12:36:21+00:00 Takashi Sakamoto o-takashi@sakamocchi.jp 2014-06-04T06:25:34+00:00 72f784f7d0da3072ee9ad9b31b88094bc0abc2df It includes descriptions to cause misreading. Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp> Signed-off-by: Takashi Iwai <tiwai@suse.de> 
It includes descriptions to cause misreading.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
ALSA: fireworks: Use safer way to arrange ring buffer pointer 2014-06-04T12:35:40+00:00 Takashi Sakamoto o-takashi@sakamocchi.jp 2014-06-04T06:25:33+00:00 cf44a136c062098b099a44698291e50c5bfdce2e To reverse a pointer for the ring buffer, subtraction by buffer size is better than assignment to the beginning of the buffer. Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp> Signed-off-by: Takashi Iwai <tiwai@suse.de> 
To reverse a pointer for the ring buffer, subtraction by buffer
size is better than assignment to the beginning of the buffer.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
ALSA: fireworks/bebob: Shorten critical section for stream_stop_duplex() 2014-06-04T12:35:24+00:00 Takashi Sakamoto o-takashi@sakamocchi.jp 2014-06-04T06:25:32+00:00 c6e5e741c6dc8e13a47721f419e26e6ac19ecaf4 All assignment for local variables in these functions are not related to critical section. Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp> Signed-off-by: Takashi Iwai <tiwai@suse.de> 
All assignment for local variables in these functions are not related to
critical section.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
ALSA: fireworks: small leak on error path 2014-05-29T13:56:18+00:00 Dan Carpenter dan.carpenter@oracle.com 2014-05-28T16:42:46+00:00 396178370b9dc20275811dcc3b607c5af70689ba There was a typo here so we return directly instead of freeing "hwinfo". Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Reviewd-by: Takashi Sakamoto <o-takashi@sakamocchi.jp> Tested-by: Takashi Sakamoto <o-takashi@sakamocchi.jp> Signed-off-by: Takashi Iwai <tiwai@suse.de> 
There was a typo here so we return directly instead of freeing "hwinfo".

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewd-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Tested-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
ALSA: fireworks: remove some stray checks 2014-05-29T13:56:02+00:00 Dan Carpenter dan.carpenter@oracle.com 2014-05-28T16:42:02+00:00 aeebbddda7588d25dd2c1a6180f740c67f05797d We checked "err" earlier. These things seem to be left over code. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Reviewd-by: Takashi Sakamoto <o-takashi@sakamocchi.jp> Tested-by: Takashi Sakamoto <o-takashi@sakamocchi.jp> Signed-off-by: Takashi Iwai <tiwai@suse.de> 
We checked "err" earlier.  These things seem to be left over code.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewd-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Tested-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>