linux-toradex.git/sound/firewire, branch v3.18

ALSA: bebob: Uninitialized id returned by saffirepro_both_clk_src_get

2014-10-27T13:09:14+00:00

snd_bebob_stream_check_internal_clock() may get an id from
saffirepro_both_clk_src_get (via clk_src->get()) that was uninitialized.

a) make logic in saffirepro_both_clk_src_get explicit
b) test if id used in snd_bebob_stream_check_internal_clock matches array size

[fixed missing signed prefix to *_maps[] by tiwai]

Signed-off-by: Christian Vogel 
Reviewed-by: Takashi Sakamoto 
Cc: 
Signed-off-by: Takashi Iwai

ALSA: bebob: fix wrong decoding of clock information for Terratec PHASE 88 Rack FW

2014-10-27T07:39:11+00:00

Terratec PHASE 88 rack fw has two registers for source of clock, one is
for internal/external, and another is for wordclock/spdif for external.

When clock source is internal, information in another register has no meaning.
Thus it must be ignored, but current implementation decodes it. This causes
over-indexing reference to labels.

Reported-by: András Murányi 
Tested-by: András Murányi 
Signed-off-by: Takashi Sakamoto 
Acked-by: Clemens Ladisch 
Signed-off-by: Takashi Iwai

ALSA: bebob: Fix failure to detect source of clock for Terratec Phase 88

2014-10-10T15:25:30+00:00

This patch fixes a failure to open PCM device with -ENOSYS in
Terratec Phase 88.

Terratec Phase 88 has two Selector Function Blocks of AVC Audio subunit
to switch source of clock. One is to switch internal/external for the
source and another is to switch word/spdif for the external clock.

The IDs for these Selector Function Blocks are 9 and 8. But in current
implementation they're 0 and 0.

Reported-by: András Murányi 
Tested-by: András Murányi 
Cc:  # v3.16+
Signed-off-by: Takashi Sakamoto 
Signed-off-by: Takashi Iwai

ALSA: firewire-lib/dice: add arrangements of PCM pointer and interrupts for Dice quirk

2014-08-29T07:52:07+00:00

In IEC 61883-6, one data block transfers one event. In ALSA, the event equals one PCM frame,
hence one data block transfers one PCM frame. But Dice has a quirk at higher sampling rate
(176.4/192.0 kHz) that one data block transfers two PCM frames.

Commit 10550bea44a8 ("ALSA: dice/firewire-lib: Keep dualwire mode but obsolete
CIP_HI_DUALWIRE") moved some codes related to this quirk into Dice driver. But the commit
forgot to add arrangements for PCM period interrupts and DMA pointer updates. As a result, Dice
driver cannot work correctly at higher sampling rate.

This commit adds 'double_pcm_frames' parameter to amdtp structure for this quirk. When this
parameter is set, PCM period interrupts and DMA pointer updates occur at double speed than in
IEC 61883-6.

Reported-by: Daniel Robbins 
Fixes: 10550bea44a8 ("ALSA: dice/firewire-lib: Keep dualwire mode but obsolete CIP_HI_DUALWIRE")
Signed-off-by: Takashi Sakamoto 
Cc:  # 3.16
Signed-off-by: Takashi Iwai

ALSA: dice: fix wrong channel mappping at higher sampling rate

2014-08-29T07:51:45+00:00

The channel mapping is initialized by amdtp_stream_set_parameters(), however
Dice driver set it before calling this function. Furthermore, the setting is
wrong because the index is the value of array, and vice versa.

This commit moves codes for channel mapping after the function and set it correctly.

Reported-by: Daniel Robbins 
Fixes: 10550bea44a8 ("ALSA: dice/firewire-lib: Keep dualwire mode but obsolete CIP_HI_DUALWIRE")
Signed-off-by: Takashi Sakamoto 
Cc:  # 3.16
Signed-off-by: Takashi Iwai

ALSA: fireworks: fix specifiers in format strings for propper output

2014-08-05T07:15:20+00:00

Use %d for loop counter and %X for device capabilities. This is a
supplemental patch for Hans Wennborg's patch.

Signed-off-by: Takashi Sakamoto 
Signed-off-by: Takashi Iwai

ALSA: fireworks: fix %d confusingly prefixed with 0x in format strings

2014-08-04T11:17:23+00:00

Signed-off-by: Hans Wennborg 
Signed-off-by: Takashi Iwai

Merge branch 'for-next' into for-linus

2014-08-04T09:11:22+00:00

ALSA: firewire: trivial typo fixes in Kconfig

2014-07-28T08:26:42+00:00

ESI Quotafire -> QuataFire
TerraTec EWS Mic4 -> Mic8
Firewire -> FireWire

Signed-off-by: Stefan Richter 
Reviewed-by: Takashi Sakamoto 
Signed-off-by: Takashi Iwai

ALSA: bebob: Correction for return value of special_clk_ctl_put() in error

2014-07-22T15:31:28+00:00

This commit is a supplement to my previous patch.
http://mailman.alsa-project.org/pipermail/alsa-devel/2014-July/079190.html

The special_clk_ctl_put() still returns 0 in error handling case. It should
return -EINVAL.

Signed-off-by: Takashi Sakamoto 
Signed-off-by: Takashi Iwai