linux-toradex.git/sound/firewire, branch v4.0-rc2

ALSA: fireworks/bebob/dice/oxfw: make it possible to shutdown safely

2015-02-23T08:11:24+00:00

A part of these drivers, especially BeBoB driver, are programmed to wait
some events. Thus the drivers should not destroy any data in .remove()
context.

This commit moves some destructors from 'struct fw_driver.remove()' to
'struct snd_card.private_free()' to shutdown safely.

Signed-off-by: Takashi Sakamoto 
Cc:  # 3.19+
Signed-off-by: Takashi Iwai

ALSA: fireworks/bebob/dice/oxfw: allow stream destructor after releasing runtime

2015-02-23T08:11:16+00:00

Currently stream destructor in each driver has a problem to be called in
a context in which sound card object is released, because the destructors
call amdtp_stream_pcm_abort() and touch PCM runtime data.

The PCM runtime data is destroyed in application's context with
snd_pcm_close(), on the other hand PCM substream data is destroyed after
sound card object is released, in most case after all of ALSA character
devices are released. When PCM runtime is destroyed and PCM substream is
remained, amdtp_stream_pcm_abort() touches PCM runtime data and causes
Null-pointer-dereference.

This commit changes stream destructors and allows each driver to call
it after releasing runtime.

Signed-off-by: Takashi Sakamoto 
Cc:  # 3.19+
Signed-off-by: Takashi Iwai

ALSA: firewire-lib: remove reference counting

2015-02-23T08:11:08+00:00

AMDTP helper functions increment/decrement reference counter for an
instance of FireWire unit, while it's complicated for each driver to
process error state.

In previous commit, each driver has the role of reference counting. This
commit removes this role from the helper function.

Signed-off-by: Takashi Sakamoto 
Cc:  # 3.19+
Signed-off-by: Takashi Iwai

ALSA: fireworks/bebob/dice/oxfw: add reference-counting for FireWire unit

2015-02-23T08:10:38+00:00

Fireworks and Dice drivers try to touch instances of FireWire unit after
sound card object is released, while references to the unit is decremented
in .remove(). When unplugging during streaming, sound card object is
released after .remove(), thus Fireworks and Dice drivers causes GPF or
Null-pointer-dereferencing to application processes because an instance of
FireWire unit was already released.

This commit adds reference-counting for FireWire unit in drivers to allow
them to touch an instance of FireWire unit after .remove(). In most case,
any operations after .remove() may be failed safely.

Signed-off-by: Takashi Sakamoto 
Cc:  # 3.19+
Signed-off-by: Takashi Iwai

ALSA: firewire-lib: fix an unexpected byte sequence for micro sign

2015-02-23T07:46:03+00:00

The sign for microsecond (U+0085, MICRO SIGN) was encoded to '0x c2 b5'
by UTF-8 character encoding scheme. But the byte sequence was converted
to '0x c3 82 c2 b5' in a previous commit. As a result, the byte
sequence cannot represent microsecond sign in UTF-8 or ASCII. This
may confuse developers.

This commit replaces the sign to string expression with 'microseconds'
to purge superfluous troubles.

Fixes: 5c697e5b46ef("ALSA: firewire-lib: remove rx_blocks_for_midi quirk")
Signed-off-by: Takashi Sakamoto 
Signed-off-by: Takashi Iwai

ALSA: firewire-lib: limit the MIDI data rate

2015-01-16T21:51:23+00:00

Do no send MIDI bytes at the full rate at which FireWire packets happen
to be sent, but restrict them to the actual rate of a real MIDI port.
This is required by the specification, and prevents data loss when the
device's buffer overruns.

Signed-off-by: Clemens Ladisch 
Reviewed-by: Takashi Sakamoto 
Tested-by: Takashi Sakamoto 
Signed-off-by: Takashi Iwai

ALSA: firewire-lib: remove rx_blocks_for_midi quirk

2015-01-16T21:50:45+00:00

There are several devices that expect to receive MIDI data only in the
first eight data blocks of a packet.  If the driver restricts the data
rate to the allowed rate (as mandated by the specification, but not yet
implemented by this driver), this happens naturally.  Therefore, there
is no reason to ever try to use more data packets with any device.

Signed-off-by: Clemens Ladisch 
Reviewed-by: Takashi Sakamoto 
Tested-by: Takashi Sakamoto 
Signed-off-by: Takashi Iwai

ALSA: fireworks: fix an endianness bug for transaction length

2015-01-07T15:39:21+00:00

Although the 't->length' is a big-endian value, it's used without any
conversion. This means that the driver always uses 'length' parameter.

Fixes: 555e8a8f7f14("ALSA: fireworks: Add command/response functionality into hwdep interface")
Reported-by: Clemens Ladisch 
Signed-off-by: Takashi Sakamoto 
Signed-off-by: Takashi Iwai

ALSA: oxfw: some signedness bugs

2014-12-15T09:03:21+00:00

This code tends to use unsigned variables by default and it causes
signedness bugs when we use negative variables for error handling.
The "i" and "j" variables are used to iterated over small positive
values and so they should be type "int".  The "len" variable doesn't
*need* to be signed but it should be signed to make the code easier to
read and audit.

Signed-off-by: Dan Carpenter 
Reviewed-by: Takashi Sakamoto 
Signed-off-by: Takashi Iwai

ALSA: oxfw: fix detect_loud_models() return value

2014-12-14T15:04:50+00:00

This code causes a static checker warning:

	sound/firewire/oxfw/oxfw.c:46 detect_loud_models()
	warn: signedness bug returning '(-2)'

The detect_loud_models() function should return false on falure, so that
we don't try to set up the loud code for hardware that doesn't support
it.

Signed-off-by: Dan Carpenter 
Reviewed-by: Takashi Sakamoto 
Signed-off-by: Takashi Iwai