linux-toradex.git/sound/firewire, branch v4.0.2

ALSA: bebob: fix to processing in big-endian machine for sending cue

2015-04-08T16:23:10+00:00

Some M-Audio devices require to receive bootup command just after
powering on, while codes in BeBoB driver doesn't work properly in
big-endian machine because the command should be aligned by
little-endian.

This commit fixes this bug. This fix should go to stable kernel.

Cc: Takayuki Shiroma 
Signed-off-by: Takashi Sakamoto 
Cc: 
Signed-off-by: Takashi Iwai

ALSA: firewire-lib: leave unit reference counting completely

2015-03-10T14:27:19+00:00

With previous commit, this module managed to leave the counting to each
drivers, but the isochronous resources functionality still increment/decrement
the count.

This commit purge such codes to leave the responsibility to each drivers.

Fix: c6f224dc20ad ('ALSA: firewire-lib: remove reference counting')
Signed-off-by: Takashi Sakamoto 
Signed-off-by: Takashi Iwai

Revert "ALSA: dice: fix wrong offsets for Dice interface"

2015-03-10T14:26:25+00:00

This reverts commit 8cdebf71098c07168ef6335e2f1f35d85dbe3049.

The reverted commit breaks out-stream functionality of Dice driver.

Signed-off-by: Takashi Sakamoto 
Signed-off-by: Takashi Iwai

ALSA: dice: fix wrong offsets for Dice interface

2015-03-01T09:49:06+00:00

For received packet stream, the offset of 'RX_SEQ_START' locates after
the offset of 'RX_NUMBER_MIDI', although current macro and proc output
includes wrong offsets.

Fortunately, this bug doesn't affect streaming functionality because
these macro is not used.

This commit fixes these wrong macro and outputs.

Signed-off-by: Takashi Sakamoto 
Signed-off-by: Takashi Iwai

ALSA: oxfw: fix a condition and return code in start_stream()

2015-02-27T13:42:18+00:00

The amdtp_stream_wait_callback() doesn't return minus value and
the return code is not for error code.

This commit fixes with a propper condition and an error code.

Fixes: f3699e2c7745 ('ALSA: oxfw: Change the way to start stream')
Reported-by: Dan Carpenter 
Signed-off-by: Takashi Sakamoto 
Cc:  # 3.19+
Signed-off-by: Takashi Iwai

ALSA: fireworks/bebob/dice/oxfw: make it possible to shutdown safely

2015-02-23T08:11:24+00:00

A part of these drivers, especially BeBoB driver, are programmed to wait
some events. Thus the drivers should not destroy any data in .remove()
context.

This commit moves some destructors from 'struct fw_driver.remove()' to
'struct snd_card.private_free()' to shutdown safely.

Signed-off-by: Takashi Sakamoto 
Cc:  # 3.19+
Signed-off-by: Takashi Iwai

ALSA: fireworks/bebob/dice/oxfw: allow stream destructor after releasing runtime

2015-02-23T08:11:16+00:00

Currently stream destructor in each driver has a problem to be called in
a context in which sound card object is released, because the destructors
call amdtp_stream_pcm_abort() and touch PCM runtime data.

The PCM runtime data is destroyed in application's context with
snd_pcm_close(), on the other hand PCM substream data is destroyed after
sound card object is released, in most case after all of ALSA character
devices are released. When PCM runtime is destroyed and PCM substream is
remained, amdtp_stream_pcm_abort() touches PCM runtime data and causes
Null-pointer-dereference.

This commit changes stream destructors and allows each driver to call
it after releasing runtime.

Signed-off-by: Takashi Sakamoto 
Cc:  # 3.19+
Signed-off-by: Takashi Iwai

ALSA: firewire-lib: remove reference counting

2015-02-23T08:11:08+00:00

AMDTP helper functions increment/decrement reference counter for an
instance of FireWire unit, while it's complicated for each driver to
process error state.

In previous commit, each driver has the role of reference counting. This
commit removes this role from the helper function.

Signed-off-by: Takashi Sakamoto 
Cc:  # 3.19+
Signed-off-by: Takashi Iwai

ALSA: fireworks/bebob/dice/oxfw: add reference-counting for FireWire unit

2015-02-23T08:10:38+00:00

Fireworks and Dice drivers try to touch instances of FireWire unit after
sound card object is released, while references to the unit is decremented
in .remove(). When unplugging during streaming, sound card object is
released after .remove(), thus Fireworks and Dice drivers causes GPF or
Null-pointer-dereferencing to application processes because an instance of
FireWire unit was already released.

This commit adds reference-counting for FireWire unit in drivers to allow
them to touch an instance of FireWire unit after .remove(). In most case,
any operations after .remove() may be failed safely.

Signed-off-by: Takashi Sakamoto 
Cc:  # 3.19+
Signed-off-by: Takashi Iwai

ALSA: firewire-lib: fix an unexpected byte sequence for micro sign

2015-02-23T07:46:03+00:00

The sign for microsecond (U+0085, MICRO SIGN) was encoded to '0x c2 b5'
by UTF-8 character encoding scheme. But the byte sequence was converted
to '0x c3 82 c2 b5' in a previous commit. As a result, the byte
sequence cannot represent microsecond sign in UTF-8 or ASCII. This
may confuse developers.

This commit replaces the sign to string expression with 'microseconds'
to purge superfluous troubles.

Fixes: 5c697e5b46ef("ALSA: firewire-lib: remove rx_blocks_for_midi quirk")
Signed-off-by: Takashi Sakamoto 
Signed-off-by: Takashi Iwai