linux-toradex.git/sound/isa/opti9xx, branch master

ALSA: isa: Add SPDX id lines to some files

2026-02-18T07:56:47+00:00

Add SPDX-License-Identifier lines to several files where
they are missing, mostly in the sound/isa subdir.
Use GPL-2.0 as the id.

[ note: the same change applied to sound/hda/core/trace.c, too -- tiwai ]

Signed-off-by: Tim Bird 
Link: https://patch.msgid.link/20260212195905.3726149-1-tim.bird@sony.com
Signed-off-by: Takashi Iwai

ALSA: opti9xx: Use guard() for spin locks

2025-09-01T11:53:02+00:00

Clean up the code using guard() for spin locks.

Merely code refactoring, and no behavior change.

Signed-off-by: Takashi Iwai 
Link: https://patch.msgid.link/20250829145300.5460-12-tiwai@suse.de

ALSA: opti9xx: Use safer strscpy() instead of strcpy()

2025-07-11T07:53:15+00:00

Use a safer function strscpy() instead of strcpy() for copying to
arrays.

Only idiomatic code replacement, and no functional changes.

Signed-off-by: Takashi Iwai 
Link: https://patch.msgid.link/20250710100727.22653-35-tiwai@suse.de

ALSA: opti9xx: fix inconsistent indenting warning in snd_opti9xx_configure()

2025-02-27T11:26:49+00:00

Fix below inconsistent indenting smatch warning.
smatch warnings:
sound/isa/opti9xx/opti92x-ad1848.c:489 snd_opti9xx_configure()
warn: inconsistent indenting

Signed-off-by: Charles Han 
Link: https://patch.msgid.link/20250227091810.18847-1-hanchunchao@inspur.com
Signed-off-by: Takashi Iwai

ALSA: opti9xx: Use standard print API

2024-08-08T05:49:45+00:00

Use the standard print API with dev_*() instead of the old house-baked
one.  It gives better information and allows dynamically control of
debug prints.

The card pointer is stored in struct snd_opti9xx and snd_miro to be
referred for dev_*() calls.

Reviewed-by: Jaroslav Kysela 
Signed-off-by: Takashi Iwai 
Link: https://patch.msgid.link/20240807133452.9424-30-tiwai@suse.de

ALSA: isa: Use -y instead of -objs in Makefile

2024-05-08T16:17:48+00:00

*-objs suffix is reserved rather for (user-space) host programs while
usually *-y suffix is used for kernel drivers (although *-objs works
for that purpose for now).

Let's correct the old usages of *-objs in Makefiles.

Signed-off-by: Takashi Iwai 
Reviewed-by: Andy Shevchenko 
Reviewed-by: Jaroslav Kysela 
Link: https://lore.kernel.org/r/20240507135513.14919-5-tiwai@suse.de

ALSA: opti9x: Fix -Wformat-truncation warning

2023-09-15T11:21:34+00:00

The filling of card->longname can be gracefully truncated, as it's
only informative.  Use scnprintf() and suppress the superfluous
compile warning with -Wformat-truncation.

Link: https://lore.kernel.org/r/20230915082802.28684-9-tiwai@suse.de
Signed-off-by: Takashi Iwai

ALSA: opti9xx: fix missing { } around an if block

2021-07-20T15:40:12+00:00

Currently the { } braces are missing around an if block causing subsequent
code after the return to become unreachable. Fix this by adding the
missing { }.

Addresses-Coverity: ("Structurally dead code")
Fixes: 2973ee4a5b54 ("ALSA: opti9xx: Allocate resources with device-managed APIs")
Signed-off-by: Colin Ian King 
Link: https://lore.kernel.org/r/20210720153741.73230-1-colin.king@canonical.com
Signed-off-by: Takashi Iwai

ALSA: opti9xx: Allocate resources with device-managed APIs

2021-07-19T14:17:24+00:00

This patch converts the resource management in ISA als100 driver with
devres as a clean up.  Each manual resource management is converted
with the corresponding devres helper.

This should give no user-visible functional changes.

Link: https://lore.kernel.org/r/20210715075941.23332-68-tiwai@suse.de
Signed-off-by: Takashi Iwai

ALSA: opti9xx: Fix assignment in if condition

2021-06-09T15:29:44+00:00

ISA Opti9xx driver code contains lots of assignments in if condition,
which is a bad coding style that may confuse readers and occasionally
lead to bugs.

This patch is merely for coding-style fixes, no functional changes.

Link: https://lore.kernel.org/r/20210608140540.17885-9-tiwai@suse.de
Signed-off-by: Takashi Iwai