linux-toradex.git/sound/pci/echoaudio/echoaudio_dsp.c, branch v4.1.20

ALSA: echoaudio: cleanup of unnecessary messages

2014-11-05T14:35:57+00:00

commit "b5b4a41b392960010fccf1f9ccf8334d612bd450" was dereferencing
chip after it has been freed. This patch fixes that and at the same
time removes some debugging messages, which are unnecessary, as they
are just printing information about entry and exit from a function,
and which switch-case it is executing.
we can easily get from ftrace the information about the entry and exit
from a function.

Reported-by: Dan Carpenter 
Signed-off-by: Sudip Mukherjee 
Signed-off-by: Takashi Iwai

ALSA: echoaudio: remove all snd_printk

2014-11-03T13:07:25+00:00

removed all references of snd_printk with the standard dev_* macro.

[a few places degraded to dev_dbg(), too -- tiwai]

Signed-off-by: Sudip Mukherjee 
Signed-off-by: Takashi Iwai

ALSA: echoaudio: add reference of struct echoaudio

2014-11-03T13:02:33+00:00

added reference of struct echoaudio to free_firmware function.
this structure will be later used to get a reference of the card
when converting snd_printk to dev_* in the next patch of the series.

Signed-off-by: Sudip Mukherjee 
Signed-off-by: Takashi Iwai

ALSA: echoaudio: Use standard printk helpers

2014-02-26T15:45:26+00:00

Convert with dev_err() and co from snd_printk(), etc.

Signed-off-by: Takashi Iwai

ALSA: echoaudio: Remove incorrect part of assertion

2012-05-06T10:54:20+00:00

This assertion seems to imply that chip->dsp_code_to_load is a pointer.
It's actually an integer handle on the actual firmware, and 0 has no
special meaning.

The assertion prevents initialisation of a Darla20 card, but would also
affect other models. It seems it was introduced in commit dd7b254d.

ALSA sound/pci/echoaudio/echoaudio.c:2061 Echoaudio driver starting...
ALSA sound/pci/echoaudio/echoaudio.c:1969 chip=ebe4e000
ALSA sound/pci/echoaudio/echoaudio.c:2007 pci=ed568000 irq=19 subdev=0010 Init hardware...
ALSA sound/pci/echoaudio/darla20_dsp.c:36 init_hw() - Darla20
------------[ cut here ]------------
WARNING: at sound/pci/echoaudio/echoaudio_dsp.c:478 init_hw+0x1d1/0x86c [snd_darla20]()
Hardware name: Dell DM051
BUG? (!chip->dsp_code_to_load || !chip->comm_page)

Signed-off-by: Mark Hills 
Cc: 
Signed-off-by: Takashi Iwai

ALSA: Echoaudio - Add suspend support #2

2010-02-15T09:40:15+00:00

This patch adds rearranges parts of the initialization code and adds
suspend and resume callbacks.

This patch adds suspend and resume callbacks.
It also rearranges parts of the initialization code so it can be
used in both the first initialization (when the module is loaded we
also have to load default settings) and the resume callback (where
we have to restore the previous settings).

Signed-off-by: Giuliano Pochini 
Signed-off-by: Takashi Iwai

ALSA: Echoaudio - Add firmware cache #1

2010-02-15T09:36:51+00:00

Changes the way the firmware is passed through functions.

When CONFIG_PM is enabled the firmware cannot be released because the
driver will need it again to resume the card. 
With this patch the firmware is passed as an index of the struct
firmware card_fw[] in place of a pointer. That same index is then used
to locate the firmware in the firmware cache.

Signed-off-by: Giuliano Pochini 
Signed-off-by: Takashi Iwai

ALSA: echoaudio - replace uses of __constant_{endian}

2009-02-11T23:24:11+00:00

The base versions handle constant folding now.

Signed-off-by: Harvey Harrison 
Signed-off-by: Takashi Iwai

ALSA: Kill snd_assert() in sound/pci/*

2008-08-13T09:46:38+00:00

Kill snd_assert() in sound/pci/*, either removed or replaced with
if () with snd_BUG_ON().

Signed-off-by: Takashi Iwai 
Signed-off-by: Jaroslav Kysela

[ALSA] echoaudio - Add barrier() to prevent compiler optimization

2007-10-16T14:50:38+00:00

This patch adds a barrier() to prevent the compiler from
moving the read outside of the loop. It also fixes a comment.

Signed-off-by: Giuliano Pochini 
Signed-off-by: Takashi Iwai 
Signed-off-by: Jaroslav Kysela