linux-toradex.git/sound/pci/echoaudio, branch v4.10

ALSA: echoaudio: Fix improper return value in function load_asic

2016-11-29T18:59:57+00:00

When the second call to load_asic_generic() fails in function
load_asic(), "false" is returned. The real value of "false" is 0, which
indicates success in the context. As a result, the execution status and
the return value may be inconsistent. This patch fixes the bug.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188761
Signed-off-by: Pan Bian 
Signed-off-by: Takashi Iwai

Merge branch 'for-next' into for-linus

2016-07-25T15:01:14+00:00

Merged 4.8 changes.

ALSA: echoaudio: purge contradictions between dimension matrix members and total number of members

2016-07-17T08:03:06+00:00

Currently, sound device drivers for PCI cards produced by Echo Audio
support dimension parameter of element information. But the information
has contradictions to the number of members of each element. I guess that
this comes from the assumption that these sound cards are used only by
'echomixer' in userspace. But ideally, they should be used with usual ALSA
control applications.

This commit removes the contradiction. As a result, 'Monitor Mixer Volume'
and 'VMixer Volume' elements are shown in usual ALSA control applications
such as 'amixer' and 'alsamixer' in series.

Signed-off-by: Takashi Sakamoto 
Signed-off-by: Takashi Iwai

ALSA: echoaudio: Fix memory allocation

2016-06-27T20:27:47+00:00

'commpage_bak' is allocated with 'sizeof(struct echoaudio)' bytes.
We then copy 'sizeof(struct comm_page)' bytes in it.
On my system, smatch complains because one is 2960 and the other is 3072.

This would result in memory corruption or a oops.

Signed-off-by: Christophe JAILLET 
Cc: 
Signed-off-by: Takashi Iwai

ALSA: echoaudio: Use standard C definitions of true and false

2015-08-10T12:27:16+00:00

The echoaudio locally defines TRUE and FALSE.  Not only is this
redundant given that C now has a boolean type it results in lots of
warnings as other headers also define these macros, causing duplicate
definitions.  Fix this by removing the local defines and converting all
local users to use the standard C true and false instead, simply
removing the macros is less safe due to implicit inclusion of the other
definitons.

[fixed overlooked replacement of FALSE by tiwai]

Signed-off-by: Mark Brown 
Signed-off-by: Takashi Iwai

ALSA: echoaudio: read past end of array

2015-03-23T13:00:28+00:00

We need to cap "ucontrol->id.index / num_busses_in(chip)" so the we
don't read beyond the end of the array.

I also adding a check on "in" and changing the type in
snd_echo_mixer_put() from short to unsigned int. Those changes are done
for symmetry and are cosmetic.

Signed-off-by: Dan Carpenter 
Signed-off-by: Takashi Iwai

ALSA: Include linux/io.h instead of asm/io.h

2015-01-28T15:49:33+00:00

Nowadays it's recommended.  Replace all in a shot.

Signed-off-by: Takashi Iwai

ALSA: echoaudio: Use setup_timer() and mod_timer()

2015-01-19T10:33:20+00:00

No functional change, refactoring with the standard helpers.

Signed-off-by: Takashi Iwai

Merge branch 'topic/pci-cleanup' into for-next

2015-01-11T10:26:48+00:00

ALSA: echoaudio: Simplify PM callbacks

2015-01-09T15:24:20+00:00

This is a similar cleanup like the commit [3db084fd0af5: ALSA: fm801:
PCI core handles power state for us].

Since pci_set_power_state(), pci_save_state() and pci_restore_state()
are already done in the PCI core side, so we don't need to it doubly.

Also, pci_enable_device(), pci_disable_device() and pci_set_master()
calls in PM callbacks are superfluous nowadays, too, so get rid of
them as well.

Signed-off-by: Takashi Iwai