linux-toradex.git/sound/pci/nm256, branch v3.19-rc1

PCI: Remove DEFINE_PCI_DEVICE_TABLE macro use

2014-08-12T18:15:14+00:00

We should prefer `struct pci_device_id` over `DEFINE_PCI_DEVICE_TABLE` to
meet kernel coding style guidelines.  This issue was reported by checkpatch.

A simplified version of the semantic patch that makes this change is as
follows (http://coccinelle.lip6.fr/):

// 

@@
identifier i;
declarer name DEFINE_PCI_DEVICE_TABLE;
initializer z;
@@

- DEFINE_PCI_DEVICE_TABLE(i)
+ const struct pci_device_id i[]
= z;

// 

[bhelgaas: add semantic patch]
Signed-off-by: Benoit Taine 
Signed-off-by: Bjorn Helgaas

ALSA: nm256: Use standard printk helpers

2014-02-26T15:45:29+00:00

Convert with dev_err() and co from snd_printk(), etc.

Signed-off-by: Takashi Iwai

ALSA: pci: Convert to snd_card_new() with a device pointer

2014-02-12T10:17:52+00:00

Also remove superfluous snd_card_set_dev() calls.

Signed-off-by: Takashi Iwai

ALSA: PCI: Remove superfluous pci_set_drvdata(pci, NULL) at remove

2013-05-29T10:37:32+00:00

As drvdata is cleared to NULL at probe failure or at removal by the
driver core, we don't have to call pci_set_drvdata(pci, NULL) any
longer in each driver.

The only remaining pci_set_drvdata(NULL) is in azx_firmware_cb() in
hda_intel.c.  Since this function itself releases the card instance,
we need to clear drvdata here as well, so that it won't be released
doubly in the remove callback.

Signed-off-by: Takashi Iwai

ALSA: Make snd_printd() and snd_printdd() inline

2013-01-25T17:32:14+00:00

Because currently snd_printd() and snd_printdd() macros are expanded
to empty when CONFIG_SND_DEBUG=n, a compile warning like below
appears sometimes, and we had to covert it by ugly ifdefs:
  sound/pci/hda/patch_sigmatel.c: In function ‘stac92hd71bxx_fixup_hp’:
  sound/pci/hda/patch_sigmatel.c:2434:24: warning: unused variable ‘spec’ [-Wunused-variable]

For "fixing" these issues better, this patch replaces snd_printd() and
snd_printdd() definitions with empty inline functions instead of
macros.  This should have the same effect but shut up warnings like
above.

But since we had already put ifdefs, changing to inline functions
would trigger compile errors.  So, such ifdefs is removed in this
patch.

In addition, snd_pci_quirk name field is defined only when
CONFIG_SND_DEBUG_VERBOSE is set, and the reference to it in
snd_printdd() argument triggers the build errors, too.  For avoiding
these errors, introduce a new macro snd_pci_quirk_name() that is
defined no matter how the debug option is set.

Reported-by: Stratos Karafotis 
Signed-off-by: Takashi Iwai

ALSA: pci: remove __dev* attributes

2012-12-07T06:20:55+00:00

CONFIG_HOTPLUG is going away as an option.  As result the __dev*
markings will be going away.

Remove use of __devinit, __devexit_p, __devinitdata, __devinitconst,
and __devexit.

Signed-off-by: Bill Pemberton 
Signed-off-by: Takashi Iwai

ALSA: PCI: Replace CONFIG_PM with CONFIG_PM_SLEEP

2012-08-14T16:12:04+00:00

Otherwise we may get compile warnings due to unused functions.

Signed-off-by: Takashi Iwai

ALSA: Convert to new pm_ops for PCI drivers

2012-07-03T06:23:03+00:00

Straightforward conversion to the new pm_ops from the legacy
suspend/resume ops.

Since we change vx222, vx_core and vxpocket have to be converted,
too.

Signed-off-by: Takashi Iwai

ALSA: pci: clean up using module_pci_driver()

2012-04-24T10:25:00+00:00

Signed-off-by: Takashi Iwai

ALSA: module_param: make bool parameters really bool

2011-12-19T09:34:41+00:00

module_param(bool) used to counter-intuitively take an int.  In
fddd5201 (mid-2009) we allowed bool or int/unsigned int using a messy
trick.

It's time to remove the int/unsigned int option.  For this version
it'll simply give a warning, but it'll break next kernel version.

Signed-off-by: Rusty Russell 
Signed-off-by: Takashi Iwai