linux-toradex.git/sound/pcmcia/vx, branch master

ALSA: vxpocket: Fix resource leak in vxpocket_probe error path

2025-12-15T08:16:54+00:00

When vxpocket_config() fails, vxpocket_probe() returns the error code
directly without freeing the sound card resources allocated by
snd_card_new(), which leads to a memory leak.

Add proper error handling to free the sound card and clear the
allocation bit when vxpocket_config() fails.

Fixes: 15b99ac17295 ("[PATCH] pcmcia: add return value to _config() functions")
Signed-off-by: Haotian Zhang 
Link: https://patch.msgid.link/20251215042652.695-1-vulab@iscas.ac.cn
Signed-off-by: Takashi Iwai

ALSA: vxpocket: Use guard() for mutex locks

2025-09-01T11:54:27+00:00

Replace the manual mutex lock/unlock pairs with guard() for code
simplification.

Only code refactoring, and no behavior change.

Signed-off-by: Takashi Iwai 
Link: https://patch.msgid.link/20250829151335.7342-12-tiwai@suse.de

ALSA: vxpocket: Use safer strscpy() instead of strcpy()

2025-07-11T07:53:35+00:00

Use a safer function strscpy() instead of strcpy() for copying to
arrays.

Only idiomatic code replacement, and no functional changes.

Signed-off-by: Takashi Iwai 
Link: https://patch.msgid.link/20250710100727.22653-90-tiwai@suse.de

ALSA: vxpocket: Fix a typo at conversion to dev_*()

2024-08-08T18:23:41+00:00

There was a typo in the previous conversion to dev_*() that caused a
build error.  Fix it.

Fixes: 2acbb5e57230 ("ALSA: vxpocket: Use standard print API")
Reported-by: kernel test robot 
Closes: https://lore.kernel.org/oe-kbuild-all/202408090110.t0mWbTyh-lkp@intel.com/
Link: https://patch.msgid.link/20240808182308.28418-1-tiwai@suse.de
Signed-off-by: Takashi Iwai

ALSA: vxpocket: Drop no longer existent chip->dev assignment

2024-08-08T16:29:34+00:00

The recent cleanup change for vx_core overlooked the code in vxpocket
pcmcia driver.  Kill the superfluous line as well.

Fixes: b426b3ba9f6f ("ALSA: vx_core: Drop unused dev field")
Reported-by: kernel test robot 
Closes: https://lore.kernel.org/oe-kbuild-all/202408090016.kW0TA6fc-lkp@intel.com/
Link: https://patch.msgid.link/20240808162902.20082-1-tiwai@suse.de
Signed-off-by: Takashi Iwai

ALSA: vxpocket: Use standard print API

2024-08-08T05:49:47+00:00

Use the standard print API with dev_*() instead of the old house-baked
one.  It gives better information and allows dynamically control of
debug prints.

Reviewed-by: Jaroslav Kysela 
Signed-off-by: Takashi Iwai 
Link: https://patch.msgid.link/20240807133452.9424-48-tiwai@suse.de

ALSA: misc: Use -y instead of -objs in Makefile

2024-05-08T16:18:13+00:00

*-objs suffix is reserved rather for (user-space) host programs while
usually *-y suffix is used for kernel drivers (although *-objs works
for that purpose for now).

Let's correct the old usages of *-objs in Makefiles.

Signed-off-by: Takashi Iwai 
Reviewed-by: Andy Shevchenko 
Reviewed-by: Jaroslav Kysela 
Link: https://lore.kernel.org/r/20240507135513.14919-10-tiwai@suse.de

ALSA: vx: Manage vx_core object with devres

2021-07-19T14:17:09+00:00

The firmware data are also released automatically.

Link: https://lore.kernel.org/r/20210715075941.23332-50-tiwai@suse.de
Signed-off-by: Takashi Iwai

ALSA: pcmcia: Fix assignment in if condition

2021-06-09T15:30:28+00:00

PCMCIA VX222 and PDAudioCF drivers contain a few assignments in if
condition, which is a bad coding style that may confuse readers and
occasionally lead to bugs.

This patch is merely for coding-style fixes, no functional changes.

Link: https://lore.kernel.org/r/20210608140540.17885-58-tiwai@suse.de
Signed-off-by: Takashi Iwai

module: remove never implemented MODULE_SUPPORTED_DEVICE

2021-03-17T20:16:18+00:00

MODULE_SUPPORTED_DEVICE was added in pre-git era and never was
implemented. We can safely remove it, because the kernel has grown
to have many more reliable mechanisms to determine if device is
supported or not.

Signed-off-by: Leon Romanovsky 
Signed-off-by: Linus Torvalds