linux-toradex.git/sound/soc/fsl, branch v5.0

ASoC: imx-audmux: change snprintf to scnprintf for possible overflow

2019-01-15T19:06:08+00:00

Change snprintf to scnprintf. There are generally two cases where using
snprintf causes problems.

1) Uses of size += snprintf(buf, SIZE - size, fmt, ...)
In this case, if snprintf would have written more characters than what the
buffer size (SIZE) is, then size will end up larger than SIZE. In later
uses of snprintf, SIZE - size will result in a negative number, leading
to problems. Note that size might already be too large by using
size = snprintf before the code reaches a case of size += snprintf.

2) If size is ultimately used as a length parameter for a copy back to user
space, then it will potentially allow for a buffer overflow and information
disclosure when size is greater than SIZE. When the size is used to index
the buffer directly, we can have memory corruption. This also means when
size = snprintf... is used, it may also cause problems since size may become
large.  Copying to userspace is mitigated by the HARDENED_USERCOPY kernel
configuration.

The solution to these issues is to use scnprintf which returns the number of
characters actually written to the buffer, so the size variable will never
exceed SIZE.

Signed-off-by: Silvio Cesare 
Cc: Timur Tabi 
Cc: Nicolin Chen 
Cc: Mark Brown 
Cc: Xiubo Li 
Cc: Fabio Estevam 
Cc: Dan Carpenter 
Cc: Kees Cook 
Cc: Will Deacon 
Cc: Greg KH 
Signed-off-by: Willy Tarreau 
Acked-by: Nicolin Chen 
Reviewed-by: Kees Cook 
Signed-off-by: Mark Brown

ASoC: fsl: Fix SND_SOC_EUKREA_TLV320 build error on i.MX8M

2018-12-13T11:01:51+00:00

eukrea-tlv320.c machine driver runs on non-DT platforms
and include  header file in order to be able
to use some machine_is_eukrea_xxx() macros.

Building it for ARM64 causes the following build error:

sound/soc/fsl/eukrea-tlv320.c:28:10: fatal error: asm/mach-types.h: No such file or directory

Avoid this error by not allowing to build the SND_SOC_EUKREA_TLV320
driver when ARM64 is selected.

This is needed in preparation for the i.MX8M support.

Reported-by: kbuild test robot 
Signed-off-by: Fabio Estevam 
Acked-by: Shawn Guo 
Signed-off-by: Mark Brown

ASoC: Use of_node_name_eq for node name comparisons

2018-12-06T12:56:39+00:00

Convert string compares of DT node names to use of_node_name_eq helper
instead. This removes direct access to the node name pointer.

For the FSL ASoC card, the full node names appear to be "ssi", "esai",
and "sai", so there's not any reason to use strstr and of_node_name_eq
can be used instead.

Cc: Timur Tabi 
Cc: Nicolin Chen 
Cc: Xiubo Li 
Cc: Fabio Estevam 
Cc: Liam Girdwood 
Cc: Mark Brown 
Cc: Jaroslav Kysela 
Cc: Takashi Iwai 
Cc: alsa-devel@alsa-project.org
Cc: linuxppc-dev@lists.ozlabs.org
Signed-off-by: Rob Herring 
Signed-off-by: Mark Brown

ASoC: fsl_ssi: Change to use DEFINE_SHOW_ATTRIBUTE macro

2018-11-07T14:59:37+00:00

Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.

Signed-off-by: Yangtao Li 
Signed-off-by: Mark Brown

ASoC: add for_each_dpcm_be() macro

2018-09-20T17:31:20+00:00

To be more readable code, this patch adds
new for_each_dpcm_be() macro, and replace existing code to it.

Signed-off-by: Kuninori Morimoto 
Signed-off-by: Mark Brown

ASoC: add for_each_card_prelinks() macro

2018-09-20T17:18:34+00:00

To be more readable code, this patch adds
new for_each_card_prelinks() macro, and replace existing code to it.

Signed-off-by: Kuninori Morimoto 
Signed-off-by: Mark Brown

ASoC: Convert to using %pOFn instead of device_node.name

2018-08-28T18:07:00+00:00

In preparation to remove the node name pointer from struct device_node,
convert printf users to use the %pOFn format specifier.

Signed-off-by: Rob Herring 
Signed-off-by: Mark Brown

ASoC: fsl_esai: Mark expected switch fall-through

2018-08-03T16:59:21+00:00

In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Addresses-Coverity-ID: 1222121 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva 
Signed-off-by: Mark Brown

ASoC: fsl: Use snd_mask_set_format()

2018-07-26T16:09:07+00:00

Use the new helper function snd_mask_set_format() for avoiding the
ugly cast with __force prefix.

Signed-off-by: Takashi Iwai 
Signed-off-by: Mark Brown

ASoC: imx-sgtl5000: Switch to SPDX identifier

2018-07-24T15:59:07+00:00

Adopt the SPDX license identifier headers to ease license compliance
management.

Signed-off-by: Fabio Estevam 
Signed-off-by: Mark Brown