linux-toradex.git/tools/bootconfig, branch v6.17-rc1

bootconfig: Fix unaligned access when building footer

2025-07-24T13:16:48+00:00

Currently we add padding between the bootconfig text and footer to
ensure that the footer is aligned within the initramfs image.
However, because only the bootconfig data is held in memory, not the
full initramfs image, the footer may not be naturally aligned in
memory.

This can result in an alignment fault (SIGBUS) when writing the footer
on some architectures, such as sparc.

Build the footer in a struct on the stack before adding it to the
buffer.

References: https://buildd.debian.org/status/fetch.php?pkg=linux&arch=sparc64&ver=6.16%7Erc7-1%7Eexp1&stamp=1753209801&raw=0
Link: https://lore.kernel.org/all/aIC-NTw-cdm9ZGFw@decadent.org.uk/

Signed-off-by: Ben Hutchings 
Signed-off-by: Masami Hiramatsu (Google)

tools/bootconfig: scripts/ftrace.sh was missing the shebang line, so added it

2025-07-23T15:23:39+00:00

This file was missing the shebang line, so added it.

Link: https://lore.kernel.org/all/20250722225351.8811-1-unixbhaskar@gmail.com/

[Masami: changed title. ]

Signed-off-by: Bhaskar Chowdhury 
Signed-off-by: Masami Hiramatsu (Google)

tools/bootconfig: Cleanup bootconfig footer size calculations

2025-07-14T02:56:11+00:00

There are many same pattern of 8 + BOOTCONFIG_MAGIC_LEN for calculating
the size of bootconfig footer. Use BOOTCONFIG_FOOTER_SIZE macro to
clean up those magic numbers.

Link: https://lore.kernel.org/all/175211425693.2591046.16029516706923643510.stgit@mhiramat.tok.corp.google.com/

Signed-off-by: Masami Hiramatsu (Google)

tools/bootconfig: Replace some echo with printf for more portability

2025-07-14T02:55:58+00:00

Since echo is not portable, use printf instead. This fixes a wrong
test result formatting in some environment. (showing "\t\t[OK]")
Also this uses printf command for generating test data instead of
echo.

Link: https://lore.kernel.org/all/175211424942.2591046.5439447789303314213.stgit@mhiramat.tok.corp.google.com/

Signed-off-by: Masami Hiramatsu (Google)

tools/bootconfig: Improve portability

2025-07-14T02:55:42+00:00

Since 'stat' command and 'truncate' command are GNU extension,
use 'wc' and 'dd' commands instead.

Link: https://lore.kernel.org/all/175211424184.2591046.3523297993175066026.stgit@mhiramat.tok.corp.google.com/

Signed-off-by: Masami Hiramatsu (Google)

tools: bootconfig: Regex enclosed with quotes to make syntax highlight proper

2025-07-14T02:55:17+00:00

As suggested, changed the square brackets escaping to quote the whole Regex
class.

Link: https://lore.kernel.org/all/20250709030141.27483-1-unixbhaskar@gmail.com/

Signed-off-by: Bhaskar Chowdhury 
Signed-off-by: Masami Hiramatsu (Google)

tools/bootconfig: specify LDFLAGS as an argument to CC

2025-05-16T02:22:54+00:00

Explicitly specify LDFLAGS as an argument to CC so that this can be
overridden by the user.

Link: https://lore.kernel.org/all/20250328183858.1417835-3-bmasney@redhat.com/

Signed-off-by: Brian Masney 
Signed-off-by: Masami Hiramatsu (Google)

tools/bootconfig: allow overriding CFLAGS assignment

2025-05-16T02:22:40+00:00

Allow overriding the CFLAGS assignment so that the user can pass in
an outside value.

Link: https://lore.kernel.org/all/20250328183858.1417835-2-bmasney@redhat.com/

Signed-off-by: Brian Masney 
Signed-off-by: Masami Hiramatsu (Google)

tools/bootconfig: Fix the wrong format specifier

2025-01-28T14:27:01+00:00

Use '%u' instead of '%d' for unsigned int.

Link: https://lore.kernel.org/all/20241105011048.201629-1-luoyifan@cmss.chinamobile.com/

Fixes: 973780011106 ("tools/bootconfig: Suppress non-error messages")
Signed-off-by: Luo Yifan 
Signed-off-by: Masami Hiramatsu (Google)

bootconfig: Fix testcase to increase max node

2023-03-21T16:00:28+00:00

Since commit 6c40624930c5 ("bootconfig: Increase max nodes of bootconfig
from 1024 to 8192 for DCC support") increased the max number of bootconfig
node to 8192, the bootconfig testcase of the max number of nodes fails.
To fix this issue, we can not simply increase the number in the test script
because the test bootconfig file becomes too big (>32KB). To fix that, we
can use a combination of three alphabets (26^3 = 17576). But with that,
we can not express the 8193 (just one exceed from the limitation) because
it also exceeds the max size of bootconfig. So, the first 26 nodes will just
use one alphabet.

With this fix, test-bootconfig.sh passes all tests.

Link: https://lore.kernel.org/all/167888844790.791176.670805252426835131.stgit@devnote2/

Reported-by: Heinz Wiesinger 
Link: https://lore.kernel.org/all/2463802.XAFRqVoOGU@amaterasu.liwjatan.org
Fixes: 6c40624930c5 ("bootconfig: Increase max nodes of bootconfig from 1024 to 8192 for DCC support")
Signed-off-by: Masami Hiramatsu (Google) 
Reviewed-by: Steven Rostedt (Google)