linux-toradex.git/tools/bpf/bpftool/map_perf_ring.c, branch v6.3

bpftool: Fix error message of strerror

2022-09-30T22:40:46+00:00

strerror() expects a positive errno, however variable err will never be
positive when an error occurs. This causes bpftool to output too many
"unknown error", even a simple "file not exist" error can not get an
accurate message.

This patch fixed all "strerror(err)" patterns in bpftool.
Specially in btf.c#L823, hashmap__append() is an internal function of
libbpf and will not change errno, so there's a little difference.
Some libbpf_get_error() calls are kept for return values.

Changes since v1: https://lore.kernel.org/bpf/SY4P282MB1084B61CD8671DFA395AA8579D539@SY4P282MB1084.AUSP282.PROD.OUTLOOK.COM/
Check directly for NULL values instead of calling libbpf_get_error().

Signed-off-by: Tianyi Liu 
Signed-off-by: Andrii Nakryiko 
Reviewed-by: Quentin Monnet 
Link: https://lore.kernel.org/bpf/SY4P282MB1084AD9CD84A920F08DF83E29D549@SY4P282MB1084.AUSP282.PROD.OUTLOOK.COM

bpftool: Remove unused struct event_ring_info

2022-09-30T21:09:05+00:00

After commit 9b190f185d2f ("tools/bpftool: switch map event_pipe to
libbpf's perf_buffer"), struct event_ring_info is not used any more and
can be removed as well.

Signed-off-by: Yuan Can 
Signed-off-by: Andrii Nakryiko 
Link: https://lore.kernel.org/bpf/20220928090440.79637-3-yuancan@huawei.com

bpftool: Update btf_dump__new() and perf_buffer__new_raw() calls

2021-11-12T00:54:06+00:00

Use v1.0-compatible variants of btf_dump and perf_buffer "constructors".
This is also a demonstration of reusing struct perf_buffer_raw_opts as
OPTS-style option struct for new perf_buffer__new_raw() API.

Signed-off-by: Andrii Nakryiko 
Signed-off-by: Alexei Starovoitov 
Link: https://lore.kernel.org/bpf/20211111053624.190580-10-andrii@kernel.org

bpftool: Remove useless #include to from map_perf_ring.c

2021-10-20T17:47:39+00:00

The header is no longer needed since the event_pipe implementation
was updated to rely on libbpf's perf_buffer. This makes bpftool free of
dependencies to perf files, and we can update the Makefile accordingly.

Fixes: 9b190f185d2f ("tools/bpftool: switch map event_pipe to libbpf's perf_buffer")
Signed-off-by: Quentin Monnet 
Signed-off-by: Andrii Nakryiko 
Link: https://lore.kernel.org/bpf/20211020094826.16046-1-quentin@isovalent.com

tools, bpftool: Poison and replace kernel integer typedefs

2020-05-11T19:20:46+00:00

Replace the use of kernel-only integer typedefs (u8, u32, etc.) by their
user space counterpart (__u8, __u32, etc.).

Similarly to what libbpf does, poison the typedefs to avoid introducing
them again in the future.

Signed-off-by: Quentin Monnet 
Signed-off-by: Daniel Borkmann 
Link: https://lore.kernel.org/bpf/20200511161536.29853-2-quentin@isovalent.com

bpftool: Use consistent include paths for libbpf

2020-01-21T00:37:45+00:00

Fix bpftool to include libbpf header files with the bpf/ prefix, to be
consistent with external users of the library. Also ensure that all
includes of exported libbpf header files (those that are exported on 'make
install' of the library) use bracketed includes instead of quoted.

To make sure no new files are introduced that doesn't include the bpf/
prefix in its include, remove tools/lib/bpf from the include path entirely,
and use tools/lib instead.

Fixes: 6910d7d3867a ("selftests/bpf: Ensure bpf_helper_defs.h are taken from selftests dir")
Signed-off-by: Toke Høiland-Jørgensen 
Signed-off-by: Alexei Starovoitov 
Acked-by: Andrii Nakryiko 
Link: https://lore.kernel.org/bpf/157952560684.1683545.4765181397974997027.stgit@toke.dk

tools: bpftool: fix arguments for p_err() in do_event_pipe()

2019-08-16T05:06:46+00:00

The last argument passed to some calls to the p_err() functions is not
correct, it should be "*argv" instead of "**argv". This may lead to a
segmentation fault error if CPU IDs or indices from the command line
cannot be parsed correctly. Let's fix this.

Fixes: f412eed9dfde ("tools: bpftool: add simple perf event output reader")
Signed-off-by: Quentin Monnet 
Reviewed-by: Jakub Kicinski 
Signed-off-by: Alexei Starovoitov

tools/bpftool: switch map event_pipe to libbpf's perf_buffer

2019-07-08T13:35:43+00:00

Switch event_pipe implementation to rely on new libbpf perf buffer API
(it's raw low-level variant).

Signed-off-by: Andrii Nakryiko 
Acked-by: Jakub Kicinski 
Acked-by: Yonghong Song 
Signed-off-by: Daniel Borkmann

tools: bpftool: dual license all files

2018-12-13T11:08:44+00:00

Currently bpftool contains a mix of GPL-only and GPL or BSD2
licensed files.  Make sure all files are dual licensed under
GPLv2 and BSD-2-Clause.

Signed-off-by: Jakub Kicinski 
Acked-by: Roman Gushchin 
Acked-by: YueHaibing 
Acked-by: Yonghong Song 
Acked-by: Stanislav Fomichev 
Acked-by: Sean Young 
Acked-by: Jiri Benc 
Acked-by: David Calavera 
Acked-by: Andrey Ignatov 
Acked-by: Joe Stringer 
Acked-by: David Ahern 
Acked-by: Alexei Starovoitov 
Acked-by: Petar Penkov 
Acked-by: Sandipan Das 
Acked-by: Prashant Bhole 
Acked-by: Stephen Hemminger 
Acked-by: John Fastabend 
Acked-by: Taeung Song 
Acked-by: Jiri Olsa 
Acked-by: Daniel Borkmann 
CC: okash.khawaja@gmail.com
Signed-off-by: Daniel Borkmann

bpf, libbpf: simplify and cleanup perf ring buffer walk

2018-10-21T06:13:32+00:00

Simplify bpf_perf_event_read_simple() a bit and fix up some minor
things along the way: the return code in the header is not of type
int but enum bpf_perf_event_ret instead. Once callback indicated
to break the loop walking event data, it also needs to be consumed
in data_tail since it has been processed already.

Moreover, bpf_perf_event_print_t callback should avoid void * as
we actually get a pointer to struct perf_event_header and thus
applications can make use of container_of() to have type checks.
The walk also doesn't have to use modulo op since the ring size is
required to be power of two.

Signed-off-by: Daniel Borkmann 
Signed-off-by: Alexei Starovoitov