linux-toradex.git/tools/perf/builtin-lock.c, branch v3.2.33

perf lock: Dropping unsupported ':r' modifier

2011-08-08T12:41:35+00:00

Looks to me like the :r modifier is not supported anymore, so remove it
from the list of events. Without this fix 'perf lock record' doesn't
work.

Cc: Ingo Molnar 
Cc: Paul Mackerras 
Cc: Zhu Yanhai 
Cc: Peter Zijlstra 
Link: http://lkml.kernel.org/r/1312035232-9534-1-git-send-email-gaoyang.zyh@taobao.com
Signed-off-by: Zhu Yanhai 
Signed-off-by: Arnaldo Carvalho de Melo

perf session: Pass evsel in event_ops->sample()

2011-03-23T22:28:58+00:00

Resolving the sample->id to an evsel since the most advanced tools,
report and annotate, and the others will too when they evolve to
properly support multi-event perf.data files.

Good also because it does an extra validation, checking that the ID is
valid when present. When that is not the case, the overhead is just a
branch + function call (perf_evlist__id2evsel).

Cc: Frederic Weisbecker 
Cc: Ingo Molnar 
Cc: Mike Galbraith 
Cc: Paul Mackerras 
Cc: Peter Zijlstra 
Cc: Stephane Eranian 
Cc: Tom Zanussi 
LKML-Reference: 
Signed-off-by: Arnaldo Carvalho de Melo

perf lock: Fix sorting by wait_min

2011-03-16T12:05:58+00:00

If lock was uncontended, wait_time_min == ULLONG_MAX, so we need to
handle this case differently to show high wait times first

Acked-by: Hitoshi Mitake 
Cc: Hitoshi Mitake 
Cc: Ingo Molnar 
Cc: Paul Mackerras 
Cc: Peter Zijlstra 
LKML-Reference: <20110222174715.GC9687@joi.lan>
Signed-off-by: Marcin Slusarz 
Signed-off-by: Arnaldo Carvalho de Melo

perf lock: Document valid sort keys

2011-02-23T10:29:33+00:00

Cc: Ingo Molnar 
Cc: Paul Mackerras 
Cc: Peter Zijlstra 
LKML-Reference: <20110222205312.GA18474@joi.lan>
Signed-off-by: Marcin Slusarz 
Signed-off-by: Arnaldo Carvalho de Melo

perf tools: Kill event_t typedef, use 'union perf_event' instead

2011-01-29T18:25:37+00:00

And move the event_t methods to the perf_event__ too.

No code changes, just namespace consistency.

Cc: Frederic Weisbecker 
Cc: Ingo Molnar 
Cc: Mike Galbraith 
Cc: Paul Mackerras 
Cc: Peter Zijlstra 
Cc: Stephane Eranian 
Cc: Tom Zanussi 
LKML-Reference: 
Signed-off-by: Arnaldo Carvalho de Melo

perf tools: Rename 'struct sample_data' to 'struct perf_sample'

2011-01-29T18:25:20+00:00

Making the namespace more uniform.

Cc: Frederic Weisbecker 
Cc: Ingo Molnar 
Cc: Mike Galbraith 
Cc: Paul Mackerras 
Cc: Peter Zijlstra 
Cc: Stephane Eranian 
Cc: Tom Zanussi 
LKML-Reference: 
Signed-off-by: Arnaldo Carvalho de Melo

perf tools: Fix 64 bit integer format strings

2011-01-23T01:41:57+00:00

Using %L[uxd] has issues in some architectures, like on ppc64.  Fix it
by making our 64 bit integers typedefs of stdint.h types and using
PRI[ux]64 like, for instance, git does.

Reported by Denis Kirjanov that provided a patch for one case, I went
and changed all cases.

Reported-by: Denis Kirjanov 
Tested-by: Denis Kirjanov 
LKML-Reference: <20110120093246.GA8031@hera.kernel.org>
Cc: Denis Kirjanov 
Cc: Frederic Weisbecker 
Cc: Ingo Molnar 
Cc: Mike Galbraith 
Cc: Paul Mackerras 
Cc: Peter Zijlstra 
Cc: Pingtian Han 
Cc: Stephane Eranian 
Cc: Tom Zanussi 
Signed-off-by: Arnaldo Carvalho de Melo

perf session: Fallback to unordered processing if no sample_id_all

2010-12-21T22:17:51+00:00

If we are running the new perf on an old kernel without support for
sample_id_all, we should fall back to the old unordered processing of
events. If we didn't than we would *always* process events without
timestamps out of order, whether or not we hit a reordering race. In
other words, instead of there being a chance of not attributing samples
correctly, we would guarantee that samples would not be attributed.

While processing all events without timestamps before events with
timestamps may seem like an intuitive solution, it falls down as
PERF_RECORD_EXIT events would also be processed before any samples.
Even with a workaround for that case, samples before/after an exec would
not be attributed correctly.

This patch allows commands to indicate whether they need to fall back to
unordered processing, so that commands that do not care about timestamps
on every event will not be affected. If we do fallback, this will print
out a warning if report -D was invoked.

This patch adds the test in perf_session__new so that we only need to
test once per session. Commands that do not use an event_ops (such as
record and top) can simply pass NULL in it's place.

Acked-by: Thomas Gleixner 
Cc: Frederic Weisbecker 
Cc: Ingo Molnar 
Cc: Peter Zijlstra 
Cc: Thomas Gleixner 
LKML-Reference: <1291951882-sup-6069@au1.ibm.com>
Signed-off-by: Ian Munsie 
Signed-off-by: Arnaldo Carvalho de Melo

perf tools: Catch a few uncheck calloc/malloc's

2010-12-06T14:52:35+00:00

There were a few stray calloc()'s and malloc()'s which were not having
their return values checked for success.

As the calling code either already coped with failure or didn't actually
care we just return -ENOMEM at that point.

Cc: Ingo Molnar 
Cc: Paul Mackerras 
Cc: Peter Zijlstra 
Signed-off-by: Chris Samuel 
LKML-Reference: <4CDDF95A.1050400@csamuel.org>
Signed-off-by: Arnaldo Carvalho de Melo

perf session: Parse sample earlier

2010-12-05T01:05:19+00:00

At perf_session__process_event, so that we reduce the number of lines in eache
tool sample processing routine that now receives a sample_data pointer already
parsed.

This will also be useful in the next patch, where we'll allow sample the
identity fields in MMAP, FORK, EXIT, etc, when it will be possible to see (cpu,
timestamp) just after before every event.

Also validate callchains in perf_session__process_event, i.e. as early as
possible, and keep a counter of the number of events discarded due to invalid
callchains, warning the user about it if it happens.

There is an assumption that was kept that all events have the same sample_type,
that will be dealt with in the future, when this preexisting limitation will be
removed.

Tested-by: Thomas Gleixner 
Reviewed-by: Thomas Gleixner 
Acked-by: Ian Munsie 
Acked-by: Thomas Gleixner 
Cc: Frédéric Weisbecker 
Cc: Ian Munsie 
Cc: Mike Galbraith 
Cc: Peter Zijlstra 
Cc: Paul Mackerras 
Cc: Stephane Eranian 
LKML-Reference: <1291318772-30880-4-git-send-email-acme@infradead.org>
Signed-off-by: Arnaldo Carvalho de Melo