linux-toradex.git/tools/perf/tests/perf-record.c, branch v6.3

perf tests: Add missing event.h include

2022-10-31T14:07:08+00:00

It uses things like perf_event__name() but were not including event.h,
where its prototype lives, fix it.

Signed-off-by: Arnaldo Carvalho de Melo

perf tools: Move 'struct perf_sample' to a separate header file to disentangle headers

2022-10-31T14:06:41+00:00

Some places were including event.h just to get 'struct perf_sample',
move it to a separate place so that we speed up a bit the build.

Signed-off-by: Arnaldo Carvalho de Melo

perf tests: Avoid pthread.h inclusion

2022-10-04T11:55:19+00:00

pthread.h is being included for the side-effect of getting sched.h and
macros like CPU_CLR. Switch to directly using sched.h, or if that is
already present, just remove the pthread.h inclusion entirely.

Signed-off-by: Ian Rogers 
Reviewed-by: Adrian Hunter 
Acked-by: Namhyung Kim 
Cc: Alexander Shishkin 
Cc: Alexandre Truong 
Cc: Alexey Bayduraev 
Cc: Andi Kleen 
Cc: Andres Freund 
Cc: Andrii Nakryiko 
Cc: André Almeida 
Cc: Athira Jajeev 
Cc: Christophe JAILLET 
Cc: Colin Ian King 
Cc: Dario Petrillo 
Cc: Darren Hart 
Cc: Dave Marchevsky 
Cc: Davidlohr Bueso 
Cc: Fangrui Song 
Cc: Hewenliang 
Cc: Ingo Molnar 
Cc: James Clark 
Cc: Jason Wang 
Cc: Jiri Olsa 
Cc: Kajol Jain 
Cc: Kim Phillips 
Cc: Leo Yan 
Cc: Mark Rutland 
Cc: Martin Liška 
Cc: Masami Hiramatsu 
Cc: Nathan Chancellor 
Cc: Nick Desaulniers 
Cc: Pavithra Gurushankar 
Cc: Peter Zijlstra 
Cc: Quentin Monnet 
Cc: Ravi Bangoria 
Cc: Remi Bernon 
Cc: Riccardo Mancini 
Cc: Song Liu 
Cc: Stephane Eranian 
Cc: Thomas Gleixner 
Cc: Thomas Richter 
Cc: Tom Rix 
Cc: Weiguo Li 
Cc: Wenyu Liu 
Cc: William Cohen 
Cc: Zechuan Chen 
Cc: bpf@vger.kernel.org
Cc: llvm@lists.linux.dev
Cc: yaowenbin 
Link: https://lore.kernel.org/r/20220826164242.43412-4-irogers@google.com
Signed-off-by: Arnaldo Carvalho de Melo

perf tests record: Fail the test if the 'errs' counter is not zero

2022-09-29T12:53:15+00:00

We were just checking for the 'err' variable, when we should really see
if there was some of the many checked errors that don't stop the test
right away.

Detected with clang 15.0.0:

  44    75.23 fedora:37       : FAIL clang version 15.0.0 (Fedora 15.0.0-2.fc37)

    tests/perf-record.c:68:16: error: variable 'errs' set but not used [-Werror,-Wunused-but-set-variable]
            int err = -1, errs = 0, i, wakeups = 0;
                          ^
    1 error generated.

The patch introducing this 'perf test' entry had that check:

  +       return (err < 0 || errs > 0) ? -1 : 0;

But at some point we lost that:

  -	  return (err < 0 || errs > 0) ? -1 : 0;
  +	  if (err == -EACCES)
  +               return TEST_SKIP;
  +	  if (err < 0)
  +               return TEST_FAIL;
  +	  return TEST_OK

Put it back.

Fixes: 2cf88f4614c996e5 ("perf test: Use skip in PERF_RECORD_*")
Acked-by: Ian Rogers 
Cc: Adrian Hunter 
Cc: Jiri Olsa 
Cc: Namhyung Kim 
Link: https://lore.kernel.org/lkml/YzR0n5QhsH9VyYB0@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo

perf test: Use skip in PERF_RECORD_*

2022-05-23T13:05:07+00:00

Check if the error code is EACCES and make the test a skip with
a "permissions" skip reason if so.

Committer testing:

Before:

  $ perf test PERF_RECORD
    8: PERF_RECORD_* events & perf_sample fields            : FAILED!
  $

After:

  $ perf test PERF_RECORD
    8: PERF_RECORD_* events & perf_sample fields            : Skip (permissions)
  $

Signed-off-by: Ian Rogers 
Tested-by: Arnaldo Carvalho de Melo 
Cc: Alexander Shishkin 
Cc: Carsten Haitzler 
Cc: Ingo Molnar 
Cc: Jiri Olsa 
Cc: John Garry 
Cc: Marco Elver 
Cc: Mark Rutland 
Cc: Michael Petlan 
Cc: Namhyung Kim 
Cc: Peter Zijlstra 
Cc: Riccardo Mancini 
Cc: Sohaib Mohamed 
Cc: Stephane Eranian 
Link: https://lore.kernel.org/r/20220518042027.836799-9-irogers@google.com
Signed-off-by: Arnaldo Carvalho de Melo

perf test: Rename struct test to test_suite

2021-11-13T13:32:22+00:00

This is to align with kunit's terminology.

Signed-off-by: Ian Rogers 
Tested-by: Sohaib Mohamed 
Acked-by: Jiri Olsa 
Cc: Alexander Shishkin 
Cc: Brendan Higgins 
Cc: Daniel Latypov 
Cc: David Gow 
Cc: Ingo Molnar 
Cc: Jin Yao 
Cc: John Garry 
Cc: Mark Rutland 
Cc: Namhyung Kim 
Cc: Paul Clarke 
Cc: Peter Zijlstra 
Cc: Stephane Eranian 
Link: https://lore.kernel.org/r/20211104064208.3156807-6-irogers@google.com
Signed-off-by: Arnaldo Carvalho de Melo

perf test: Move each test suite struct to its test

2021-11-13T13:30:58+00:00

Rather than export test functions, export the test struct. Rename with a
suite__ prefix to avoid name collisions.

Committer notes:

Its '&suite__vectors_page', not '&suite__vectors_pages', noticed when
cross building to arm (32-bit).

Signed-off-by: Ian Rogers 
Tested-by: Sohaib Mohamed 
Acked-by: Jiri Olsa 
Cc: Alexander Shishkin 
Cc: Brendan Higgins 
Cc: Daniel Latypov 
Cc: David Gow 
Cc: Ingo Molnar 
Cc: Jin Yao 
Cc: John Garry 
Cc: Mark Rutland 
Cc: Namhyung Kim 
Cc: Paul Clarke 
Cc: Peter Zijlstra 
Cc: Stephane Eranian 
Link: https://lore.kernel.org/r/20211104064208.3156807-5-irogers@google.com
Signed-off-by: Arnaldo Carvalho de Melo

perf evlist: Use the right prefix for 'struct evlist' event attribute config methods

2020-11-30T18:15:27+00:00

perf_evlist__ is for 'struct perf_evlist' methods, in tools/lib/perf/,
go on completing this split.

Cc: Adrian Hunter 
Cc: Ian Rogers 
Cc: Jiri Olsa 
Cc: Namhyung Kim 
Signed-off-by: Arnaldo Carvalho de Melo

perf evlist: Use the right prefix for alternative 'struct evlist' constructors

2020-11-30T18:04:05+00:00

perf_evlist__ is for 'struct perf_evlist' methods, in tools/lib/perf/,
go on completing this split.

Cc: Adrian Hunter 
Cc: Ian Rogers 
Cc: Jiri Olsa 
Cc: Namhyung Kim 
Signed-off-by: Arnaldo Carvalho de Melo

perf evlist: Use the right prefix for 'struct evlist' create maps methods

2020-11-30T17:56:52+00:00

perf_evlist__ is for 'struct perf_evlist' methods, in tools/lib/perf/,
go on completing this split.

Cc: Adrian Hunter 
Cc: Ian Rogers 
Cc: Jiri Olsa 
Cc: Namhyung Kim 
Signed-off-by: Arnaldo Carvalho de Melo