linux-toradex.git/tools/perf/util/debug.c, branch v2.6.34.7

perf: Fix endianness argument compatibility with OPT_BOOLEAN() and introduce OPT_INCR()

2010-07-05T18:21:54+00:00

commit c05556421742eb47f80301767653a4bcb19de9de upstream.

Parsing an option from the command line with OPT_BOOLEAN on a
bool data type would not work on a big-endian machine due to the
manner in which the boolean was being cast into an int and
incremented. For example, running 'perf probe --list' on a
PowerPC machine would fail to properly set the list_events bool
and would therefore print out the usage information and
terminate.

This patch makes OPT_BOOLEAN work as expected with a bool
datatype. For cases where the original OPT_BOOLEAN was
intentionally being used to increment an int each time it was
passed in on the command line, this patch introduces OPT_INCR
with the old behaviour of OPT_BOOLEAN (the verbose variable is
currently the only such example of this).

I have reviewed every use of OPT_BOOLEAN to verify that a true
C99 bool was passed. Where integers were used, I verified that
they were only being used for boolean logic and changed them to
bools to ensure that they would not be mistakenly used as ints.
The major exception was the verbose variable which now uses
OPT_INCR instead of OPT_BOOLEAN.

Signed-off-by: Ian Munsie 
Acked-by: David S. Miller 
Cc: 
Cc: Git development list 
Cc: Ian Munsie 
Cc: Peter Zijlstra 
Cc: Paul Mackerras 
Cc: Arnaldo Carvalho de Melo 
Cc: KOSAKI Motohiro 
Cc: Hitoshi Mitake 
Cc: Rusty Russell 
Cc: Frederic Weisbecker 
Cc: Eric B Munson 
Cc: Valdis.Kletnieks@vt.edu
Cc: WANG Cong 
Cc: Thiago Farina 
Cc: Masami Hiramatsu 
Cc: Xiao Guangrong 
Cc: Jaswinder Singh Rajput 
Cc: Arjan van de Ven 
Cc: OGAWA Hirofumi 
Cc: Mike Galbraith 
Cc: Tom Zanussi 
Cc: Anton Blanchard 
Cc: John Kacur 
Cc: Li Zefan 
Cc: Steven Rostedt 
LKML-Reference: <1271147857-11604-1-git-send-email-imunsie@au.ibm.com>
Signed-off-by: Ingo Molnar 
Signed-off-by: Greg Kroah-Hartman

perf tools: Move the map class definition to a separate header

2009-12-28T08:03:33+00:00

And this resulted in the need for adding some missing includes
in some places that were getting the definitions needed out of
sheer luck.

Signed-off-by: Arnaldo Carvalho de Melo 
Cc: Frédéric Weisbecker 
Cc: Mike Galbraith 
Cc: Peter Zijlstra 
Cc: Paul Mackerras 
LKML-Reference: <1261957026-15580-4-git-send-email-acme@infradead.org>
Signed-off-by: Ingo Molnar

perf tools: Unify debug messages mechanisms

2009-10-23T06:22:47+00:00

We were using eprintf in some places, that looks at a global
'verbose' level, and at other places passing a 'v' parameter to
specify the verbosity level, unify it by introducing
pr_{err,warning,debug,etc}, just like in the kernel.

Signed-off-by: Arnaldo Carvalho de Melo 
Cc: Frederic Weisbecker 
Cc: Peter Zijlstra 
Cc: Paul Mackerras 
Cc: Mike Galbraith 
LKML-Reference: <1256153646-10097-1-git-send-email-acme@redhat.com>
Signed-off-by: Ingo Molnar

perf tools: Librarize trace_event() helper

2009-08-16T21:06:45+00:00

Librarize trace_event() helper so that perf trace can use it
too. Also clean up the debug.h includes a bit.

It's not good to have it included in perf.h because it doesn't
make it flexible against other headers it may need (headers
that can also depend on perf.h and then create a recursive
header dependency).

Signed-off-by: Frederic Weisbecker 
Cc: Peter Zijlstra 
Cc: Arnaldo Carvalho de Melo 
Cc: Mike Galbraith 
LKML-Reference: <1250453149-664-1-git-send-email-fweisbec@gmail.com>
Signed-off-by: Ingo Molnar

perf tools: Factorize the dprintf definition

2009-08-16T17:42:31+00:00

We have two users of dprintf: report and annotate. Another one
is coming with perf trace. Then factorize it into the debug
file.

While at it, rename dprintf() to dump_printf() so that it
doesn't conflicts with its libc homograph.

Signed-off-by: Frederic Weisbecker 
Cc: Frederic Weisbecker 
Cc: Peter Zijlstra 
Cc: Arnaldo Carvalho de Melo 
Cc: Mike Galbraith 
LKML-Reference: <1250443461-28130-1-git-send-email-fweisbec@gmail.com>
Signed-off-by: Ingo Molnar

perf tools: Factorize high level dso helpers

2009-08-12T10:02:38+00:00

Factorize multiple definitions of high level dso helpers into the
symbol source file.

The side effect is a general export of the verbose and eprintf
debugging helpers into a new file dedicated to debugging purposes.

Signed-off-by: Frederic Weisbecker 
Cc: Arnaldo Carvalho de Melo 
Cc: Peter Zijlstra 
Cc: Mike Galbraith 
Cc: Brice Goglin