linux-toradex.git/tools/perf/util/expr.h, branch v6.3

perf pmu-events: Fix testing with JEVENTS_ARCH=all

2023-02-03T16:54:21+00:00

The #slots literal will return NAN when not on ARM64 which causes a
perf test failure when not on an ARM64 for a JEVENTS_ARCH=all build:
..
 10.4: Parsing of PMU event table metrics with fake PMUs             : FAILED!
..
Add an is_test boolean so that the failure can be avoided when running
as a test.

Fixes: acef233b7ca749fd ("perf pmu: Add #slots literal support for arm64")
Reviewed-by: John Garry 
Reviewed-by: Kajol Jain 
Signed-off-by: Ian Rogers 
Cc: Adrian Hunter 
Cc: Alexander Shishkin 
Cc: Caleb Biggers 
Cc: Florian Fischer 
Cc: Ian Rogers 
Cc: Ingo Molnar 
Cc: James Clark 
Cc: Jing Zhang 
Cc: Jiri Olsa 
Cc: Kan Liang 
Cc: Kang Minchul 
Cc: Kim Phillips 
Cc: Leo Yan 
Cc: Mark Rutland 
Cc: Mike Leach 
Cc: Namhyung Kim 
Cc: Perry Taylor 
Cc: Peter Zijlstra 
Cc: Ravi Bangoria 
Cc: Rob Herring 
Cc: Sandipan Das 
Cc: Stephane Eranian 
Cc: Will Deacon 
Cc: Xing Zhengjun 
Cc: linux-arm-kernel@lists.infradead.org
Cc: linuxppc-dev@lists.ozlabs.org
Link: https://lore.kernel.org/r/20230126233645.200509-13-irogers@google.com
Signed-off-by: Arnaldo Carvalho de Melo

perf expr: Tidy hashmap dependency

2022-11-16T15:17:15+00:00

hashmap.h comes from libbpf but isn't installed with its
headers. Always use the header file of the code in util. Change the
hashmap.h dependency in expr.h to a forward declaration, add the
necessary header file includes in the C files.

Signed-off-by: Ian Rogers 
Acked-by: Namhyung Kim 
Cc: Alexander Shishkin 
Cc: Andrii Nakryiko 
Cc: Jiri Olsa 
Cc: Mark Rutland 
Cc: Masahiro Yamada 
Cc: Nick Desaulniers 
Cc: Nicolas Schier 
Cc: Peter Zijlstra 
Cc: Stephane Eranian 
Cc: bpf@vger.kernel.org
Link: http://lore.kernel.org/lkml/20221109184914.1357295-12-irogers@google.com
Signed-off-by: Arnaldo Carvalho de Melo

perf metrics: Wire up core_wide

2022-10-04T11:55:22+00:00

Pass state necessary for core_wide into the expression parser. Add
system_wide and user_requested_cpu_list to perf_stat_config to make it
available at display time. evlist isn't used as the
evlist__create_maps, that computes user_requested_cpus, needs the list
of events which is generated by the metric.

Signed-off-by: Ian Rogers 
Cc: Ahmad Yasin 
Cc: Alexander Shishkin 
Cc: Andi Kleen 
Cc: Caleb Biggers 
Cc: Florian Fischer 
Cc: Ingo Molnar 
Cc: James Clark 
Cc: Jiri Olsa 
Cc: John Garry 
Cc: Kan Liang 
Cc: Kshipra Bopardikar 
Cc: Mark Rutland 
Cc: Miaoqian Lin 
Cc: Namhyung Kim 
Cc: Perry Taylor 
Cc: Peter Zijlstra 
Cc: Stephane Eranian 
Cc: Thomas Richter 
Cc: Xing Zhengjun 
Link: https://lore.kernel.org/r/20220831174926.579643-7-irogers@google.com
Signed-off-by: Arnaldo Carvalho de Melo

perf expr: Move the scanner_ctx into the parse_ctx

2022-10-04T11:55:22+00:00

We currently maintain the two independently and copy from one to the
other. This is a burden when additional scanner context values are
necessary, so combine them.

Signed-off-by: Ian Rogers 
Cc: Ahmad Yasin 
Cc: Alexander Shishkin 
Cc: Andi Kleen 
Cc: Caleb Biggers 
Cc: Florian Fischer 
Cc: Ingo Molnar 
Cc: James Clark 
Cc: Jiri Olsa 
Cc: John Garry 
Cc: Kan Liang 
Cc: Kshipra Bopardikar 
Cc: Mark Rutland 
Cc: Miaoqian Lin 
Cc: Namhyung Kim 
Cc: Perry Taylor 
Cc: Peter Zijlstra 
Cc: Stephane Eranian 
Cc: Thomas Richter 
Cc: Xing Zhengjun 
Link: https://lore.kernel.org/r/20220831174926.579643-3-irogers@google.com
Signed-off-by: Arnaldo Carvalho de Melo

perf hashmap: Tidy hashmap dependency

2022-10-04T11:55:19+00:00

When libbpf is present the build uses definitions in libbpf hashmap.c,
however, libbpf's hashmap.h wasn't being used. Switch to using the
correct hashmap.h dependent on the define HAVE_LIBBPF_SUPPORT. This was
the original intent in:

  https://lore.kernel.org/lkml/20200515221732.44078-8-irogers@google.com/

Signed-off-by: Ian Rogers 
Cc: Alexander Shishkin 
Cc: Jiri Olsa 
Cc: Mark Rutland 
Cc: Namhyung Kim 
Cc: Peter Zijlstra 
Cc: Stephane Eranian 
Link: http://lore.kernel.org/lkml/20220824050604.352156-1-irogers@google.com
Signed-off-by: Arnaldo Carvalho de Melo

perf expr: Add source_count for aggregating events

2021-11-13T21:11:50+00:00

Events like uncore_imc/cas_count_read/ on Skylake open multiple events
and then aggregate in the metric leader. To determine the average value
per event the number of these events is needed. Add a source_count
function that returns this value by counting the number of events with
the given metric leader. For most events the value is 1 but for
uncore_imc/cas_count_read/ it can yield values like 6.

Add a generic test, but manually tested with a test metric that uses
the function.

Signed-off-by: Ian Rogers 
Acked-by: Jiri Olsa 
Cc: Alexander Shishkin 
Cc: Andi Kleen 
Cc: Ingo Molnar 
Cc: John Garry 
Cc: Kajol Jain 
Cc: Kan Liang 
Cc: Madhavan Srinivasan 
Cc: Mark Rutland 
Cc: Namhyung Kim 
Cc: Paul A . Clarke 
Cc: Peter Zijlstra 
Cc: Riccardo Mancini 
Cc: Song Liu 
Cc: Wan Jiabing 
Cc: Yury Norov 
Link: https://lore.kernel.org/r/20211111002109.194172-9-irogers@google.com
Signed-off-by: Arnaldo Carvalho de Melo

perf expr: Add literal values starting with #

2021-11-13T21:11:50+00:00

It is useful to have literal values for constants relating to
topologies, SMT, etc. Make the parsing of literals shared code and add a
lookup function. Move #smt_on to this function.

Signed-off-by: Ian Rogers 
Acked-by: Jiri Olsa 
Cc: Alexander Shishkin 
Cc: Andi Kleen 
Cc: Ingo Molnar 
Cc: John Garry 
Cc: Kajol Jain 
Cc: Kan Liang 
Cc: Madhavan Srinivasan 
Cc: Mark Rutland 
Cc: Namhyung Kim 
Cc: Paul A . Clarke 
Cc: Peter Zijlstra 
Cc: Riccardo Mancini 
Cc: Song Liu 
Cc: Wan Jiabing 
Cc: Yury Norov 
Link: https://lore.kernel.org/r/20211111002109.194172-6-irogers@google.com
Signed-off-by: Arnaldo Carvalho de Melo

perf expr: Add subset_of_ids() utility

2021-10-20T13:59:17+00:00

Add a helper that returns true if all the IDs in needles are present in
haystack.

Later this will be used in sharing events between metrics.

Signed-off-by: Ian Rogers 
Acked-by: Andi Kleen 
Cc: Adrian Hunter 
Cc: Alexander Antonov 
Cc: Alexander Shishkin 
Cc: Andrew Kilroy 
Cc: Andrew Morton 
Cc: Changbin Du 
Cc: Denys Zagorui 
Cc: Fabian Hemmer 
Cc: Felix Fietkau 
Cc: Heiko Carstens 
Cc: Ingo Molnar 
Cc: Jacob Keller 
Cc: Jiapeng Chong 
Cc: Jin Yao 
Cc: Jiri Olsa 
Cc: Joakim Zhang 
Cc: John Garry 
Cc: Kajol Jain 
Cc: Kan Liang 
Cc: Kees Kook 
Cc: Mark Rutland 
Cc: Namhyung Kim 
Cc: Nicholas Fraser 
Cc: Nick Desaulniers 
Cc: Paul Clarke 
Cc: Peter Zijlstra 
Cc: Riccardo Mancini 
Cc: Sami Tolvanen 
Cc: ShihCheng Tu 
Cc: Song Liu 
Cc: Stephane Eranian 
Cc: Sumanth Korikkar 
Cc: Thomas Richter 
Cc: Wan Jiabing 
Cc: Zhen Lei 
Link: https://lore.kernel.org/r/20211015172132.1162559-18-irogers@google.com
Signed-off-by: Arnaldo Carvalho de Melo

perf metric: Modify resolution and recursion check

2021-10-20T13:35:33+00:00

Modify resolution. Rather than resolving a list of metrics, resolve a
metric immediately after it is added.

This simplifies knowing the root of the metric's tree so that IDs may be
associated with it.

A bug in the current implementation is that all the IDs were placed on
the first metric in a metric group.

Rather than maintain data on IDs' parents to detect cycles, maintain
a list of visited metrics and detect cycles if the same metric is
visited twice.

Only place the root metric onto the list of metrics.

Signed-off-by: Ian Rogers 
Acked-by: Andi Kleen 
Cc: Adrian Hunter 
Cc: Alexander Antonov 
Cc: Alexander Shishkin 
Cc: Andrew Kilroy 
Cc: Andrew Morton 
Cc: Changbin Du 
Cc: Denys Zagorui 
Cc: Fabian Hemmer 
Cc: Felix Fietkau 
Cc: Heiko Carstens 
Cc: Ingo Molnar 
Cc: Jacob Keller 
Cc: Jiapeng Chong 
Cc: Jin Yao 
Cc: Jiri Olsa 
Cc: Joakim Zhang 
Cc: John Garry 
Cc: Kajol Jain 
Cc: Kan Liang 
Cc: Kees Kook 
Cc: Mark Rutland 
Cc: Namhyung Kim 
Cc: Nicholas Fraser 
Cc: Nick Desaulniers 
Cc: Paul Clarke 
Cc: Peter Zijlstra 
Cc: Riccardo Mancini 
Cc: Sami Tolvanen 
Cc: ShihCheng Tu 
Cc: Song Liu 
Cc: Stephane Eranian 
Cc: Sumanth Korikkar 
Cc: Thomas Richter 
Cc: Wan Jiabing 
Cc: Zhen Lei 
Link: https://lore.kernel.org/r/20211015172132.1162559-10-irogers@google.com
Signed-off-by: Arnaldo Carvalho de Melo

perf metric: Move runtime value to the expr context

2021-10-20T13:33:02+00:00

The runtime value is needed when recursively parsing metrics, currently
a value of 1 is passed which is incorrect.

Rather than add more arguments to the bison parser, add runtime to the
context.

Fix call sites not to pass a value. The runtime value is defaulted to 0,
which is arbitrary. In some places this replaces a value of 1, which was
also arbitrary.

This shouldn't affect anything other than PPC.

The use of 0 or 1 shouldn't matter as a proper runtime value would be
needed in a case that it did matter.

Signed-off-by: Ian Rogers 
Acked-by: Andi Kleen 
Cc: Adrian Hunter 
Cc: Alexander Antonov 
Cc: Alexander Shishkin 
Cc: Andrew Kilroy 
Cc: Andrew Morton 
Cc: Changbin Du 
Cc: Denys Zagorui 
Cc: Fabian Hemmer 
Cc: Felix Fietkau 
Cc: Heiko Carstens 
Cc: Ingo Molnar 
Cc: Jacob Keller 
Cc: Jiapeng Chong 
Cc: Jin Yao 
Cc: Jiri Olsa 
Cc: Joakim Zhang 
Cc: John Garry 
Cc: Kajol Jain 
Cc: Kan Liang 
Cc: Kees Kook 
Cc: Mark Rutland 
Cc: Namhyung Kim 
Cc: Nicholas Fraser 
Cc: Nick Desaulniers 
Cc: Paul Clarke 
Cc: Peter Zijlstra 
Cc: Riccardo Mancini 
Cc: Sami Tolvanen 
Cc: ShihCheng Tu 
Cc: Song Liu 
Cc: Stephane Eranian 
Cc: Sumanth Korikkar 
Cc: Thomas Richter 
Cc: Wan Jiabing 
Cc: Zhen Lei 
Link: https://lore.kernel.org/r/20211015172132.1162559-6-irogers@google.com
Signed-off-by: Arnaldo Carvalho de Melo