linux-toradex.git/tools/perf/util/intel-pt-decoder/Build, branch master

perf build: Remove NO_AUXTRACE build option

2025-11-14T07:03:11+00:00

The NO_AUXTRACE build option was used when the __get_cpuid feature
test failed or if it was provided on the command line. The option no
longer avoids a dependency on a library and so having the option is
just adding complexity to the code base. Remove the option
CONFIG_AUXTRACE from Build files and HAVE_AUXTRACE_SUPPORT by assuming
it is always defined.

Signed-off-by: Ian Rogers 
Reviewed-by: James Clark 
Signed-off-by: Namhyung Kim

perf intel-pt: Remove stale build comment

2024-12-18T19:24:33+00:00

Commit 00a263902ac3 ("perf intel-pt: Use shared x86 insn decoder")
removed the use of diff, so remove stale busybox comment.

Signed-off-by: Ian Rogers 
Tested-by: Arnaldo Carvalho de Melo 
Acked-by: Adrian Hunter 
Cc: Alexander Shishkin 
Cc: Andi Kleen 
Cc: Athira Rajeev 
Cc: Colin Ian King 
Cc: Dapeng Mi 
Cc: Howard Chu 
Cc: Ilya Leoshkevich 
Cc: Ingo Molnar 
Cc: James Clark 
Cc: Jiri Olsa 
Cc: Josh Poimboeuf 
Cc: Kan Liang 
Cc: Mark Rutland 
Cc: Michael Petlan 
Cc: Namhyung Kim 
Cc: Peter Zijlstra 
Cc: Thomas Richter 
Cc: Veronika Molnarova 
Cc: Weilin Wang 
Link: https://lore.kernel.org/r/20241119011644.971342-14-irogers@google.com
Signed-off-by: Arnaldo Carvalho de Melo

perf x86: Define arch_fetch_insn in NO_AUXTRACE builds

2024-12-18T19:24:33+00:00

archinsn.c containing arch_fetch_insn was only enabled with
CONFIG_AUXTRACE, but this meant that a NO_AUXTRACE build on x86 would
use the empty weak version of arch_fetch_insn - weak symbols are a
frequent source of errors like this and are outside of the C
specification. Change it so that archinsn.c is always built on x86 and
make the weak symbol empty version of arch_fetch_insn a strong one
guarded by ifdefs.

arch_fetch_insn on x86 depends on insn_decode which is a function
included then built into intel-pt-insn-decoder.c.
intel-pt-insn-decoder.c isn't built in a NO_AUXTRACE=1 build. Separate
the insn_decode function from intel-pt-insn-decoder.c by just directly
compiling the relevant file. Guard this compilation to be for either
always on x86 (because of the use in arch_fetch_insn) or when auxtrace
is enabled. Apply the CFLAGS overrides as necessary, reducing the amount
of code where warnings are disabled.

Signed-off-by: Ian Rogers 
Tested-by: Adrian Hunter 
Tested-by: Arnaldo Carvalho de Melo 
Cc: Alexander Shishkin 
Cc: Andi Kleen 
Cc: Athira Rajeev 
Cc: Colin Ian King 
Cc: Dapeng Mi 
Cc: Howard Chu 
Cc: Ilya Leoshkevich 
Cc: Ingo Molnar 
Cc: James Clark 
Cc: Jiri Olsa 
Cc: Josh Poimboeuf 
Cc: Kan Liang 
Cc: Mark Rutland 
Cc: Michael Petlan 
Cc: Namhyung Kim 
Cc: Peter Zijlstra 
Cc: Thomas Richter 
Cc: Veronika Molnarova 
Cc: Weilin Wang 
Link: https://lore.kernel.org/r/20241119011644.971342-13-irogers@google.com
Signed-off-by: Arnaldo Carvalho de Melo

perf util: Make util its own library

2024-06-26T18:07:42+00:00

Make the util directory into its own library. This is done to avoid
compiling code twice, once for the perf tool and once for the perf
python module. For convenience:
  arch/common.c
  scripts/perl/Perf-Trace-Util/Context.c
  scripts/python/Perf-Trace-Util/Context.c
are made part of this library.

Signed-off-by: Ian Rogers 
Reviewed-by: James Clark 
Cc: Suzuki K Poulose 
Cc: Kees Cook 
Cc: Palmer Dabbelt 
Cc: Albert Ou 
Cc: Nick Terrell 
Cc: Gary Guo 
Cc: Alex Gaynor 
Cc: Boqun Feng 
Cc: Wedson Almeida Filho 
Cc: Ze Gao 
Cc: Alice Ryhl 
Cc: Andrei Vagin 
Cc: Yicong Yang 
Cc: Jonathan Cameron 
Cc: Guo Ren 
Cc: Miguel Ojeda 
Cc: Will Deacon 
Cc: Mike Leach 
Cc: Leo Yan 
Cc: Oliver Upton 
Cc: John Garry 
Cc: Benno Lossin 
Cc: Björn Roy Baron 
Cc: Andreas Hindborg 
Cc: Paul Walmsley 
Signed-off-by: Namhyung Kim 
Link: https://lore.kernel.org/r/20240625214117.953777-7-irogers@google.com

x86/insn: Use get_unaligned() instead of memcpy()

2021-10-06T09:56:37+00:00

Use get_unaligned() instead of memcpy() to access potentially unaligned
memory, which, when accessed through a pointer, leads to undefined
behavior. get_unaligned() describes much better what is happening there
anyway even if memcpy() does the job.

In addition, since perf tool builds with -Werror, it would fire with:

  util/intel-pt-decoder/../../../arch/x86/lib/insn.c: In function '__insn_get_emulate_prefix':
  tools/include/../include/asm-generic/unaligned.h:10:15: error: packed attribute is unnecessary [-Werror=packed]
     10 |  const struct { type x; } __packed *__pptr = (typeof(__pptr))(ptr); \

because -Werror=packed would complain if the packed attribute would have
no effect on the layout of the structure.

In this case, that is intentional so disable the warning only for that
compilation unit.

That part is Reported-by: Stephen Rothwell 

No functional changes.

Fixes: 5ba1071f7554 ("x86/insn, tools/x86: Fix undefined behavior due to potential unaligned accesses")
Suggested-by: Linus Torvalds 
Signed-off-by: Borislav Petkov 
Acked-by: Masami Hiramatsu 
Tested-by: Stephen Rothwell 
Link: https://lkml.kernel.org/r/YVSsIkj9Z29TyUjE@zn.tnic

perf intel-pt: Use shared x86 insn decoder

2019-09-01T01:27:52+00:00

Now that there's a common version of the decoder for all tools, use it
instead of the local copy.

Also use perf's check-headers.sh script to diff the decoder files to
make sure they remain in sync with the kernel version.  Objtool has a
similar check.

Committer notes:

Had to keep this all pointing explicitely to x86 headers/files, i.e.
instead of asm/isnn.h we had to use ../include/asm/insn.h when the files
were in differemt dirs, or just replace "" with "foo.h".

This way we continue to be able to process perf.data files with Intel PT
traces in distros other than x86.

Also fixed up the awk script paths to use $(srcdir)/tools/arch instead
or relative directories so that we keep detached tarballs (make help |
grep perf) working.

For now the include lines in these headers are being ignored so as not
to flag false reports of kernel/tools out of sync.

Signed-off-by: Josh Poimboeuf 
Reviewed-by: Masami Hiramatsu 
Acked-by: Peter Zijlstra (Intel) 
Cc: Adrian Hunter 
Cc: Jiri Olsa 
Cc: x86@kernel.org
Link: http://lore.kernel.org/lkml/8a37e615d2880f039505d693d1e068a009358a2b.1567118001.git.jpoimboe@redhat.com
Signed-off-by: Arnaldo Carvalho de Melo

perf intel-pt: Remove inat.c from build dependency list

2019-09-01T01:27:52+00:00

intel-pt-insn-decoder.c includes inat.c directly, so it already has an
implicit dependency on inat.c.  The Build file dependency is redundant.

Signed-off-by: Josh Poimboeuf 
Reviewed-by: Masami Hiramatsu 
Acked-by: Peter Zijlstra 
Cc: Adrian Hunter 
Cc: Jiri Olsa 
Cc: x86@kernel.org
Link: http://lore.kernel.org/lkml/53776d6d29bc9eceb571d52df8fa32250c58a0f3.1567118001.git.jpoimboe@redhat.com
Signed-off-by: Arnaldo Carvalho de Melo

perf tools: Rename build libperf to perf

2019-02-14T18:18:08+00:00

Rename build libperf to perf, because it's used to build perf.

The libperf build object name will be used for libperf library.

Signed-off-by: Jiri Olsa 
Cc: Alexander Shishkin 
Cc: Namhyung Kim 
Cc: Peter Zijlstra 
Link: http://lkml.kernel.org/r/20190213123246.4015-4-jolsa@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo

perf intel-pt: Improve build messages for files that differ from the kernel

2017-11-29T21:18:02+00:00

Print file names of files that differ. For example, instead of:

  Warning: Intel PT: x86 instruction decoder differs from kernel

print:

  Warning: Intel PT: x86 instruction decoder header at 'tools/perf/util/intel-pt-decoder/inat.h' differs from latest version at 'arch/x86/include/asm/inat.h'

Reported-by: Ingo Molnar 
Tested-by: Arnaldo Carvalho de Melo 
Signed-off-by: Adrian Hunter 
Link: http://lkml.kernel.org/r/1511253326-22308-2-git-send-email-adrian.hunter@intel.com
Signed-off-by: Arnaldo Carvalho de Melo

perf tools: Robustify detection of clang binary

2017-08-28T19:44:46+00:00

Prior to this patch, make scripts tested for CLANG with ifeq ($(CC),
clang), failing to detect CLANG binaries with different names. Fix it by
testing for the existence of __clang__ macro in the list of compiler
defined macros.

Signed-off-by: David Carrillo-Cisneros 
Acked-by: Jiri Olsa 
Cc: Alexander Shishkin 
Cc: Paul Turner 
Cc: Stephane Eranian 
Link: http://lkml.kernel.org/r/20170827075442.108534-5-davidcc@google.com
Signed-off-by: Arnaldo Carvalho de Melo