linux-toradex.git/tools/testing/nvdimm, branch v5.10-rc2

device-dax: add dis-contiguous resource support

2020-10-14T01:38:28+00:00

Break the requirement that device-dax instances are physically contiguous.
With this constraint removed it allows fragmented available capacity to
be fully allocated.

This capability is useful to mitigate the "noisy neighbor" problem with
memory-side-cache management for virtual machines, or any other scenario
where a platform address boundary also designates a performance boundary.
For example a direct mapped memory side cache might rotate cache colors at
1GB boundaries.  With dis-contiguous allocations a device-dax instance
could be configured to contain only 1 cache color.

It also satisfies Joao's use case (see link) for partitioning memory for
exclusive guest access.  It allows for a future potential mode where the
host kernel need not allocate 'struct page' capacity up-front.

Reported-by: Joao Martins 
Signed-off-by: Dan Williams 
Signed-off-by: Andrew Morton 
Cc: Andy Lutomirski 
Cc: Ard Biesheuvel 
Cc: Ard Biesheuvel 
Cc: Benjamin Herrenschmidt 
Cc: Ben Skeggs 
Cc: Bjorn Helgaas 
Cc: Borislav Petkov 
Cc: Boris Ostrovsky 
Cc: Brice Goglin 
Cc: Catalin Marinas 
Cc: Daniel Vetter 
Cc: Dave Hansen 
Cc: Dave Jiang 
Cc: David Airlie 
Cc: David Hildenbrand 
Cc: Greg Kroah-Hartman 
Cc: "H. Peter Anvin" 
Cc: Hulk Robot 
Cc: Ingo Molnar 
Cc: Ira Weiny 
Cc: Jason Gunthorpe 
Cc: Jason Yan 
Cc: Jeff Moyer 
Cc: "Jérôme Glisse" 
Cc: Jia He 
Cc: Jonathan Cameron 
Cc: Juergen Gross 
Cc: kernel test robot 
Cc: Michael Ellerman 
Cc: Mike Rapoport 
Cc: Paul Mackerras 
Cc: Pavel Tatashin 
Cc: Peter Zijlstra 
Cc: "Rafael J. Wysocki" 
Cc: Randy Dunlap 
Cc: Stefano Stabellini 
Cc: Thomas Gleixner 
Cc: Tom Lendacky 
Cc: Vishal Verma 
Cc: Vivek Goyal 
Cc: Wei Yang 
Cc: Will Deacon 
Link: https://lore.kernel.org/lkml/20200110190313.17144-1-joao.m.martins@oracle.com/
Link: https://lkml.kernel.org/r/159643104304.4062302.16561669534797528660.stgit@dwillia2-desk3.amr.corp.intel.com
Link: https://lkml.kernel.org/r/160106116875.30709.11456649969327399771.stgit@dwillia2-desk3.amr.corp.intel.com
Signed-off-by: Linus Torvalds

mm/memremap_pages: convert to 'struct range'

2020-10-14T01:38:28+00:00

The 'struct resource' in 'struct dev_pagemap' is only used for holding
resource span information.  The other fields, 'name', 'flags', 'desc',
'parent', 'sibling', and 'child' are all unused wasted space.

This is in preparation for introducing a multi-range extension of
devm_memremap_pages().

The bulk of this change is unwinding all the places internal to libnvdimm
that used 'struct resource' unnecessarily, and replacing instances of
'struct dev_pagemap'.res with 'struct dev_pagemap'.range.

P2PDMA had a minor usage of the resource flags field, but only to report
failures with "%pR".  That is replaced with an open coded print of the
range.

[dan.carpenter@oracle.com: mm/hmm/test: use after free in dmirror_allocate_chunk()]
  Link: https://lkml.kernel.org/r/20200926121402.GA7467@kadam

Signed-off-by: Dan Williams 
Signed-off-by: Dan Carpenter 
Signed-off-by: Andrew Morton 
Reviewed-by: Boris Ostrovsky 	[xen]
Cc: Paul Mackerras 
Cc: Michael Ellerman 
Cc: Benjamin Herrenschmidt 
Cc: Vishal Verma 
Cc: Vivek Goyal 
Cc: Dave Jiang 
Cc: Ben Skeggs 
Cc: David Airlie 
Cc: Daniel Vetter 
Cc: Ira Weiny 
Cc: Bjorn Helgaas 
Cc: Juergen Gross 
Cc: Stefano Stabellini 
Cc: "Jérôme Glisse" 
Cc: Andy Lutomirski 
Cc: Ard Biesheuvel 
Cc: Ard Biesheuvel 
Cc: Borislav Petkov 
Cc: Brice Goglin 
Cc: Catalin Marinas 
Cc: Dave Hansen 
Cc: David Hildenbrand 
Cc: Greg Kroah-Hartman 
Cc: "H. Peter Anvin" 
Cc: Hulk Robot 
Cc: Ingo Molnar 
Cc: Jason Gunthorpe 
Cc: Jason Yan 
Cc: Jeff Moyer 
Cc: Jia He 
Cc: Joao Martins 
Cc: Jonathan Cameron 
Cc: kernel test robot 
Cc: Mike Rapoport 
Cc: Pavel Tatashin 
Cc: Peter Zijlstra 
Cc: "Rafael J. Wysocki" 
Cc: Randy Dunlap 
Cc: Thomas Gleixner 
Cc: Tom Lendacky 
Cc: Wei Yang 
Cc: Will Deacon 
Link: https://lkml.kernel.org/r/159643103173.4062302.768998885691711532.stgit@dwillia2-desk3.amr.corp.intel.com
Link: https://lkml.kernel.org/r/160106115761.30709.13539840236873663620.stgit@dwillia2-desk3.amr.corp.intel.com
Signed-off-by: Linus Torvalds

device-dax: make pgmap optional for instance creation

2020-10-14T01:38:28+00:00

The passed in dev_pagemap is only required in the pmem case as the
libnvdimm core may have reserved a vmem_altmap for dev_memremap_pages() to
place the memmap in pmem directly.  In the hmem case there is no agent
reserving an altmap so it can all be handled by a core internal default.

Pass the resource range via a new @range property of 'struct
dev_dax_data'.

Signed-off-by: Dan Williams 
Signed-off-by: Andrew Morton 
Cc: David Hildenbrand 
Cc: Vishal Verma 
Cc: Dave Hansen 
Cc: Pavel Tatashin 
Cc: Brice Goglin 
Cc: Dave Jiang 
Cc: Ira Weiny 
Cc: Jia He 
Cc: Joao Martins 
Cc: Jonathan Cameron 
Cc: Andy Lutomirski 
Cc: Ard Biesheuvel 
Cc: Ard Biesheuvel 
Cc: Benjamin Herrenschmidt 
Cc: Ben Skeggs 
Cc: Bjorn Helgaas 
Cc: Borislav Petkov 
Cc: Boris Ostrovsky 
Cc: Catalin Marinas 
Cc: Daniel Vetter 
Cc: David Airlie 
Cc: Greg Kroah-Hartman 
Cc: "H. Peter Anvin" 
Cc: Hulk Robot 
Cc: Ingo Molnar 
Cc: Jason Gunthorpe 
Cc: Jason Yan 
Cc: Jeff Moyer 
Cc: "Jérôme Glisse" 
Cc: Juergen Gross 
Cc: kernel test robot 
Cc: Michael Ellerman 
Cc: Mike Rapoport 
Cc: Paul Mackerras 
Cc: Peter Zijlstra 
Cc: "Rafael J. Wysocki" 
Cc: Randy Dunlap 
Cc: Stefano Stabellini 
Cc: Thomas Gleixner 
Cc: Tom Lendacky 
Cc: Vivek Goyal 
Cc: Wei Yang 
Cc: Will Deacon 
Link: https://lkml.kernel.org/r/159643099958.4062302.10379230791041872886.stgit@dwillia2-desk3.amr.corp.intel.com
Link: https://lkml.kernel.org/r/160106110513.30709.4303239334850606031.stgit@dwillia2-desk3.amr.corp.intel.com
Signed-off-by: Linus Torvalds

x86, powerpc: Rename memcpy_mcsafe() to copy_mc_to_{user, kernel}()

2020-10-06T09:18:04+00:00

In reaction to a proposal to introduce a memcpy_mcsafe_fast()
implementation Linus points out that memcpy_mcsafe() is poorly named
relative to communicating the scope of the interface. Specifically what
addresses are valid to pass as source, destination, and what faults /
exceptions are handled.

Of particular concern is that even though x86 might be able to handle
the semantics of copy_mc_to_user() with its common copy_user_generic()
implementation other archs likely need / want an explicit path for this
case:

  On Fri, May 1, 2020 at 11:28 AM Linus Torvalds  wrote:
  >
  > On Thu, Apr 30, 2020 at 6:21 PM Dan Williams  wrote:
  > >
  > > However now I see that copy_user_generic() works for the wrong reason.
  > > It works because the exception on the source address due to poison
  > > looks no different than a write fault on the user address to the
  > > caller, it's still just a short copy. So it makes copy_to_user() work
  > > for the wrong reason relative to the name.
  >
  > Right.
  >
  > And it won't work that way on other architectures. On x86, we have a
  > generic function that can take faults on either side, and we use it
  > for both cases (and for the "in_user" case too), but that's an
  > artifact of the architecture oddity.
  >
  > In fact, it's probably wrong even on x86 - because it can hide bugs -
  > but writing those things is painful enough that everybody prefers
  > having just one function.

Replace a single top-level memcpy_mcsafe() with either
copy_mc_to_user(), or copy_mc_to_kernel().

Introduce an x86 copy_mc_fragile() name as the rename for the
low-level x86 implementation formerly named memcpy_mcsafe(). It is used
as the slow / careful backend that is supplanted by a fast
copy_mc_generic() in a follow-on patch.

One side-effect of this reorganization is that separating copy_mc_64.S
to its own file means that perf no longer needs to track dependencies
for its memcpy_64.S benchmarks.

 [ bp: Massage a bit. ]

Signed-off-by: Dan Williams 
Signed-off-by: Borislav Petkov 
Reviewed-by: Tony Luck 
Acked-by: Michael Ellerman 
Cc: 
Link: http://lore.kernel.org/r/CAHk-=wjSqtXAqfUJxFtWNwmguFASTgB0dz1dT3V-78Quiezqbg@mail.gmail.com
Link: https://lkml.kernel.org/r/160195561680.2163339.11574962055305783722.stgit@dwillia2-desk3.amr.corp.intel.com

tools/testing/nvdimm: Emulate firmware activation commands

2020-07-26T01:34:48+00:00

Augment the existing firmware update emulation to track activations and
validate proper update vs activate sequencing.

The DIMM firmware activate capability has a concept of a maximum amount
of time platform firmware will quiesce the system relative to how many
DIMMs are being activated in parallel. Simulate that DIMM activation
happens serially, 1 second per-DIMM, and limit the max at 3 seconds. The
nfit_test0 bus emulates 5 DIMMs so it will take 2 activations to update
all DIMMs.

Cc: Vishal Verma 
Cc: Dave Jiang 
Cc: Ira Weiny 
Reported-by: Andy Shevchenko 
Signed-off-by: Dan Williams 
Signed-off-by: Vishal Verma

tools/testing/nvdimm: Prepare nfit_ctl_test() for ND_CMD_CALL emulation

2020-07-26T01:34:47+00:00

In preparation for adding a mocked implementation of the
firmware-activate bus-info command, rework nfit_ctl_test() to operate on
a local command payload wrapped in a 'struct nd_cmd_pkg'.

Cc: Vishal Verma 
Cc: Dave Jiang 
Cc: Ira Weiny 
Signed-off-by: Dan Williams 
Signed-off-by: Vishal Verma

tools/testing/nvdimm: Add command debug messages

2020-07-26T01:34:47+00:00

Arrange the for nfit_test_ctl() path to dump command payloads similarly
to the acpi_nfit_ctl() path. This is useful for comparing the
sequence of command events between an emulated ACPI-NFIT platform and a
real one.

Cc: Vishal Verma 
Cc: Dave Jiang 
Cc: Ira Weiny 
Signed-off-by: Dan Williams 
Signed-off-by: Vishal Verma

tools/testing/nvdimm: Cleanup dimm index passing

2020-07-26T01:34:47+00:00

The ND_CMD_CALL path only applies to the nfit_test0 emulated DIMMs.
Cleanup occurrences of (i - t->dcr_idx) since that offset fixup only
applies to cases where nfit_test1 needs a bus-local index.

Cc: Vishal Verma 
Cc: Dave Jiang 
Cc: Ira Weiny 
Signed-off-by: Dan Williams 
Signed-off-by: Vishal Verma

ACPI: NFIT: Move bus_dsm_mask out of generic nvdimm_bus_descriptor

2020-07-26T01:34:47+00:00

DSMs are strictly an ACPI mechanism, evict the bus_dsm_mask concept from
the generic 'struct nvdimm_bus_descriptor' object.

As a side effect the test facility ->bus_nfit_cmd_force_en is no longer
necessary. The test infrastructure can communicate that information
directly in ->bus_dsm_mask.

Cc: Vishal Verma 
Cc: Dave Jiang 
Cc: Ira Weiny 
Signed-off-by: Dan Williams 
Signed-off-by: Vishal Verma

tools/testing/nvdimm: Replace zero-length array with flexible-array

2020-06-16T04:08:32+00:00

There is a regular need in the kernel to provide a way to declare having a
dynamically sized set of trailing elements in a structure. Kernel code should
always use “flexible array members”[1] for these cases. The older style of
one-element or zero-length arrays should no longer be used[2].

[1] https://en.wikipedia.org/wiki/Flexible_array_member
[2] https://github.com/KSPP/linux/issues/21

Signed-off-by: Gustavo A. R. Silva