linux-toradex.git/tools/testing/selftests/cgroup/test_memcontrol.c, branch v6.13

mm, memcg: cg2 memory{.swap,}.peak write tests

2024-09-02T03:25:53+00:00

Extend two existing tests to cover extracting memory usage through the
newly mutable memory.peak and memory.swap.peak handlers.

In particular, make sure to exercise adding and removing watchers with
overlapping lifetimes so the less-trivial logic gets tested.

The new/updated tests attempt to detect a lack of the write handler by
fstat'ing the memory.peak and memory.swap.peak files and skip the tests if
that's the case.  Additionally, skip if the file doesn't exist at all.

[davidf@vimeo.com: update tests]
  Link: https://lkml.kernel.org/r/20240730231304.761942-3-davidf@vimeo.com
Link: https://lkml.kernel.org/r/20240729143743.34236-3-davidf@vimeo.com
Signed-off-by: David Finkel 
Acked-by: Tejun Heo 
Reviewed-by: Roman Gushchin 
Cc: Johannes Weiner 
Cc: Jonathan Corbet 
Cc: Michal Hocko 
Cc: Michal Koutný 
Cc: Muchun Song 
Cc: Shakeel Butt 
Cc: Shuah Khan 
Cc: Waiman Long 
Cc: Zefan Li 
Signed-off-by: Andrew Morton

Revert "selftests/cgroup: Drop define _GNU_SOURCE"

2024-05-20T15:00:15+00:00

This reverts commit c1457d9aad5ee2feafcf85aa9a58ab50500159d2.

The framework change to add D_GNU_SOURCE to KHDR_INCLUDES
to Makefile, lib.mk, and kselftest_harness.h is reverted
as it is causing build failures and warnings.

Revert this change as this change depends on the framework
change.

Reported-by: Mark Brown 
Signed-off-by: Shuah Khan

selftests/cgroup: Drop define _GNU_SOURCE

2024-05-13T17:02:36+00:00

_GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
redefinition warnings.

Signed-off-by: Edward Liaw 
Signed-off-by: Tejun Heo

selftests/cgroup: fix clang warnings: uninitialized fd variable

2024-05-03T19:06:09+00:00

First of all, in order to build with clang at all, one must first apply
Valentin Obst's build fix for LLVM [1]. Once that is done, then when
building with clang, via:

    make LLVM=1 -C tools/testing/selftests

...clang warns about fd being used uninitialized, in
test_memcg_reclaim()'s error handling path.

Fix this by initializing fd to -1.

[1] https://lore.kernel.org/all/20240329-selftests-libmk-llvm-rfc-v1-1-2f9ed7d1c49f@valentinobst.de/

Signed-off-by: John Hubbard 
Reviewed-by: Roman Gushchin 
Signed-off-by: Tejun Heo

selftests: cgroup: skip test_cgcore_lesser_ns_open when cgroup2 mounted without nsdelegate

2024-04-03T19:42:13+00:00

The test case test_cgcore_lesser_ns_open only tasks effect when cgroup2
is mounted with "nsdelegate" mount option. If it misses this option, or
is remounted without "nsdelegate", the test case will fail. For example,
running bpf/test_cgroup_storage first, and then run cgroup/test_core will
fail on test_cgcore_lesser_ns_open. Skip it if "nsdelegate" is not
detected in cgroup2 mount options.

Fixes: bf35a7879f1d ("selftests: cgroup: Test open-time cgroup namespace usage for migration checks")
Signed-off-by: Tianchen Ding 
Reviewed-by: Muhammad Usama Anjum 
Signed-off-by: Tejun Heo

selftests: cgroup: fix unexpected failure on test_memcg_sock

2023-06-23T23:59:26+00:00

Before server got a client connection, there were some memory allocations
in the test memcg, such as user stack.  So do not count those allocations
which are not related to socket when checking socket memory accounting.

Link: https://lkml.kernel.org/r/20230619124735.2124-1-haifeng.xu@shopee.com
Signed-off-by: Haifeng Xu 
Cc: Johannes Weiner 
Cc: Michal Hocko 
Cc: Michal Koutný 
Cc: Roman Gushchin 
Cc: Shakeel Butt 
Signed-off-by: Andrew Morton

selftests: cgroup: fix unexpected failure on test_memcg_low

2023-06-09T23:25:39+00:00

Since commit f079a020ba95 ("selftests: memcg: factor out common parts of
memory.{low,min} tests"), the value used in second alloc_anon has changed
from 148M to 170M.  Because memory.low allows reclaiming page cache in
child cgroups, so the memory.current is close to 30M instead of 50M. 
Therefore, adjust the expected value of parent cgroup.

Link: https://lkml.kernel.org/r/20230522095233.4246-2-haifeng.xu@shopee.com
Fixes: f079a020ba95 ("selftests: memcg: factor out common parts of memory.{low,min} tests")
Signed-off-by: Haifeng Xu 
Cc: Johannes Weiner 
Cc: Michal Hocko 
Cc: Roman Gushchin 
Cc: Shakeel Butt 
Signed-off-by: Andrew Morton

selftests: cgroup: Add 'malloc' failures checks in test_memcontrol

2023-03-28T16:25:25+00:00

There are several 'malloc' calls in test_memcontrol, which can be
unsuccessful. This patch will add 'malloc' failures checking to
give more details about test's fail reasons and avoid possible
undefined behavior during the future null dereference (like the
one in alloc_anon_50M_check_swap function).

Signed-off-by: Ivan Orlov 
Reviewed-by: Muchun Song 
Acked-by: Shakeel Butt 
Acked-by: Roman Gushchin 
Signed-off-by: Shuah Khan

selftests: cgroup: make sure reclaim target memcg is unprotected

2022-12-12T02:12:19+00:00

Make sure that we ignore protection of a memcg that is the target of memcg
reclaim.

Link: https://lkml.kernel.org/r/20221202031512.1365483-4-yosryahmed@google.com
Signed-off-by: Yosry Ahmed 
Reviewed-by: Roman Gushchin 
Cc: Chris Down 
Cc: David Rientjes 
Cc: Johannes Weiner 
Cc: Matthew Wilcox 
Cc: Michal Hocko 
Cc: Muchun Song 
Cc: Shakeel Butt 
Cc: Tejun Heo 
Cc: Vasily Averin 
Cc: Vlastimil Babka 
Cc: Yu Zhao 
Signed-off-by: Andrew Morton

selftests: cgroup: refactor proactive reclaim code to reclaim_until()

2022-12-12T02:12:19+00:00

Refactor the code that drives writing to memory.reclaim (retrying, error
handling, etc) from test_memcg_reclaim() to a helper called
reclaim_until(), which proactively reclaims from a memcg until its usage
reaches a certain value.

While we are at it, refactor and simplify the reclaim loop.

This will be used in a following patch in another test.

Link: https://lkml.kernel.org/r/20221202031512.1365483-3-yosryahmed@google.com
Signed-off-by: Yosry Ahmed 
Suggested-by: Roman Gushchin 
Reviewed-by: Roman Gushchin 
Cc: Chris Down 
Cc: David Rientjes 
Cc: Johannes Weiner 
Cc: Matthew Wilcox 
Cc: Michal Hocko 
Cc: Muchun Song 
Cc: Shakeel Butt 
Cc: Tejun Heo 
Cc: Vasily Averin 
Cc: Vlastimil Babka 
Cc: Yu Zhao 
Signed-off-by: Andrew Morton