linux-toradex.git/tools/testing/selftests/livepatch/functions.sh, branch v5.15-rc5

selftests/livepatch: Do not check order when using "comm" for dmesg checking

2020-08-27T13:27:24+00:00

check_result() uses "comm" to check expected results of selftests output
in dmesg. Everything works fine if timestamps in dmesg are unique. If
not, like in this example

[   86.844422] test_klp_callbacks_demo: pre_unpatch_callback: test_klp_callbacks_mod -> [MODULE_STATE_LIVE] Normal state
[   86.844422] livepatch: 'test_klp_callbacks_demo': starting unpatching transition

, "comm" fails with "comm: file 2 is not in sorted order". Suppress the
order checking with --nocheck-order option.

Fixes: 2f3f651f3756 ("selftests/livepatch: Use "comm" instead of "diff" for dmesg")
Signed-off-by: Miroslav Benes 
Acked-by: Joe Lawrence 
Signed-off-by: Jiri Kosina

selftests/livepatch: adopt to newer sysctl error format

2020-07-15T06:54:35+00:00

With procfs v3.3.16, the sysctl command doesn't print the set key and
value on error.  This change breaks livepatch selftest test-ftrace.sh,
that tests the interaction of sysctl ftrace_enabled:

Make it work with all sysctl versions using '-q' option.

Explicitly print the final status on success so that it can be verified
in the log. The error message is enough on failure.

Reported-by: Kamalesh Babulal 
Signed-off-by: Petr Mladek 
Reviewed-by: Kamalesh Babulal 
Reviewed-by: Joe Lawrence 
Acked-by: Miroslav Benes 
Link: https://lore.kernel.org/r/20200714091030.1611-1-pmladek@suse.com

selftests/livepatch: Use "comm" instead of "diff" for dmesg

2020-07-14T07:32:27+00:00

BusyBox diff doesn't support the GNU diff '--LTYPE-line-format' options
that were used in the selftests to filter older kernel log messages from
dmesg output.

Use "comm" which is more available in smaller boot environments.

Reported-by: Naresh Kamboju 
Signed-off-by: Joe Lawrence 
Reviewed-by: Yannick Cote 
Reviewed-by: Kamalesh Babulal 
Signed-off-by: Petr Mladek 
Link: https://lore.kernel.org/r/20200710183745.19730-1-joe.lawrence@redhat.com

selftests/livepatch: add test delimiter to dmesg

2020-06-19T08:47:18+00:00

Make it bit easier to parse the kernel logs during the selftests by
adding a "===== TEST: $test =====" delimiter when each individual test
begins.

Suggested-by: Petr Mladek 
Signed-off-by: Joe Lawrence 
Reviewed-by: Kamalesh Babulal 
Reviewed-by: Yannick Cote 
Reviewed-by: Petr Mladek 
Acked-by: Miroslav Benes 
Signed-off-by: Petr Mladek 
Link: https://lore.kernel.org/r/20200618181040.21132-4-joe.lawrence@redhat.com

selftests/livepatch: refine dmesg 'taints' in dmesg comparison

2020-06-19T08:47:04+00:00

The livepatch selftests currently grep on "taints" to filter out
"tainting kernel with TAINT_LIVEPATCH" messages which may be logged when
loading livepatch modules.

Further filter the log to drop "loading out-of-tree module taints
kernel" in the rare case the klp_test modules have been built
out-of-tree.

Look for the longer "taints kernel" or "tainting kernel" strings to
avoid inadvertent partial matching.

Signed-off-by: Joe Lawrence 
Reviewed-by: Kamalesh Babulal 
Reviewed-by: Yannick Cote 
Reviewed-by: Petr Mladek 
Acked-by: Miroslav Benes 
Signed-off-by: Petr Mladek 
Link: https://lore.kernel.org/r/20200618181040.21132-3-joe.lawrence@redhat.com

selftests/livepatch: Don't clear dmesg when running tests

2020-06-19T08:46:42+00:00

Inspired by commit f131d9edc29d ("selftests/lkdtm: Don't clear dmesg
when running tests"), keep a reference dmesg copy when beginning each
test.  This way check_result() can compare against the initial copy
rather than relying upon an empty log.

Signed-off-by: Joe Lawrence 
Reviewed-by: Kamalesh Babulal 
Reviewed-by: Yannick Cote 
Reviewed-by: Petr Mladek 
Acked-by: Miroslav Benes 
Signed-off-by: Petr Mladek 
Link: https://lore.kernel.org/r/20200618181040.21132-2-joe.lawrence@redhat.com

selftests/livepatch: Remove unused local variable in set_ftrace_enabled()

2020-01-16T20:05:49+00:00

set_ftrace_enabled() contains unused local variable "sysctl". Remove it.

Signed-off-by: Miroslav Benes 
Reviewed-by: Kamalesh Babulal 
Signed-off-by: Shuah Khan

selftests: livepatch: Fix it to do root uid check and skip

2019-12-23T17:52:40+00:00

livepatch test configures the system and debug environment to run
tests. Some of these actions fail without root access and test
dumps several permission denied messages before it exits.

Fix test-state.sh to call setup_config instead of set_dynamic_debug
as suggested by Petr Mladek 

Fix it to check root uid and exit with skip code instead.

Signed-off-by: Shuah Khan 
Acked-by: Joe Lawrence 
Reviewed-by: Petr Mladek 
Signed-off-by: Shuah Khan

selftests/livepatch: Test interaction with ftrace_enabled

2019-11-04T14:33:16+00:00

Since livepatching depends upon ftrace handlers to implement "patched"
code functionality, verify that the ftrace_enabled sysctl value
interacts with livepatch registration as expected.  At the same time,
ensure that ftrace_enabled is set and part of the test environment
configuration that is saved and restored when running the selftests.

Link: http://lkml.kernel.org/r/20191016113316.13415-4-mbenes@suse.cz

Signed-off-by: Joe Lawrence 
Signed-off-by: Miroslav Benes 
Signed-off-by: Steven Rostedt (VMware)

selftests/livepatch: Make dynamic debug setup and restore generic

2019-11-04T14:33:15+00:00

Livepatch selftests currently save the current dynamic debug config and
tweak it for the selftests. The config is restored at the end. Make the
infrastructure generic, so that more variables can be saved and
restored.

Link: http://lkml.kernel.org/r/20191016113316.13415-3-mbenes@suse.cz

Signed-off-by: Joe Lawrence 
Signed-off-by: Miroslav Benes 
Signed-off-by: Steven Rostedt (VMware)