linux-toradex.git/tools/testing/selftests/sgx/Makefile, branch master

selftests: centralize -D_GNU_SOURCE= to CFLAGS in lib.mk

2024-07-10T19:14:51+00:00

Centralize the _GNU_SOURCE definition to CFLAGS in lib.mk.  Remove
redundant defines from Makefiles that import lib.mk.  Convert any usage of
"#define _GNU_SOURCE 1" to "#define _GNU_SOURCE".

This uses the form "-D_GNU_SOURCE=", which is equivalent to
"#define _GNU_SOURCE".

Otherwise using "-D_GNU_SOURCE" is equivalent to "-D_GNU_SOURCE=1" and
"#define _GNU_SOURCE 1", which is less commonly seen in source code and
would require many changes in selftests to avoid redefinition warnings.

Link: https://lkml.kernel.org/r/20240625223454.1586259-2-edliaw@google.com
Signed-off-by: Edward Liaw 
Suggested-by: John Hubbard 
Acked-by: Shuah Khan 
Reviewed-by: Muhammad Usama Anjum 
Cc: Albert Ou 
Cc: André Almeida 
Cc: Darren Hart 
Cc: Dave Hansen 
Cc: Davidlohr Bueso 
Cc: David S. Miller 
Cc: Eric Dumazet 
Cc: Eric W. Biederman 
Cc: Fenghua Yu 
Cc: Ingo Molnar 
Cc: Jakub Kicinski 
Cc: Jarkko Sakkinen 
Cc: Jason Gunthorpe 
Cc: Kees Cook 
Cc: Kevin Tian 
Cc: Palmer Dabbelt 
Cc: Paolo Abeni 
Cc: Paolo Bonzini 
Cc: Paul Walmsley 
Cc: Peter Zijlstra 
Cc: Reinette Chatre 
Cc: Sean Christopherson 
Cc: Thomas Gleixner 
Signed-off-by: Andrew Morton

Revert "selftests/sgx: Include KHDR_INCLUDES in Makefile"

2024-05-20T15:00:06+00:00

This reverts commit 2c3b8f8f37c6c0c926d584cf4158db95e62b960c.

The framework change to add D_GNU_SOURCE to KHDR_INCLUDES
to Makefile, lib.mk, and kselftest_harness.h is reverted
as it is causing build failures and warnings.

Revert this change as this change depends on the framework
change.

Reported-by: Mark Brown 
Signed-off-by: Shuah Khan

selftests/sgx: Include KHDR_INCLUDES in Makefile

2024-05-08T23:08:46+00:00

Add KHDR_INCLUDES to the CFLAGS to pull in the kselftest harness
dependencies (-D_GNU_SOURCE).

Also, remove redefinitions of _GNU_SOURCE in the source code.

Fixes: 809216233555 ("selftests/harness: remove use of LINE_MAX")
Reported-by: kernel test robot 
Closes: https://lore.kernel.org/oe-lkp/202404301040.3bea5782-oliver.sang@intel.com
Signed-off-by: Edward Liaw 
Reviewed-by: Muhammad Usama Anjum 
Acked-by: Dave Hansen 
Reviewed-by: Jarkko Sakkinen 
Tested-by: Jarkko Sakkinen 
Reviewed-by: John Hubbard 
Signed-off-by: Shuah Khan

selftests/sgx: Skip non X86_64 platform

2023-12-08T18:08:17+00:00

When building whole selftests on arm64, rsync gives an erorr about sgx:

rsync: [sender] link_stat "/root/linux-next/tools/testing/selftests/sgx/test_encl.elf" failed: No such file or directory (2)
rsync error: some files/attrs were not transferred (see previous errors) (code 23) at main.c(1327) [sender=3.2.5]

The root casue is sgx only used on X86_64, and shall be skipped on other
platforms.

Fix this by moving TEST_CUSTOM_PROGS and TEST_FILES inside the if check,
then the build result will be "Skipping non-existent dir: sgx".

Fixes: 2adcba79e69d ("selftests/x86: Add a selftest for SGX")
Signed-off-by: Zhao Mengmeng 
Signed-off-by: Dave Hansen 
Reviewed-by: Jarkko Sakkinen 
Link: https://lore.kernel.org/all/20231206025605.3965302-1-zhaomzhao%40126.com

selftests/sgx: Produce static-pie executable for test enclave

2023-12-08T18:05:27+00:00

The current combination of -static and -fPIC creates a static executable
with position-dependent addresses for global variables. Use -static-pie
and -fPIE to create a proper static position independent executable that
can be loaded at any address without a dynamic linker.

When building the original "lea (encl_stack)(%rbx), %rax" assembly code
with -static-pie -fPIE, the linker complains about a relocation it cannot
resolve:

/usr/local/bin/ld: /tmp/cchIWyfG.o: relocation R_X86_64_32S against
`.data' can not be used when making a PIE object; recompile with -fPIE
collect2: error: ld returned 1 exit status

Thus, since only RIP-relative addressing is legit for local symbols, use
"encl_stack(%rip)" and declare an explicit "__encl_base" symbol at the
start of the linker script to be able to calculate the stack address
relative to the current TCS in the enclave assembly entry code.

Signed-off-by: Jo Van Bulck 
Signed-off-by: Dave Hansen 
Reviewed-by: Jarkko Sakkinen 
Acked-by: Kai Huang 
Link: https://lore.kernel.org/all/f9c24d89-ed72-7d9e-c650-050d722c6b04@cs.kuleuven.be/
Link: https://lore.kernel.org/all/20231005153854.25566-8-jo.vanbulck%40cs.kuleuven.be

selftests/sgx: Specify freestanding environment for enclave compilation

2023-12-08T18:05:27+00:00

Use -ffreestanding to assert the enclave compilation targets a
freestanding environment (i.e., without "main" or standard libraries).
This fixes clang reporting "undefined reference to `memset'" after
erroneously optimizing away the provided memset/memcpy implementations.

Still need to instruct the linker from using standard system startup
functions, but drop -nostartfiles as it is implied by -nostdlib.

Signed-off-by: Jo Van Bulck 
Signed-off-by: Dave Hansen 
Reviewed-by: Jarkko Sakkinen 
Acked-by: Kai Huang 
Link: https://lore.kernel.org/all/20231005153854.25566-6-jo.vanbulck%40cs.kuleuven.be

selftests/sgx: Separate linker options

2023-12-08T18:05:26+00:00

Fixes "'linker' input unused [-Wunused-command-line-argument]" errors when
compiling with clang.

Signed-off-by: Jo Van Bulck 
Signed-off-by: Dave Hansen 
Reviewed-by: Jarkko Sakkinen 
Link: https://lore.kernel.org/all/20231005153854.25566-5-jo.vanbulck%40cs.kuleuven.be

selftests/sgx: Add "test_encl.elf" to TEST_FILES

2023-05-08T17:01:03+00:00

The "test_encl.elf" file used by test_sgx is not installed in
INSTALL_PATH. Attempting to execute test_sgx causes false negative:

"
enclave executable open(): No such file or directory
main.c:188:unclobbered_vdso:Failed to load the test enclave.
"

Add "test_encl.elf" to TEST_FILES so that it will be installed.

Fixes: 2adcba79e69d ("selftests/x86: Add a selftest for SGX")
Signed-off-by: Yi Lai 
Reviewed-by: Jarkko Sakkinen 
Signed-off-by: Shuah Khan

selftests/sgx: Treat CC as one argument

2022-02-17T19:55:17+00:00

CC can have multiple sub-strings like "ccache gcc". For check_cc.sh,
CC needs to be treated like one argument. Put double quotes around it to
make CC one string and hence one argument.

Fixes: 2adcba79e69d ("selftests/x86: Add a selftest for SGX")
Reported-by: "kernelci.org bot" 
Signed-off-by: Muhammad Usama Anjum 
Signed-off-by: Dave Hansen 
Link: https://lkml.kernel.org/r/20220214184109.3739179-3-usama.anjum@collabora.com

selftests/sgx: Fix a benign linker warning

2021-11-15T19:33:53+00:00

The enclave binary (test_encl.elf) is built with only three sections (tcs,
text, and data) as controlled by its custom linker script.

If gcc is built with "--enable-linker-build-id" (this appears to be a
common configuration even if it is by default off) then gcc
will pass "--build-id" to the linker that will prompt it (the linker) to
write unique bits identifying the linked file to a ".note.gnu.build-id"
section.

The section ".note.gnu.build-id" does not exist in the test enclave
resulting in the following warning emitted by the linker:

/usr/bin/ld: warning: .note.gnu.build-id section discarded, --build-id
ignored

The test enclave does not use the build id within the binary so fix the
warning by passing a build id of "none" to the linker that will disable the
setting from any earlier "--build-id" options and thus disable the attempt
to write the build id to a ".note.gnu.build-id" section that does not
exist.

Link: https://lore.kernel.org/linux-sgx/20191017030340.18301-2-sean.j.christopherson@intel.com/
Suggested-by: Cedric Xing 
Signed-off-by: Sean Christopherson 
Signed-off-by: Reinette Chatre 
Signed-off-by: Dave Hansen 
Reviewed-by: Jarkko Sakkinen 
Acked-by: Dave Hansen 
Link: https://lkml.kernel.org/r/ca0f8a81fc1e78af9bdbc6a88e0f9c37d82e53f2.1636997631.git.reinette.chatre@intel.com