linux-toradex.git/virt/kvm/iommu.c, branch v3.0.98

KVM: unmap pages from the iommu when slots are removed

2012-05-07T15:56:35+00:00

commit 32f6daad4651a748a58a3ab6da0611862175722f upstream.

We've been adding new mappings, but not destroying old mappings.
This can lead to a page leak as pages are pinned using
get_user_pages, but only unpinned with put_page if they still
exist in the memslots list on vm shutdown.  A memslot that is
destroyed while an iommu domain is enabled for the guest will
therefore result in an elevated page reference count that is
never cleared.

Additionally, without this fix, the iommu is only programmed
with the first translation for a gpa.  This can result in
peer-to-peer errors if a mapping is destroyed and replaced by a
new mapping at the same gpa as the iommu will still be pointing
to the original, pinned memory address.

Signed-off-by: Alex Williamson 
Signed-off-by: Marcelo Tosatti 
Signed-off-by: Jonathan Nieder 
Signed-off-by: Greg Kroah-Hartman

KVM: Use u64 for frame data types

2010-08-02T03:39:44+00:00

For 32bit machines where the physical address width is
larger than the virtual address width the frame number types
in KVM may overflow. Fix this by changing them to u64.

[sfr: fix build on 32-bit ppc]

Signed-off-by: Joerg Roedel 
Signed-off-by: Stephen Rothwell 
Signed-off-by: Marcelo Tosatti

KVM: Fix IOMMU memslot reference warning

2010-08-01T07:47:29+00:00

This patch fixes the following warning.

===================================================
[ INFO: suspicious rcu_dereference_check() usage. ]
---------------------------------------------------
include/linux/kvm_host.h:259 invoked rcu_dereference_check() without
protection!

other info that might help us debug this:

rcu_scheduler_active = 1, debug_locks = 0
no locks held by qemu-system-x86/29679.

stack backtrace:
Pid: 29679, comm: qemu-system-x86 Not tainted 2.6.35-rc3+ #200
Call Trace:
 [] lockdep_rcu_dereference+0xa8/0xb1
 [] kvm_iommu_unmap_memslots+0xc9/0xde [kvm]
 [] kvm_iommu_unmap_guest+0x40/0x4e [kvm]
 [] kvm_arch_destroy_vm+0x1a/0x186 [kvm]
 [] kvm_put_kvm+0x110/0x167 [kvm]
 [] kvm_vcpu_release+0x18/0x1c [kvm]
 [] fput+0x22a/0x3a0
 [] filp_close+0xb4/0xcd
 [] put_files_struct+0x1b7/0x36b
 [] ? put_files_struct+0x48/0x36b
 [] ? do_raw_spin_unlock+0x118/0x160
 [] exit_files+0x6d/0x75
 [] do_exit+0x47d/0xc60
 [] ? _raw_spin_unlock_irq+0x30/0x36
 [] do_group_exit+0xcf/0x134
 [] get_signal_to_deliver+0x732/0x81d
 [] ? cpu_clock+0x4e/0x60
 [] do_notify_resume+0x117/0xc43
 [] ? trace_hardirqs_on+0xd/0xf
 [] ? sys_rt_sigtimedwait+0x2b5/0x3bf
 [] ? trace_hardirqs_off_thunk+0x3a/0x3c
 [] ? sysret_signal+0x5/0x3d
 [] int_signal+0x12/0x17

Signed-off-by: Sheng Yang 
Signed-off-by: Marcelo Tosatti

KVM: Update Red Hat copyrights

2010-08-01T07:35:51+00:00

Signed-off-by: Avi Kivity

KVM: Fix order passed to iommu_unmap

2010-06-09T15:48:38+00:00

This is obviously a left-over from the the old interface taking the
size. Apparently a mostly harmless issue with the current iommu_unmap
implementation.

Signed-off-by: Jan Kiszka 
Acked-by: Joerg Roedel 
Signed-off-by: Avi Kivity

Merge branch 'kvm-updates/2.6.35' of git://git.kernel.org/pub/scm/virt/kvm/kvm

2010-05-22T00:16:21+00:00

* 'kvm-updates/2.6.35' of git://git.kernel.org/pub/scm/virt/kvm/kvm: (269 commits)
  KVM: x86: Add missing locking to arch specific vcpu ioctls
  KVM: PPC: Add missing vcpu_load()/vcpu_put() in vcpu ioctls
  KVM: MMU: Segregate shadow pages with different cr0.wp
  KVM: x86: Check LMA bit before set_efer
  KVM: Don't allow lmsw to clear cr0.pe
  KVM: Add cpuid.txt file
  KVM: x86: Tell the guest we'll warn it about tsc stability
  x86, paravirt: don't compute pvclock adjustments if we trust the tsc
  x86: KVM guest: Try using new kvm clock msrs
  KVM: x86: export paravirtual cpuid flags in KVM_GET_SUPPORTED_CPUID
  KVM: x86: add new KVMCLOCK cpuid feature
  KVM: x86: change msr numbers for kvmclock
  x86, paravirt: Add a global synchronization point for pvclock
  x86, paravirt: Enable pvclock flags in vcpu_time_info structure
  KVM: x86: Inject #GP with the right rip on efer writes
  KVM: SVM: Don't allow nested guest to VMMCALL into host
  KVM: x86: Fix exception reinjection forced to true
  KVM: Fix wallclock version writing race
  KVM: MMU: Don't read pdptrs with mmu spinlock held in mmu_alloc_roots
  KVM: VMX: enable VMXON check with SMX enabled (Intel TXT)
  ...

KVM: use the correct RCU API for PROVE_RCU=y

2010-05-17T09:18:01+00:00

The RCU/SRCU API have already changed for proving RCU usage.

I got the following dmesg when PROVE_RCU=y because we used incorrect API.
This patch coverts rcu_deference() to srcu_dereference() or family API.

===================================================
[ INFO: suspicious rcu_dereference_check() usage. ]
---------------------------------------------------
arch/x86/kvm/mmu.c:3020 invoked rcu_dereference_check() without protection!

other info that might help us debug this:

rcu_scheduler_active = 1, debug_locks = 0
2 locks held by qemu-system-x86/8550:
 #0:  (&kvm->slots_lock){+.+.+.}, at: [] kvm_set_memory_region+0x29/0x50 [kvm]
 #1:  (&(&kvm->mmu_lock)->rlock){+.+...}, at: [] kvm_arch_commit_memory_region+0xa6/0xe2 [kvm]

stack backtrace:
Pid: 8550, comm: qemu-system-x86 Not tainted 2.6.34-rc4-tip-01028-g939eab1 #27
Call Trace:
 [] lockdep_rcu_dereference+0xaa/0xb3
 [] kvm_mmu_calculate_mmu_pages+0x44/0x7d [kvm]
 [] kvm_arch_commit_memory_region+0xb7/0xe2 [kvm]
 [] __kvm_set_memory_region+0x636/0x6e2 [kvm]
 [] kvm_set_memory_region+0x37/0x50 [kvm]
 [] vmx_set_tss_addr+0x46/0x5a [kvm_intel]
 [] kvm_arch_vm_ioctl+0x17a/0xcf8 [kvm]
 [] ? unlock_page+0x27/0x2c
 [] ? __do_fault+0x3a9/0x3e1
 [] kvm_vm_ioctl+0x364/0x38d [kvm]
 [] ? up_read+0x23/0x3d
 [] vfs_ioctl+0x32/0xa6
 [] do_vfs_ioctl+0x495/0x4db
 [] ? fget_light+0xc2/0x241
 [] ? do_sys_open+0x104/0x116
 [] ? retint_swapgs+0xe/0x13
 [] sys_ioctl+0x47/0x6a
 [] system_call_fastpath+0x16/0x1b

Signed-off-by: Lai Jiangshan 
Signed-off-by: Avi Kivity

kvm: Change kvm_iommu_map_pages to map large pages

2010-03-07T17:01:11+00:00

This patch changes the implementation of of
kvm_iommu_map_pages to map the pages with the host page size
into the io virtual address space.

Signed-off-by: Joerg Roedel 
Acked-By: Avi Kivity

KVM: enable PCI multiple-segments for pass-through device

2010-03-01T15:36:06+00:00

Enable optional parameter (default 0) - PCI segment (or domain) besides
BDF, when assigning PCI device to guest.

Signed-off-by: Zhai Edwin 
Acked-by: Chris Wright 
Signed-off-by: Marcelo Tosatti

KVM: introduce kvm->srcu and convert kvm_set_memory_region to SRCU update

2010-03-01T15:35:44+00:00

Use two steps for memslot deletion: mark the slot invalid (which stops
instantiation of new shadow pages for that slot, but allows destruction),
then instantiate the new empty slot.

Also simplifies kvm_handle_hva locking.

Signed-off-by: Marcelo Tosatti