linux-toradex.git/virt, branch v2.6.35-rc6

KVM: read apic->irr with ioapic lock held

2010-06-10T17:29:03+00:00

Read ioapic->irr inside ioapic->lock protected section.

KVM-Stable-Tag
Signed-off-by: Marcelo Tosatti

KVM: Fix order passed to iommu_unmap

2010-06-09T15:48:38+00:00

This is obviously a left-over from the the old interface taking the
size. Apparently a mostly harmless issue with the current iommu_unmap
implementation.

Signed-off-by: Jan Kiszka 
Acked-by: Joerg Roedel 
Signed-off-by: Avi Kivity

Merge branch 'kvm-updates/2.6.35' of git://git.kernel.org/pub/scm/virt/kvm/kvm

2010-05-22T00:16:21+00:00

* 'kvm-updates/2.6.35' of git://git.kernel.org/pub/scm/virt/kvm/kvm: (269 commits)
  KVM: x86: Add missing locking to arch specific vcpu ioctls
  KVM: PPC: Add missing vcpu_load()/vcpu_put() in vcpu ioctls
  KVM: MMU: Segregate shadow pages with different cr0.wp
  KVM: x86: Check LMA bit before set_efer
  KVM: Don't allow lmsw to clear cr0.pe
  KVM: Add cpuid.txt file
  KVM: x86: Tell the guest we'll warn it about tsc stability
  x86, paravirt: don't compute pvclock adjustments if we trust the tsc
  x86: KVM guest: Try using new kvm clock msrs
  KVM: x86: export paravirtual cpuid flags in KVM_GET_SUPPORTED_CPUID
  KVM: x86: add new KVMCLOCK cpuid feature
  KVM: x86: change msr numbers for kvmclock
  x86, paravirt: Add a global synchronization point for pvclock
  x86, paravirt: Enable pvclock flags in vcpu_time_info structure
  KVM: x86: Inject #GP with the right rip on efer writes
  KVM: SVM: Don't allow nested guest to VMMCALL into host
  KVM: x86: Fix exception reinjection forced to true
  KVM: Fix wallclock version writing race
  KVM: MMU: Don't read pdptrs with mmu spinlock held in mmu_alloc_roots
  KVM: VMX: enable VMXON check with SMX enabled (Intel TXT)
  ...

KVM: Let vcpu structure alignment be determined at runtime

2010-05-19T08:36:29+00:00

vmx and svm vcpus have different contents and therefore may have different
alignmment requirements.  Let each specify its required alignment.

Signed-off-by: Avi Kivity

Merge branch 'core-iommu-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip

2010-05-18T14:22:37+00:00

* 'core-iommu-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip:
  x86/amd-iommu: Add amd_iommu=off command line option
  iommu-api: Remove iommu_{un}map_range functions
  x86/amd-iommu: Implement ->{un}map callbacks for iommu-api
  x86/amd-iommu: Make amd_iommu_iova_to_phys aware of multiple page sizes
  x86/amd-iommu: Make iommu_unmap_page and fetch_pte aware of page sizes
  x86/amd-iommu: Make iommu_map_page and alloc_pte aware of page sizes
  kvm: Change kvm_iommu_map_pages to map large pages
  VT-d: Change {un}map_range functions to implement {un}map interface
  iommu-api: Add ->{un}map callbacks to iommu_ops
  iommu-api: Add iommu_map and iommu_unmap functions
  iommu-api: Rename ->{un}map function pointers to ->{un}map_range

KVM: Remove test-before-set optimization for dirty bits

2010-05-17T09:19:13+00:00

As Avi pointed out, testing bit part in mark_page_dirty() was important
in the days of shadow paging, but currently EPT and NPT has already become
common and the chance of faulting a page more that once per iteration is
small. So let's remove the test bit to avoid extra access.

Signed-off-by: Takuya Yoshikawa 
Signed-off-by: Avi Kivity

KVM: do not call hardware_disable() on CPU_UP_CANCELED

2010-05-17T09:18:04+00:00

When CPU_UP_CANCELED, hardware_enable() has not been called at the CPU
which is going up because raw_notifier_call_chain(CPU_ONLINE)
has not been called for this cpu.

Drop the handling for CPU_UP_CANCELED.

Signed-off-by: Lai Jiangshan 
Signed-off-by: Avi Kivity

KVM: use the correct RCU API for PROVE_RCU=y

2010-05-17T09:18:01+00:00

The RCU/SRCU API have already changed for proving RCU usage.

I got the following dmesg when PROVE_RCU=y because we used incorrect API.
This patch coverts rcu_deference() to srcu_dereference() or family API.

===================================================
[ INFO: suspicious rcu_dereference_check() usage. ]
---------------------------------------------------
arch/x86/kvm/mmu.c:3020 invoked rcu_dereference_check() without protection!

other info that might help us debug this:

rcu_scheduler_active = 1, debug_locks = 0
2 locks held by qemu-system-x86/8550:
 #0:  (&kvm->slots_lock){+.+.+.}, at: [] kvm_set_memory_region+0x29/0x50 [kvm]
 #1:  (&(&kvm->mmu_lock)->rlock){+.+...}, at: [] kvm_arch_commit_memory_region+0xa6/0xe2 [kvm]

stack backtrace:
Pid: 8550, comm: qemu-system-x86 Not tainted 2.6.34-rc4-tip-01028-g939eab1 #27
Call Trace:
 [] lockdep_rcu_dereference+0xaa/0xb3
 [] kvm_mmu_calculate_mmu_pages+0x44/0x7d [kvm]
 [] kvm_arch_commit_memory_region+0xb7/0xe2 [kvm]
 [] __kvm_set_memory_region+0x636/0x6e2 [kvm]
 [] kvm_set_memory_region+0x37/0x50 [kvm]
 [] vmx_set_tss_addr+0x46/0x5a [kvm_intel]
 [] kvm_arch_vm_ioctl+0x17a/0xcf8 [kvm]
 [] ? unlock_page+0x27/0x2c
 [] ? __do_fault+0x3a9/0x3e1
 [] kvm_vm_ioctl+0x364/0x38d [kvm]
 [] ? up_read+0x23/0x3d
 [] vfs_ioctl+0x32/0xa6
 [] do_vfs_ioctl+0x495/0x4db
 [] ? fget_light+0xc2/0x241
 [] ? do_sys_open+0x104/0x116
 [] ? retint_swapgs+0xe/0x13
 [] sys_ioctl+0x47/0x6a
 [] system_call_fastpath+0x16/0x1b

Signed-off-by: Lai Jiangshan 
Signed-off-by: Avi Kivity

KVM: limit the number of pages per memory slot

2010-05-17T09:17:41+00:00

This patch limits the number of pages per memory slot to make
us free from extra care about type issues.

Signed-off-by: Takuya Yoshikawa 
Signed-off-by: Marcelo Tosatti

KVM: coalesced_mmio: fix kvm_coalesced_mmio_init()'s error handling

2010-05-17T09:15:53+00:00

kvm_coalesced_mmio_init() keeps to hold the addresses of a coalesced
mmio ring page and dev even after it has freed them.

Also, if this function fails, though it might be rare, it seems to be
suggesting the system's serious state: so we'd better stop the works
following the kvm_creat_vm().

This patch clears these problems.

  We move the coalesced mmio's initialization out of kvm_create_vm().
  This seems to be natural because it includes a registration which
  can be done only when vm is successfully created.

Signed-off-by: Takuya Yoshikawa 
Signed-off-by: Marcelo Tosatti