diff options
author | Alexandre Belloni <alexandre.belloni@bootlin.com> | 2018-09-09 22:48:58 +0200 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2018-11-13 11:15:00 -0800 |
commit | 64b48a5cbea969bb7bd2f779dab52c2753c44e46 (patch) | |
tree | 157e7eba55b4dc303060bfc9f09f6235fa83ccc8 /.mailmap | |
parent | 06bd97b79584764d3ff4dbd42d4ca87d2cbe5a46 (diff) |
mfd: menelaus: Fix possible race condition and leak
[ Upstream commit 9612f8f503804d2fd2f63aa6ba1e58bba4612d96 ]
The IRQ work is added before the struct rtc is allocated and registered,
but this struct is used in the IRQ handler. This may lead to a NULL pointer
dereference.
Switch to devm_rtc_allocate_device/rtc_register_device to allocate the rtc
before calling menelaus_add_irq_work.
Also, this solves a possible leak as the RTC is never released.
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to '.mailmap')
0 files changed, 0 insertions, 0 deletions