diff options
| author | Len Brown <len.brown@intel.com> | 2010-10-15 20:43:06 -0400 |
|---|---|---|
| committer | Len Brown <len.brown@intel.com> | 2010-10-15 20:43:06 -0400 |
| commit | c8381cc3d8a9cc6c80f65bf60863c776651f245c (patch) | |
| tree | 6951487ec3a4745f24c8b0d7c98db8963e0da4c7 | |
| parent | cd07202cc8262e1669edff0d97715f3dd9260917 (diff) | |
intel_idle: simplify test for leave_mm()
A run-time test to invoke leave_mm() for the deepest
supported C-state is redundant, since the appropriate
C-states already have flags with CPUIDLE_FLAG_TLB_FLUSHED set.
Signed-off-by: Len Brown <len.brown@intel.com>
| -rw-r--r-- | drivers/idle/intel_idle.c | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/drivers/idle/intel_idle.c b/drivers/idle/intel_idle.c index c37ef64d1465..ad0fb0182b4c 100644 --- a/drivers/idle/intel_idle.c +++ b/drivers/idle/intel_idle.c @@ -186,13 +186,10 @@ static int intel_idle(struct cpuidle_device *dev, struct cpuidle_state *state) local_irq_disable(); /* - * If the state flag indicates that the TLB will be flushed or if this - * is the deepest c-state supported, do a voluntary leave mm to avoid - * costly and mostly unnecessary wakeups for flushing the user TLB's - * associated with the active mm. + * leave_mm() to avoid costly and often unnecessary wakeups + * for flushing the user TLB's associated with the active mm. */ - if (state->flags & CPUIDLE_FLAG_TLB_FLUSHED || - (&dev->states[dev->state_count - 1] == state)) + if (state->flags & CPUIDLE_FLAG_TLB_FLUSHED) leave_mm(cpu); if (!(lapic_timer_reliable_states & (1 << (cstate)))) |