diff options
| author | Laxman Dewangan <ldewangan@nvidia.com> | 2012-04-06 18:47:06 +0530 |
|---|---|---|
| committer | Simone Willett <swillett@nvidia.com> | 2012-04-10 11:22:20 -0700 |
| commit | 91edeaacfe448d6bdc65b40c8061a564521695fb (patch) | |
| tree | 5271e42baecda649a2f1dec8da673f5da083da99 | |
| parent | 6f10d632962c6faa76cbd092b530ff2b08d79e98 (diff) | |
video: tegra: dtv: Remove check for dma req list before cancelling
Removing the checking whether dma req queue is empty or not
before canceling/stopping dma.
This function cannot guarantee correct result as there may be the
race between hw and sw status update.
If client wants to cancel dma req, it can directly call tegra_dma_cancel().
As the function tegra_dma_is_empty() does not return correct result,
it will be depreciated from the dma apis.
Change-Id: I3f5ebee8a7be345b02fcd8a69530c9b53207ef28
Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
Reviewed-on: http://git-master/r/95090
Reviewed-by: Automatic_Commit_Validation_User
Reviewed-by: Bitan Biswas <bbiswas@nvidia.com>
| -rw-r--r-- | drivers/media/video/tegra/tegra_dtv.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/media/video/tegra/tegra_dtv.c b/drivers/media/video/tegra/tegra_dtv.c index 95270c4c3be0..8a53930aec7a 100644 --- a/drivers/media/video/tegra/tegra_dtv.c +++ b/drivers/media/video/tegra/tegra_dtv.c @@ -390,9 +390,6 @@ static void __force_xfer_stop(struct dtv_stream *s) } } - /* just in case. dma should be cancelled before this */ - if (!tegra_dma_is_empty(s->dma_chan)) - pr_err("%s: DMA channel is not empty!\n", __func__); tegra_dma_cancel(s->dma_chan); s->xferring = false; |