summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGreg Rose <gregory.v.rose@intel.com>2012-10-30 00:40:02 +0000
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>2012-10-29 22:16:44 -0700
commita30134053c3c4a14049037ee41b74ab3fe57cf9e (patch)
tree2cfdb7d6c9f786975d6232f944049277ee84be55
parentd7bbcd32adafee94e965d9ca188ddeede4c94597 (diff)
ixgbe: Fix return value from macvlan filter function
The function to set the macvlan filter should return success or failure instead of the index of the filter. The message processing function was misinterpreting the index as a non-zero return code indicating failure and NACKing MAC filter set messages that actually succeeded. Signed-off-by: Greg Rose <gregory.v.rose@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
-rw-r--r--drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c
index 96876b7442b1..8bdb341c14bf 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c
@@ -742,7 +742,8 @@ static int ixgbe_set_vf_macvlan_msg(struct ixgbe_adapter *adapter,
e_warn(drv,
"VF %d has requested a MACVLAN filter but there is no space for it\n",
vf);
- return err;
+
+ return err < 0;
}
static int ixgbe_negotiate_vf_api(struct ixgbe_adapter *adapter,