diff options
| author | Miklos Szeredi <mszeredi@suse.cz> | 2014-04-07 15:37:51 -0700 |
|---|---|---|
| committer | Ben Hutchings <ben@decadent.org.uk> | 2015-02-20 00:49:35 +0000 |
| commit | 57b31943b128c88c591005f122005c033e5d6409 (patch) | |
| tree | a2a085e886a13f1210eb14057ff40aaa1132910d | |
| parent | 1d61507ce4a5642f3c5de0e14227fd182985613a (diff) | |
mm: remove unused arg of set_page_dirty_balance()
commit ed6d7c8e578331cad594ee70d60e2e146b5dce7b upstream.
There's only one caller of set_page_dirty_balance() and that will call it
with page_mkwrite == 0.
The page_mkwrite argument was unused since commit b827e496c893 "mm: close
page_mkwrite races".
Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
[bwh: Backported to 3.2: adjust context]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
| -rw-r--r-- | include/linux/writeback.h | 2 | ||||
| -rw-r--r-- | mm/memory.c | 2 | ||||
| -rw-r--r-- | mm/page-writeback.c | 4 |
3 files changed, 4 insertions, 4 deletions
diff --git a/include/linux/writeback.h b/include/linux/writeback.h index 7e85d454c163..bd214aebf86d 100644 --- a/include/linux/writeback.h +++ b/include/linux/writeback.h @@ -190,7 +190,7 @@ int write_cache_pages(struct address_space *mapping, struct writeback_control *wbc, writepage_t writepage, void *data); int do_writepages(struct address_space *mapping, struct writeback_control *wbc); -void set_page_dirty_balance(struct page *page, int page_mkwrite); +void set_page_dirty_balance(struct page *page); void writeback_set_ratelimit(void); void tag_pages_for_writeback(struct address_space *mapping, pgoff_t start, pgoff_t end); diff --git a/mm/memory.c b/mm/memory.c index e714317fd513..fb55a9755a02 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -2671,7 +2671,7 @@ reuse: */ if (!page_mkwrite) { wait_on_page_locked(dirty_page); - set_page_dirty_balance(dirty_page, page_mkwrite); + set_page_dirty_balance(dirty_page); } put_page(dirty_page); if (page_mkwrite) { diff --git a/mm/page-writeback.c b/mm/page-writeback.c index d2ac057008f2..cab99e82b830 100644 --- a/mm/page-writeback.c +++ b/mm/page-writeback.c @@ -1202,9 +1202,9 @@ pause: bdi_start_background_writeback(bdi); } -void set_page_dirty_balance(struct page *page, int page_mkwrite) +void set_page_dirty_balance(struct page *page) { - if (set_page_dirty(page) || page_mkwrite) { + if (set_page_dirty(page)) { struct address_space *mapping = page_mapping(page); if (mapping) |