summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKrishna Reddy <vdumpa@nvidia.com>2011-08-30 10:15:44 -0700
committerVarun Colbert <vcolbert@nvidia.com>2011-11-15 11:42:59 -0800
commit975fb95585543124de282faa4481433b147f61c6 (patch)
treeb81ea9a60b6d21c903e6cc9bc4b613df216ff04d
parentfcb73f5a9fcdd61f8df2e5f85df6a9fe052eea90 (diff)
video: tegra: nvmap: Update page attributes as per request.
After allocating pages, Update page attributes in kernel page table as per mem type requested. Bug 865816 Reviewed-on: http://git-master/r/56334 Reviewed-by: Lokesh Pathak <lpathak@nvidia.com> Tested-by: Lokesh Pathak <lpathak@nvidia.com> (cherry picked from commit bea4d449f4ff7090e0c2797693d2348f4586d8f6) Change-Id: Ic1fe862412c09f57d1dbf05a1da98fd22d0d49a4 Reviewed-on: http://git-master/r/62720 Tested-by: Krishna Reddy <vdumpa@nvidia.com> Reviewed-by: Hiro Sugawara <hsugawara@nvidia.com> Reviewed-by: Kaz Fukuoka <kfukuoka@nvidia.com> Reviewed-by: Krishna Reddy <vdumpa@nvidia.com>
-rw-r--r--drivers/video/tegra/nvmap/nvmap_handle.c31
-rw-r--r--drivers/video/tegra/nvmap/nvmap_ioctl.c18
2 files changed, 33 insertions, 16 deletions
diff --git a/drivers/video/tegra/nvmap/nvmap_handle.c b/drivers/video/tegra/nvmap/nvmap_handle.c
index 5bb57362b0b5..47c829523ae2 100644
--- a/drivers/video/tegra/nvmap/nvmap_handle.c
+++ b/drivers/video/tegra/nvmap/nvmap_handle.c
@@ -105,6 +105,12 @@ void _nvmap_handle_free(struct nvmap_handle *h)
nvmap_mru_remove(nvmap_get_share_from_dev(dev), h);
+ // Restore page attributes.
+ if (h->flags == NVMAP_HANDLE_WRITE_COMBINE ||
+ h->flags == NVMAP_HANDLE_UNCACHEABLE ||
+ h->flags == NVMAP_HANDLE_INNER_CACHEABLE)
+ set_pages_array_wb(h->pgalloc.pages, nr_page);
+
if (h->pgalloc.area)
tegra_iovmm_free_vm(h->pgalloc.area);
@@ -147,7 +153,6 @@ static int handle_page_alloc(struct nvmap_client *client,
pgprot_t prot;
unsigned int i = 0;
struct page **pages;
- bool flush_inner = true;
unsigned long base;
pages = altalloc(nr_page * sizeof(*pages));
@@ -190,18 +195,26 @@ static int handle_page_alloc(struct nvmap_client *client,
#endif
}
- /* Flush the cache for allocated pages*/
- if (size >= FLUSH_CLEAN_BY_SET_WAY_THRESHOLD) {
- inner_flush_cache_all();
- flush_inner = false;
- }
+ // Update the pages mapping in kernel page table.
+ if (h->flags == NVMAP_HANDLE_WRITE_COMBINE)
+ set_pages_array_wc(pages, nr_page);
+ else if (h->flags == NVMAP_HANDLE_UNCACHEABLE)
+ set_pages_array_uc(pages, nr_page);
+ else if (h->flags == NVMAP_HANDLE_INNER_CACHEABLE)
+ set_pages_array_iwb(pages, nr_page);
+ else
+ goto skip_cache_flush;
+
+ /* Flush the cache for allocated high mem pages only */
for (i = 0; i < nr_page; i++) {
- if (flush_inner)
+ if (PageHighMem(pages[i])) {
__flush_dcache_page(page_mapping(pages[i]), pages[i]);
- base = page_to_phys(pages[i]);
- outer_flush_range(base, base + PAGE_SIZE);
+ base = page_to_phys(pages[i]);
+ outer_flush_range(base, base + PAGE_SIZE);
+ }
}
+skip_cache_flush:
h->size = size;
h->pgalloc.pages = pages;
h->pgalloc.contig = contiguous;
diff --git a/drivers/video/tegra/nvmap/nvmap_ioctl.c b/drivers/video/tegra/nvmap/nvmap_ioctl.c
index 44cd7b72fe27..1ab5c068fbda 100644
--- a/drivers/video/tegra/nvmap/nvmap_ioctl.c
+++ b/drivers/video/tegra/nvmap/nvmap_ioctl.c
@@ -295,17 +295,24 @@ int nvmap_map_into_caller_ptr(struct file *filp, void __user *arg)
vpriv->offs = op.offset;
cache_flags = op.flags & NVMAP_HANDLE_CACHE_FLAG;
- if (cache_flags == NVMAP_HANDLE_INNER_CACHEABLE ||
- cache_flags == NVMAP_HANDLE_CACHEABLE) {
+ if ((cache_flags == NVMAP_HANDLE_INNER_CACHEABLE ||
+ cache_flags == NVMAP_HANDLE_CACHEABLE) &&
+ (h->flags == NVMAP_HANDLE_UNCACHEABLE ||
+ h->flags == NVMAP_HANDLE_WRITE_COMBINE)) {
if (h->size & ~PAGE_MASK) {
pr_err("\n%s:attempt to convert a buffer from uc/wc to"
" wb, whose size is not a multiple of page size."
" request ignored.\n", __func__);
} else {
+ unsigned int nr_page = h->size >> PAGE_SHIFT;
wmb();
/* override allocation time cache coherency attributes. */
h->flags &= ~NVMAP_HANDLE_CACHE_FLAG;
h->flags |= cache_flags;
+ if (cache_flags == NVMAP_HANDLE_INNER_CACHEABLE)
+ set_pages_array_iwb(h->pgalloc.pages, nr_page);
+ else
+ set_pages_array_wb(h->pgalloc.pages, nr_page);
}
}
vma->vm_page_prot = nvmap_pgprot(h, vma->vm_page_prot);
@@ -582,11 +589,8 @@ static int cache_maint(struct nvmap_client *client, struct nvmap_handle *h,
}
wmb();
-#if defined(CONFIG_ARCH_TEGRA_2x_SOC)
- if (h->flags == NVMAP_HANDLE_WRITE_COMBINE)
- goto out;
-#endif
- if (h->flags == NVMAP_HANDLE_UNCACHEABLE || start == end)
+ if (h->flags == NVMAP_HANDLE_UNCACHEABLE ||
+ h->flags == NVMAP_HANDLE_WRITE_COMBINE || start == end)
goto out;
if (fast_cache_maint(client, h, start, end, op))