diff options
| author | Andreas Gruenbacher <agruenba@redhat.com> | 2017-03-06 12:58:42 -0500 |
|---|---|---|
| committer | Bob Peterson <rpeterso@redhat.com> | 2017-03-15 10:06:07 -0400 |
| commit | 28ea06c46fbcab63fd9a55531387b7928a18a590 (patch) | |
| tree | 30fcea8bf23bdcfb8a4edc082900c6eed2903900 | |
| parent | ae50dfd61665086e617cc9e554a1285d52765670 (diff) | |
gfs2: Avoid alignment hole in struct lm_lockname
Commit 88ffbf3e03 switches to using rhashtables for glocks, hashing over
the entire struct lm_lockname instead of its individual fields. On some
architectures, struct lm_lockname contains a hole of uninitialized
memory due to alignment rules, which now leads to incorrect hash values.
Get rid of that hole.
Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
Signed-off-by: Bob Peterson <rpeterso@redhat.com>
CC: <stable@vger.kernel.org> #v4.3+
| -rw-r--r-- | fs/gfs2/incore.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/gfs2/incore.h b/fs/gfs2/incore.h index c45084ac642d..511e1ed7e2de 100644 --- a/fs/gfs2/incore.h +++ b/fs/gfs2/incore.h @@ -207,7 +207,7 @@ struct lm_lockname { struct gfs2_sbd *ln_sbd; u64 ln_number; unsigned int ln_type; -}; +} __packed __aligned(sizeof(int)); #define lm_name_equal(name1, name2) \ (((name1)->ln_number == (name2)->ln_number) && \ |