diff options
| author | Xiao Ni <xni@redhat.com> | 2019-03-08 23:52:05 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-03-19 13:11:56 +0100 |
| commit | 41ded4f889a9e4e2cd04b5f7263501e3ec308bcb (patch) | |
| tree | 271186bace08bd4fd026f85117dad5d7ecaf0c83 | |
| parent | e1db25f1f8b2b8c655b10c3b65abb4ba366d64d1 (diff) | |
It's wrong to add len to sector_nr in raid10 reshape twice
commit b761dcf1217760a42f7897c31dcb649f59b2333e upstream.
In reshape_request it already adds len to sector_nr already. It's wrong to add len to
sector_nr again after adding pages to bio. If there is bad block it can't copy one chunk
at a time, it needs to goto read_more. Now the sector_nr is wrong. It can cause data
corruption.
Cc: stable@vger.kernel.org # v3.16+
Signed-off-by: Xiao Ni <xni@redhat.com>
Signed-off-by: Song Liu <songliubraving@fb.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/md/raid10.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c index 12cf8a04e839..100895695471 100644 --- a/drivers/md/raid10.c +++ b/drivers/md/raid10.c @@ -4692,7 +4692,6 @@ read_more: atomic_inc(&r10_bio->remaining); read_bio->bi_next = NULL; generic_make_request(read_bio); - sector_nr += nr_sectors; sectors_done += nr_sectors; if (sector_nr <= last) goto read_more; |