diff options
| author | Tony Battersby <tonyb@cybernetics.com> | 2015-02-11 11:32:30 -0500 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2015-03-06 14:57:29 -0800 |
| commit | 238ddf7ac40a14b51d8317246263494406d2c6ba (patch) | |
| tree | 95c15cc999c189227064304356a0ffc0d0224d58 | |
| parent | a0a645bf699f808e997fc7caa7cdeb459251bcdf (diff) | |
blk-mq: fix double-free in error path
commit 564e559f2baf6a868768d0cac286980b3cfd6e30 upstream.
If the allocation of bt->bs fails, then bt->map can be freed twice, once
in blk_mq_init_bitmap_tags() -> bt_alloc(), and once in
blk_mq_init_bitmap_tags() -> bt_free(). Fix by setting the pointer to
NULL after the first free.
Signed-off-by: Tony Battersby <tonyb@cybernetics.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | block/blk-mq-tag.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/block/blk-mq-tag.c b/block/blk-mq-tag.c index 60c9d4a93fe4..3a415ecfe3d4 100644 --- a/block/blk-mq-tag.c +++ b/block/blk-mq-tag.c @@ -509,6 +509,7 @@ static int bt_alloc(struct blk_mq_bitmap_tags *bt, unsigned int depth, bt->bs = kzalloc(BT_WAIT_QUEUES * sizeof(*bt->bs), GFP_KERNEL); if (!bt->bs) { kfree(bt->map); + bt->map = NULL; return -ENOMEM; } |