diff options
author | Sascha Hauer <s.hauer@pengutronix.de> | 2014-06-20 15:08:16 +0800 |
---|---|---|
committer | Nitin Garg <nitin.garg@freescale.com> | 2015-01-15 21:17:07 -0600 |
commit | a1ab8904e2dd6c23a96d4c656099e5bce700a62b (patch) | |
tree | e9a6524dbc003fbbd0c00383e8fad1280ec6eb6e | |
parent | 9e2d08e795c84edcd8dc4238fe37bbc1feeb29f8 (diff) |
mmc: Allow setting slot index via devicetree alias
As with gpio, uart and others, allow specifying the name_idx via the
aliases-node in the devicetree.
On embedded devices, there is often a combination of removable (e.g.
SD card) and non-removable mmc devices (e.g. eMMC).
Therefore the name_idx might change depending on
- host of removable device
- removable card present or not
This makes it difficult to hard code the root device, if it is on the
non-removable device. E.g. if SD card is present eMMC will be mmcblk1,
if SD card is not present at boot, eMMC will be mmcblk0.
If the aliases-node is not found, the driver will act as before.
The original patch is from here:
https://www.mail-archive.com/linux-mmc@vger.kernel.org/msg26472.html
The patch requires additional alias_id fix or it won't work.
Because according to function definition the max_idx parameter of idx_alloc
is exclusive, so need add 1 or it will be unable to find the proper idx
within an invalid range.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Signed-off-by: Dong Aisheng <b29396@freescale.com>
(cherry picked from commit 35928d6c6a76a24a16edfa636f4c08293614a1e0)
-rw-r--r-- | drivers/mmc/card/block.c | 10 | ||||
-rw-r--r-- | drivers/mmc/core/core.c | 38 | ||||
-rw-r--r-- | drivers/mmc/core/host.c | 17 | ||||
-rw-r--r-- | include/linux/mmc/core.h | 3 |
4 files changed, 65 insertions, 3 deletions
diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c index df72c478c5a2..8c7923518f13 100644 --- a/drivers/mmc/card/block.c +++ b/drivers/mmc/card/block.c @@ -2045,7 +2045,15 @@ static struct mmc_blk_data *mmc_blk_alloc_req(struct mmc_card *card, * index anymore so we keep track of a name index. */ if (!subname) { - md->name_idx = find_first_zero_bit(name_use, max_devices); + int idx; + + idx = mmc_get_reserved_index(card->host); + if (idx >= 0 && !test_bit(idx, name_use)) + md->name_idx = idx; + else + md->name_idx = find_next_zero_bit(name_use, max_devices, + mmc_first_nonreserved_index()); + __set_bit(md->name_idx, name_use); } else md->name_idx = ((struct mmc_blk_data *) diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c index 098374b1ab2b..e65a857b8186 100644 --- a/drivers/mmc/core/core.c +++ b/drivers/mmc/core/core.c @@ -16,6 +16,7 @@ #include <linux/completion.h> #include <linux/device.h> #include <linux/delay.h> +#include <linux/of.h> #include <linux/pagemap.h> #include <linux/err.h> #include <linux/leds.h> @@ -2712,6 +2713,41 @@ void mmc_init_context_info(struct mmc_host *host) init_waitqueue_head(&host->context_info.wait); } +static int __mmc_max_reserved_idx = -1; + +/** + * mmc_first_nonreserved_index() - get the first index that is not reserved + */ +int mmc_first_nonreserved_index(void) +{ + return __mmc_max_reserved_idx + 1; +} + +/** + * mmc_get_reserved_index() - get the index reserved for this host + * + * Return: The index reserved for this host or negative error value if + * no index is reserved for this host + */ +int mmc_get_reserved_index(struct mmc_host *host) +{ + return of_alias_get_id(host->parent->of_node, "mmc"); +} + +static void mmc_of_reserve_idx(void) +{ + int max; + + max = of_alias_max_index("mmc"); + if (max < 0) + return; + + __mmc_max_reserved_idx = max; + + pr_debug("MMC: reserving %d slots for of aliases\n", + __mmc_max_reserved_idx + 1); +} + static int __init mmc_init(void) { int ret; @@ -2720,6 +2756,8 @@ static int __init mmc_init(void) if (!workqueue) return -ENOMEM; + mmc_of_reserve_idx(); + ret = mmc_register_bus(); if (ret) goto destroy_workqueue; diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c index 49bc403e31f0..b7079afc1ad5 100644 --- a/drivers/mmc/core/host.c +++ b/drivers/mmc/core/host.c @@ -439,6 +439,8 @@ out: EXPORT_SYMBOL(mmc_of_parse); +int mmc_max_reserved_idx(void); + /** * mmc_alloc_host - initialise the per-host structure. * @extra: sizeof private data structure @@ -450,6 +452,7 @@ struct mmc_host *mmc_alloc_host(int extra, struct device *dev) { int err; struct mmc_host *host; + int alias_id, min_idx, max_idx; host = kzalloc(sizeof(struct mmc_host) + extra, GFP_KERNEL); if (!host) @@ -459,7 +462,18 @@ struct mmc_host *mmc_alloc_host(int extra, struct device *dev) host->rescan_disable = 1; idr_preload(GFP_KERNEL); spin_lock(&mmc_host_lock); - err = idr_alloc(&mmc_host_idr, host, 0, 0, GFP_NOWAIT); + + host->parent = dev; + alias_id = mmc_get_reserved_index(host); + if (alias_id >= 0) { + min_idx = alias_id; + max_idx = alias_id + 1; + } else { + min_idx = mmc_first_nonreserved_index(); + max_idx = 0; + } + + err = idr_alloc(&mmc_host_idr, host, min_idx, max_idx, GFP_NOWAIT); if (err >= 0) host->index = err; spin_unlock(&mmc_host_lock); @@ -469,7 +483,6 @@ struct mmc_host *mmc_alloc_host(int extra, struct device *dev) dev_set_name(&host->class_dev, "mmc%d", host->index); - host->parent = dev; host->class_dev.parent = dev; host->class_dev.class = &mmc_host_class; device_initialize(&host->class_dev); diff --git a/include/linux/mmc/core.h b/include/linux/mmc/core.h index 87079fc38011..96fb4f244ca6 100644 --- a/include/linux/mmc/core.h +++ b/include/linux/mmc/core.h @@ -197,6 +197,9 @@ extern int mmc_flush_cache(struct mmc_card *); extern int mmc_detect_card_removed(struct mmc_host *host); +int mmc_first_nonreserved_index(void); +int mmc_get_reserved_index(struct mmc_host *host); + /** * mmc_claim_host - exclusively claim a host * @host: mmc host to claim |