diff options
| author | Herbert Xu <herbert@gondor.apana.org.au> | 2006-02-04 02:29:45 -0800 |
|---|---|---|
| committer | Chris Wright <chrisw@sous-sol.org> | 2006-02-06 15:36:33 -0800 |
| commit | 6be20a3ccd442701bc271a5ffca3e0084188831b (patch) | |
| tree | 8461805989c0882b6a41789ea2eea36ccdfbcd51 | |
| parent | 2adb99055eda0cd58de6f21796928026c3a4691d (diff) | |
[PATCH] Fix extra dst release when ip_options_echo fails
When two ip_route_output_key lookups in icmp_send were combined I
forgot to change the error path for ip_options_echo to not drop the
dst reference since it now sits before the dst lookup. To fix it we
simply jump past the ip_rt_put call.
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Chris Wright <chrisw@sous-sol.org>
| -rw-r--r-- | net/ipv4/icmp.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv4/icmp.c b/net/ipv4/icmp.c index 92e23b2ad4d2..84de934dd1ed 100644 --- a/net/ipv4/icmp.c +++ b/net/ipv4/icmp.c @@ -524,7 +524,7 @@ void icmp_send(struct sk_buff *skb_in, int type, int code, u32 info) iph->tos; if (ip_options_echo(&icmp_param.replyopts, skb_in)) - goto ende; + goto out_unlock; /* |