summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJason Low <jason.low2@hp.com>2015-02-13 11:58:07 +0800
committerJiri Slaby <jslaby@suse.cz>2015-04-09 13:14:06 +0200
commit90b682b6065978253a1c5ea75b26c44a67e1a38a (patch)
treee5894d056271cb78004663a46e879baca7bfee00
parent97b57f41a0054767b0834ac9b34dfb22a8ee38f4 (diff)
cpuset: Fix cpuset sched_relax_domain_level
commit 283cb41f426b723a0255702b761b0fc5d1b53a81 upstream. The cpuset.sched_relax_domain_level can control how far we do immediate load balancing on a system. However, it was found on recent kernels that echo'ing a value into cpuset.sched_relax_domain_level did not reduce any immediate load balancing. The reason this occurred was because the update_domain_attr_tree() traversal did not update for the "top_cpuset". This resulted in nothing being changed when modifying the sched_relax_domain_level parameter. This patch is able to address that problem by having update_domain_attr_tree() allow updates for the root in the cpuset traversal. Fixes: fc560a26acce ("cpuset: replace cpuset->stack_list with cpuset_for_each_descendant_pre()") Signed-off-by: Jason Low <jason.low2@hp.com> Signed-off-by: Zefan Li <lizefan@huawei.com> Signed-off-by: Tejun Heo <tj@kernel.org> Tested-by: Serge Hallyn <serge.hallyn@canonical.com> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
-rw-r--r--kernel/cpuset.c3
1 files changed, 0 insertions, 3 deletions
diff --git a/kernel/cpuset.c b/kernel/cpuset.c
index c8289138cad4..b5f0faa4bfbd 100644
--- a/kernel/cpuset.c
+++ b/kernel/cpuset.c
@@ -503,9 +503,6 @@ static void update_domain_attr_tree(struct sched_domain_attr *dattr,
rcu_read_lock();
cpuset_for_each_descendant_pre(cp, pos_css, root_cs) {
- if (cp == root_cs)
- continue;
-
/* skip the whole subtree if @cp doesn't have any CPU */
if (cpumask_empty(cp->cpus_allowed)) {
pos_css = css_rightmost_descendant(pos_css);