diff options
| author | Sanchayan Maity <maitysanchayan@gmail.com> | 2016-05-18 18:37:44 +0530 |
|---|---|---|
| committer | Marcel Ziswiler <marcel.ziswiler@toradex.com> | 2017-01-10 23:13:24 +0100 |
| commit | 358a46afbf83035dc02d7b017088d5644ef9a74e (patch) | |
| tree | aa083b34f46d57357b2a006cfd7ddf7b588133f9 | |
| parent | 80aae0b2253258df3bd056a719de3b1b1c5b223a (diff) | |
mxc_v4l2_capture: Change error message to print on debug
Change the "unsupported ioctrl" message to print only on debug.
This otherwise results in an error message
ERROR: v4l2 capture: unsupported ioctrl!
which does not seem to effect the gstreamer pipeline or rendering
of video.
>From debugging,
root@apalis-imx6:~# gst-launch-1.0 imxv4l2videosrc ! imxeglvivsink
Setting pipeline to PAUSED ...
[ 385.174543] ERROR: v4l2 capture: unsupported ioctrl 9a091b!
Pipeline is live and does not need PREROLL ...
Setting pipeline to PLAYING ...
New clock: GstSystemClock
>From v4l2-controls.h
V4L2_CTRL_CLASS_CAMERA 0x009a0000
V4L2_CID_CAMERA_CLASS_BASE V4L2_CTRL_CLASS_CAMERA | 0x900
V4L2_CID_3A_LOCK V4L2_CID_CAMERA_CLASS_BASE + 27
So the ioctrl requested seems to be V4L2_CID_3A_LOCK.
"The V4L2_CID_3A_LOCK bitmask control allows applications to pause
or resume the automatic exposure, focus and wite balance adjustments.
It can be used, for example, to lock the 3A adjustments right before
a still image is captured, for pre-focus, etc.
The applications can control each of the algorithms independently,
through a corresponding control bit, if driver allows that."
https://patchwork.linuxtv.org/patch/10719/
Since we have no such feature available we can safely disable the
error message.
Signed-off-by: Sanchayan Maity <sanchayan.maity@toradex.com>
Acked-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
(cherry picked from commit f1b52e225091711d60704717af34c2f321c032b3)
| -rw-r--r-- | drivers/media/platform/mxc/capture/mxc_v4l2_capture.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/media/platform/mxc/capture/mxc_v4l2_capture.c b/drivers/media/platform/mxc/capture/mxc_v4l2_capture.c index 25a3a2b130a3..de198ca1e69f 100644 --- a/drivers/media/platform/mxc/capture/mxc_v4l2_capture.c +++ b/drivers/media/platform/mxc/capture/mxc_v4l2_capture.c @@ -1069,7 +1069,7 @@ static int mxc_v4l2_g_ctrl(cam_data *cam, struct v4l2_control *c) } break; default: - pr_err("ERROR: v4l2 capture: unsupported ioctrl!\n"); + pr_debug("ERROR: v4l2 capture: unsupported ioctrl!\n"); } return status; |