summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJaegeuk Kim <jaegeuk.kim@samsung.com>2013-03-16 08:34:37 +0900
committerJaegeuk Kim <jaegeuk.kim@samsung.com>2013-03-20 18:30:13 +0900
commit04431c44e55613a91ced16c523f749c08dff91bf (patch)
tree565b9007485b1efbe6b477eefa4c70f91dfbab98
parentc3850aa1cb25872fddacd7abd8dfb021411e92ee (diff)
f2fs: fix not to allocate max_nid
The build_free_nid should not add free nids over nm_i->max_nid. But, there was a hole that invalid free nid was added by the following scenario. Let's suppose nm_i->max_nid = 150 and the last NAT page has 100 ~ 200 nids. build_free_nids - get_current_nat_page loads the last NAT page - scan_nat_page can add 100 ~ 200 nids -> Bug here! So, when scanning an NAT page, we should check each candidate whether it is over max_nid or not. Reviewed-by: Namjae Jeon <namjae.jeon@samsung.com> Signed-off-by: Jaegeuk Kim <jaegeuk.kim@samsung.com>
-rw-r--r--fs/f2fs/node.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c
index bf9172bbbb00..f7b03ba9c0d7 100644
--- a/fs/f2fs/node.c
+++ b/fs/f2fs/node.c
@@ -1268,6 +1268,8 @@ static int scan_nat_page(struct f2fs_nm_info *nm_i,
i = start_nid % NAT_ENTRY_PER_BLOCK;
for (; i < NAT_ENTRY_PER_BLOCK; i++, start_nid++) {
+ if (start_nid >= nm_i->max_nid)
+ break;
blk_addr = le32_to_cpu(nat_blk->entries[i].block_addr);
BUG_ON(blk_addr == NEW_ADDR);
if (blk_addr == NULL_ADDR)