diff options
| author | Mike Snitzer <snitzer@redhat.com> | 2014-07-14 16:59:39 -0400 |
|---|---|---|
| committer | Jiri Slaby <jslaby@suse.cz> | 2014-07-29 17:01:46 +0200 |
| commit | e0779220de345bf4cd25873367ee61021ffa1d7e (patch) | |
| tree | a19edf1a7d557fedf91830c8f709ef4151e9f3dc | |
| parent | c355b2e35e910d4aa740c4009d5cd62b0698c6c2 (diff) | |
dm cache metadata: do not allow the data block size to change
commit 048e5a07f282c57815b3901d4a68a77fa131ce0a upstream.
The block size for the dm-cache's data device must remained fixed for
the life of the cache. Disallow any attempt to change the cache's data
block size.
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Acked-by: Joe Thornber <ejt@redhat.com>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
| -rw-r--r-- | drivers/md/dm-cache-metadata.c | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/drivers/md/dm-cache-metadata.c b/drivers/md/dm-cache-metadata.c index 1d38019bb022..b564c0610259 100644 --- a/drivers/md/dm-cache-metadata.c +++ b/drivers/md/dm-cache-metadata.c @@ -407,6 +407,15 @@ static int __open_metadata(struct dm_cache_metadata *cmd) disk_super = dm_block_data(sblock); + /* Verify the data block size hasn't changed */ + if (le32_to_cpu(disk_super->data_block_size) != cmd->data_block_size) { + DMERR("changing the data block size (from %u to %llu) is not supported", + le32_to_cpu(disk_super->data_block_size), + (unsigned long long)cmd->data_block_size); + r = -EINVAL; + goto bad; + } + r = __check_incompat_features(disk_super, cmd); if (r < 0) goto bad; |