diff options
author | Jean Delvare <jdelvare@suse.de> | 2015-04-20 11:21:13 +0200 |
---|---|---|
committer | Jiri Slaby <jslaby@suse.cz> | 2015-06-03 11:33:13 +0200 |
commit | bca746037a308e2fbe742248d34635f07be2bfd9 (patch) | |
tree | 53b2ddcacbea735d04aa234d1e5baea7f5ab594a | |
parent | d07438719e3e56dc710695c4fe0ec93f6b8de8bc (diff) |
thermal: step_wise: Revert optimization
Commit 178c2490b99f898efc06d1ad75cadc84f13021a6 ("thermal: step_wise:
cdev only needs update on a new target state") broke driver acerhdf.
That driver abused the step_wise thermal governor until the bang_bang
governor was available, and the optimization broke this usage model.
Kernels v3.12 to v3.18 are affected. In v3.19 the acerhdf driver was
switched to the bang_bang governor and that solved the problem.
For kernels v3.12 to v3.17, the bang_bang governor isn't available
yet so the easiest fix is to revert the optimization.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
Reported-by: Dieter Jurzitza (https://bugzilla.opensuse.org/show_bug.cgi?id=925961)
Tested-by: Peter Feuerer <peter@piie.net>
Tested-by: Dieter Jurzitza
-rw-r--r-- | drivers/thermal/step_wise.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/thermal/step_wise.c b/drivers/thermal/step_wise.c index d89e781b0a18..769bfa3a4360 100644 --- a/drivers/thermal/step_wise.c +++ b/drivers/thermal/step_wise.c @@ -140,9 +140,6 @@ static void thermal_zone_trip_update(struct thermal_zone_device *tz, int trip) old_target = instance->target; instance->target = get_target_state(instance, trend, throttle); - if (old_target == instance->target) - continue; - /* Activate a passive thermal instance */ if (old_target == THERMAL_NO_TARGET && instance->target != THERMAL_NO_TARGET) |