diff options
| author | Julia Lawall <Julia.Lawall@lip6.fr> | 2015-04-05 14:06:36 +0200 |
|---|---|---|
| committer | Jiri Slaby <jslaby@suse.cz> | 2015-06-10 13:46:23 +0200 |
| commit | d7ef875d4e413eaccbd550f9b638e1b9e4201dc6 (patch) | |
| tree | a6b67e8454cc25952fb03b46283e453e5a6fc292 | |
| parent | fd4420aba84b13da95605dfec7721d10dcdcad46 (diff) | |
NFC: pn533: fix error return code
commit 5df848f37b1d20e5dd64bea16ba9f69ed321e11b upstream.
Return a negative error code on failure.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@@
identifier ret; expression e1,e2;
@@
(
if (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
ret = 0
)
... when != ret = e1
when != &ret
*if(...)
{
... when != ret = e2
when forall
return ret;
}
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
| -rw-r--r-- | drivers/nfc/pn533.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/nfc/pn533.c b/drivers/nfc/pn533.c index 5df730be88a3..30e50987b8df 100644 --- a/drivers/nfc/pn533.c +++ b/drivers/nfc/pn533.c @@ -2352,8 +2352,10 @@ static int pn533_data_exchange_complete(struct pn533 *dev, void *_arg, } skb = pn533_build_response(dev); - if (!skb) + if (!skb) { + rc = -ENOMEM; goto error; + } arg->cb(arg->cb_context, skb, 0); kfree(arg); |