diff options
| author | Thierry Reding <treding@nvidia.com> | 2015-02-25 16:16:29 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2015-04-13 14:03:53 +0200 |
| commit | 78dc9937928e17b285d66d5173aceff46fd69e0b (patch) | |
| tree | c0552ed368bc64a5ec2c6f0eb6d7f7ac4005dfcb | |
| parent | 75d10b6098a419dca452c86ee6b2f4117006f826 (diff) | |
phy: Find the right match in devm_phy_destroy()
commit 2f1bce487cd0a02623cff3d877940f9a2026341c upstream.
devm_phy_create() stores the pointer to the new PHY at the address
returned by devres_alloc(). The res parameter passed to devm_phy_match()
is therefore the location where the pointer to the PHY is stored, hence
it needs to be dereferenced before comparing to the match data in order
to find the correct match.
Signed-off-by: Thierry Reding <treding@nvidia.com>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/phy/phy-core.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-core.c index a12d35338313..04fc84f2b289 100644 --- a/drivers/phy/phy-core.c +++ b/drivers/phy/phy-core.c @@ -52,7 +52,9 @@ static void devm_phy_consume(struct device *dev, void *res) static int devm_phy_match(struct device *dev, void *res, void *match_data) { - return res == match_data; + struct phy **phy = res; + + return *phy == match_data; } /** |