diff options
| author | Jeff Layton <jlayton@redhat.com> | 2012-07-23 15:51:55 -0400 |
|---|---|---|
| committer | Ben Hutchings <ben@decadent.org.uk> | 2013-05-30 14:35:04 +0100 |
| commit | a27e05b0cf32d711c1ec57625b6053658efd11fc (patch) | |
| tree | 433681f96ef21b748c50ce747b306363d7555b25 | |
| parent | 40a2e8cd0cb2548bb78a8b8b3ace6b911f2bb98b (diff) | |
sunrpc: clarify comments on rpc_make_runnable
commit 506026c3ec270e18402f0c9d33fee37482c23861 upstream.
rpc_make_runnable is not generally called with the queue lock held, unless
it's waking up a task that has been sitting on a waitqueue. This is safe
when the task has not entered the FSM yet, but the comments don't really
spell this out.
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
| -rw-r--r-- | net/sunrpc/sched.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/net/sunrpc/sched.c b/net/sunrpc/sched.c index dc6af2748e25..150848bf717c 100644 --- a/net/sunrpc/sched.c +++ b/net/sunrpc/sched.c @@ -296,8 +296,9 @@ EXPORT_SYMBOL_GPL(__rpc_wait_for_completion_task); /* * Make an RPC task runnable. * - * Note: If the task is ASYNC, this must be called with - * the spinlock held to protect the wait queue operation. + * Note: If the task is ASYNC, and is being made runnable after sitting on an + * rpc_wait_queue, this must be called with the queue spinlock held to protect + * the wait queue operation. */ static void rpc_make_runnable(struct rpc_task *task) { |