diff options
| author | Boaz Harrosh <bharrosh@panasas.com> | 2009-08-04 20:40:29 +0300 |
|---|---|---|
| committer | Boaz Harrosh <bharrosh@panasas.com> | 2009-12-10 09:59:19 +0200 |
| commit | 9cfdc7aa9f1b59627029ad00a58c3f59eb2cc383 (patch) | |
| tree | 62b60dccb98ff71a332fbccd5f69e6a6416818c9 | |
| parent | fe33cc1ee170c0e3b47ab9cbac07083b3446961c (diff) | |
exofs: refactor exofs_i_info initialization into common helper
There are two places that initialize inodes: exofs_iget() and
exofs_new_inode()
As more members of exofs_i_info that need initialization are
added this code will grow. (soon)
Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>
| -rw-r--r-- | fs/exofs/inode.c | 10 |
1 files changed, 8 insertions, 2 deletions
diff --git a/fs/exofs/inode.c b/fs/exofs/inode.c index 01fa798e8fdb..7bc71a7d30a8 100644 --- a/fs/exofs/inode.c +++ b/fs/exofs/inode.c @@ -908,6 +908,12 @@ out: return ret; } + +static void __oi_init(struct exofs_i_info *oi) +{ + init_waitqueue_head(&oi->i_wq); + oi->i_flags = 0; +} /* * Fill in an inode read from the OSD and set it up for use */ @@ -925,13 +931,13 @@ struct inode *exofs_iget(struct super_block *sb, unsigned long ino) if (!(inode->i_state & I_NEW)) return inode; oi = exofs_i(inode); + __oi_init(oi); /* read the inode from the osd */ ret = exofs_get_inode(sb, oi, &fcb, &sanity); if (ret) goto bad_inode; - init_waitqueue_head(&oi->i_wq); set_obj_created(oi); /* copy stuff from on-disk struct to in-memory struct */ @@ -1062,8 +1068,8 @@ struct inode *exofs_new_inode(struct inode *dir, int mode) return ERR_PTR(-ENOMEM); oi = exofs_i(inode); + __oi_init(oi); - init_waitqueue_head(&oi->i_wq); set_obj_2bcreated(oi); sbi = sb->s_fs_info; |