diff options
| author | Bart Van Assche <bart.vanassche@gmail.com> | 2013-05-21 20:43:50 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2013-07-20 17:16:08 -0700 |
| commit | a3d56dfedb4ac5e8cdc6e6a0a54ed33ae2253c83 (patch) | |
| tree | 2c534d36cf41b9d1e113ef5773d28af6a6a80bb6 | |
| parent | 95a5e329938d9a57365ff6d84de17772910ea9a6 (diff) | |
timer: Fix jiffies wrap behavior of round_jiffies_common()
commit 9e04d3804d3ac97d8c03a41d78d0f0674b5d01e1 upstream.
Direct compare of jiffies related values does not work in the wrap
around case. Replace it with time_is_after_jiffies().
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Cc: Arjan van de Ven <arjan@infradead.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
Link: http://lkml.kernel.org/r/519BC066.5080600@acm.org
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | kernel/timer.c | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/kernel/timer.c b/kernel/timer.c index 1b399c89e3a0..3361cff2c83d 100644 --- a/kernel/timer.c +++ b/kernel/timer.c @@ -148,9 +148,11 @@ static unsigned long round_jiffies_common(unsigned long j, int cpu, /* now that we have rounded, subtract the extra skew again */ j -= cpu * 3; - if (j <= jiffies) /* rounding ate our timeout entirely; */ - return original; - return j; + /* + * Make sure j is still in the future. Otherwise return the + * unmodified value. + */ + return time_is_after_jiffies(j) ? j : original; } /** |