diff options
| author | Axel Lin <axel.lin@ingics.com> | 2014-08-05 09:59:49 +0800 |
|---|---|---|
| committer | Jiri Slaby <jslaby@suse.cz> | 2014-09-03 21:31:22 +0200 |
| commit | 64e6fad527f5b9f345f5c4029fc5233855c8440b (patch) | |
| tree | b00107cc4e577b2aef7cae2b709a6c1c59ee65be | |
| parent | cd072b3e9ba4497380c5e6d27b7f16f7d78a9c7c (diff) | |
hwmon: (ads1015) Fix out-of-bounds array access
commit e981429557cbe10c780fab1c1a237cb832757652 upstream.
Current code uses data_rate as array index in ads1015_read_adc() and uses pga
as array index in ads1015_reg_to_mv, so we must make sure both data_rate and
pga settings are in valid value range.
Return -EINVAL if the setting is out-of-range.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
| -rw-r--r-- | drivers/hwmon/ads1015.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/hwmon/ads1015.c b/drivers/hwmon/ads1015.c index 22e0c926989d..126516414c11 100644 --- a/drivers/hwmon/ads1015.c +++ b/drivers/hwmon/ads1015.c @@ -212,6 +212,7 @@ static int ads1015_get_channels_config_of(struct i2c_client *client) dev_err(&client->dev, "invalid gain on %s\n", node->full_name); + return -EINVAL; } } @@ -222,6 +223,7 @@ static int ads1015_get_channels_config_of(struct i2c_client *client) dev_err(&client->dev, "invalid data_rate on %s\n", node->full_name); + return -EINVAL; } } |