diff options
| author | Julia Lawall <julia@diku.dk> | 2009-08-31 21:34:25 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2009-09-15 12:02:33 -0700 |
| commit | 18526c7896fca5229c8d7b4b415605a17f9952d0 (patch) | |
| tree | 8772060e92595fef0d58892300abc5d5a89c14c7 | |
| parent | c07d3c75a76d93f00182af2c6b750a52ea4d9869 (diff) | |
Staging: rtl8192e: Drop unnecessary NULL test
The result of container_of should not be NULL. In particular, in this case
the argument to the enclosing function has passed though INIT_WORK, which
dereferences it, implying that its container cannot be NULL.
A simplified version of the semantic patch that makes this change is as
follows:
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@@
identifier fn,work,x,fld;
type T;
expression E1,E2;
statement S;
@@
static fn(struct work_struct *work) {
... when != work = E1
x = container_of(work,T,fld)
... when != x = E2
- if (x == NULL) S
...
}
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| -rw-r--r-- | drivers/staging/rtl8192e/r8192E_core.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/staging/rtl8192e/r8192E_core.c b/drivers/staging/rtl8192e/r8192E_core.c index 681488bf6534..d4fa65489655 100644 --- a/drivers/staging/rtl8192e/r8192E_core.c +++ b/drivers/staging/rtl8192e/r8192E_core.c @@ -1763,8 +1763,6 @@ static void rtl8192_qos_activate(struct work_struct * work) u8 u1bAIFS; u32 u4bAcParam; int i; - if (priv == NULL) - return; mutex_lock(&priv->mutex); if(priv->ieee80211->state != IEEE80211_LINKED) |