diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2013-11-07 10:52:00 +0300 |
|---|---|---|
| committer | Vinod Koul <vinod.koul@intel.com> | 2014-03-11 14:23:18 +0530 |
| commit | 8f83f502290e75b927de65b2e26f56c2d4736fac (patch) | |
| tree | 660e439a917656637ed040a423ad26e3ea2b0d22 | |
| parent | 4de9b3b0442cdb6d604069b47ffe920813ef6710 (diff) | |
dmaengine: s3c24xx-dma: make phy->irq signed for error handling
There is a bug in s3c24xx_dma_probe() where we do:
phy->irq = platform_get_irq(pdev, i);
if (phy->irq < 0) {
The problem is that "phy->irq" is unsigned so the error handling doesn't
work. I have changed it to signed.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
| -rw-r--r-- | drivers/dma/s3c24xx-dma.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/dma/s3c24xx-dma.c b/drivers/dma/s3c24xx-dma.c index 4eddedb6eb7d..b209a0f17344 100644 --- a/drivers/dma/s3c24xx-dma.c +++ b/drivers/dma/s3c24xx-dma.c @@ -192,7 +192,7 @@ struct s3c24xx_dma_phy { unsigned int id; bool valid; void __iomem *base; - unsigned int irq; + int irq; struct clk *clk; spinlock_t lock; struct s3c24xx_dma_chan *serving; |