summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMartin Kelly <mkelly@xevo.com>2017-12-05 11:15:50 -0800
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2017-12-14 09:28:10 +0100
commit4b4e6f675846c0700fae441f30bcb18dca074af7 (patch)
tree58abe5972329faa33232cbe8129fb74559d3fe86
parent0cdac09e6aeefed8058e913943c7c8765017afdc (diff)
can: usb_8dev: cancel urb on -EPIPE and -EPROTO
commit 12147edc434c9e4c7c2f5fee2e5519b2e5ac34ce upstream. In mcba_usb, we have observed that when you unplug the device, the driver will endlessly resubmit failing URBs, which can cause CPU stalls. This issue is fixed in mcba_usb by catching the codes seen on device disconnect (-EPIPE and -EPROTO). This driver also resubmits in the case of -EPIPE and -EPROTO, so fix it in the same way. Signed-off-by: Martin Kelly <mkelly@xevo.com> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/net/can/usb/usb_8dev.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/net/can/usb/usb_8dev.c b/drivers/net/can/usb/usb_8dev.c
index d000cb62d6ae..27861c417c94 100644
--- a/drivers/net/can/usb/usb_8dev.c
+++ b/drivers/net/can/usb/usb_8dev.c
@@ -524,6 +524,8 @@ static void usb_8dev_read_bulk_callback(struct urb *urb)
break;
case -ENOENT:
+ case -EPIPE:
+ case -EPROTO:
case -ESHUTDOWN:
return;